Skip to content

feat(cu): add fenced OpenAI computer observation loop - #920

Closed
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop
Closed

feat(cu): add fenced OpenAI computer observation loop#920
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

Adds a provider-native OpenAI Responses computer-call codec, bounded transport, and pure loop as an observation-only experimental surface.

This is not the primary Maka Computer path. The primary product path remains the provider-neutral maka_computer function tool, where the model observes an AX tree and explicitly uses semantic element actions. The native OpenAI loop does not implicitly convert coordinates into Accessibility elements.

Safety boundary

  • default native actions: screenshot, wait, and visual-only move;
  • click, type, scroll, drag, and keypress are rejected before execution unless a future caller supplies an explicit policy backed by an isolated executor;
  • the whole action batch is validated before its first side effect;
  • pending safety checks require explicit acknowledgement;
  • parallel computer calls fail closed;
  • failed/incomplete Responses are not treated as completion;
  • continuation uses the exact response and call IDs with a screenshot output.

Protocol hardening

  • strict GA actions[] and preview action dialects remain separate;
  • stable safety instructions stay outside user input;
  • parallel_tool_calls is disabled;
  • Responses bodies are capped at 16 MiB;
  • HTTP error details are bounded and redacted;
  • malformed success JSON does not echo response content;
  • OpenAI strict-object adapter emits all properties required+nullable, rejects unknown/accessor keys, and projects known fields per action without weakening the core parser.

Real evidence

Using the local Azure Responses bridge and gpt-5.6-sol, the GA native computer tool returned only screenshot under the default policy. The new transport/codec/loop completed the screenshot continuation in two turns and executed no physical input action.

Verification

  • Runtime full suite: 1530 pass, 7 skip, 0 fail.
  • Full repository build and typecheck pass.
  • Focused action/codec/loop/policy/transport/strict-adapter tests pass.
  • No Desktop, Computer Use executor, or provider credential files are modified.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

@Astro-Han#920 is clean and all CI checks pass. It is deliberately observation-only by default: real gpt-5.6-sol via the Azure Responses bridge completed a two-turn native computer screenshot continuation with no physical input action. The primary Accessibility-first product model path is isolated in fork stacked PR hqhq1025#9 and will be opened upstream after #920 merges.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Ready for review. This remains an observation-only native OpenAI surface; the primary product mutation path is the AX-first provider-neutral function tool continued in #925. cc @Astro-Han

@hqhq1025
hqhq1025force-pushed the codex/cu-openai-observation-loop branch from 14c0387 to 258dba8CompareJuly 13, 2026 20:27

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did not find a P0 or P1. The loop is still an explicit experimental API rather than the default product path, so these are non-blocking P2/P3 findings:

  • P2 — packages/runtime/src/openai-computer-codec.ts:49-57,150-214 and openai-responses-transport.ts:41-46: requests do not include the Responses API store body field, so desktop screenshots inherit the API's default retention. The transport test's store=false query parameter does not set the request-body option. Make the storage choice explicit, or use a continuation that does not depend on a stored response.

  • P2 — packages/runtime/src/openai-computer-loop.ts:84-101: top-level in_progress and per-call in_progress/incomplete states are accepted as actionable. An empty in_progress response is returned as completed, while an incomplete call's actions are executed. Only terminal completed responses and calls should advance the loop.

  • P2 — packages/runtime/src/openai-computer-loop.ts:24-48,157-164: once a batch starts, the result type cannot represent partial delivery or an unknown outcome. If action two throws after action one succeeded, the caller receives only the raw exception and can retry the already-delivered action.

  • P2 — packages/runtime/src/openai-computer-loop.ts:157-176: the final allowed turn still executes its actions and captures a screenshot, then throws max_turns_exceeded without sending that screenshot or reporting the delivered actions. Check the continuation budget before dispatch, or return the delivery state.

  • P2 — packages/runtime/src/openai-computer-codec.ts:73-76 and openai-computer-loop.ts:74-78: maxTurns limits responses, not actions, and it accepts Infinity. One response can contain an unbounded actions[]; even the default-allowed wait action consumes two seconds per item. Add finite turn and per-batch action limits.

  • P2 — packages/runtime/src/openai-computer-actions.ts:78-83,108-112: the default policy calls this path observation-only but allows move, which is converted to a raw host coordinate and sent to an executor with no isolated-target or display-identity proof. A normal host executor can therefore move the user's real pointer without allowAction.

  • P3 — packages/runtime/src/openai-computer-actions.ts:108-110 and openai-computer-loop.ts:157-164: a provider screenshot action is sent through the executor, then the screenshot provider is called unconditionally. That turns one requested capture into two capture paths while discarding the executor's result.

  • P3 — packages/runtime/src/openai-computer-loop.ts:74-81: when no signal is supplied, the loop creates an AbortController that never aborts. A stalled transport, executor, or capture can hang forever despite maxTurns; add a default deadline or make the required caller timeout explicit.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Superseded by #985, which consolidates #920 and #925 on current main and includes the outstanding review fixes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hqhq1025@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(cu): add fenced OpenAI computer observation loop by hqhq1025 · Pull Request #920 · apache/maka · GitHub
Skip to content

feat(cu): add fenced OpenAI computer observation loop - #920

Closed
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop
Closed

feat(cu): add fenced OpenAI computer observation loop#920
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

Adds a provider-native OpenAI Responses computer-call codec, bounded transport, and pure loop as an observation-only experimental surface.

This is not the primary Maka Computer path. The primary product path remains the provider-neutral maka_computer function tool, where the model observes an AX tree and explicitly uses semantic element actions. The native OpenAI loop does not implicitly convert coordinates into Accessibility elements.

Safety boundary

  • default native actions: screenshot, wait, and visual-only move;
  • click, type, scroll, drag, and keypress are rejected before execution unless a future caller supplies an explicit policy backed by an isolated executor;
  • the whole action batch is validated before its first side effect;
  • pending safety checks require explicit acknowledgement;
  • parallel computer calls fail closed;
  • failed/incomplete Responses are not treated as completion;
  • continuation uses the exact response and call IDs with a screenshot output.

Protocol hardening

  • strict GA actions[] and preview action dialects remain separate;
  • stable safety instructions stay outside user input;
  • parallel_tool_calls is disabled;
  • Responses bodies are capped at 16 MiB;
  • HTTP error details are bounded and redacted;
  • malformed success JSON does not echo response content;
  • OpenAI strict-object adapter emits all properties required+nullable, rejects unknown/accessor keys, and projects known fields per action without weakening the core parser.

Real evidence

Using the local Azure Responses bridge and gpt-5.6-sol, the GA native computer tool returned only screenshot under the default policy. The new transport/codec/loop completed the screenshot continuation in two turns and executed no physical input action.

Verification

  • Runtime full suite: 1530 pass, 7 skip, 0 fail.
  • Full repository build and typecheck pass.
  • Focused action/codec/loop/policy/transport/strict-adapter tests pass.
  • No Desktop, Computer Use executor, or provider credential files are modified.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

@Astro-Han#920 is clean and all CI checks pass. It is deliberately observation-only by default: real gpt-5.6-sol via the Azure Responses bridge completed a two-turn native computer screenshot continuation with no physical input action. The primary Accessibility-first product model path is isolated in fork stacked PR hqhq1025#9 and will be opened upstream after #920 merges.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Ready for review. This remains an observation-only native OpenAI surface; the primary product mutation path is the AX-first provider-neutral function tool continued in #925. cc @Astro-Han

@hqhq1025
hqhq1025force-pushed the codex/cu-openai-observation-loop branch from 14c0387 to 258dba8CompareJuly 13, 2026 20:27

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did not find a P0 or P1. The loop is still an explicit experimental API rather than the default product path, so these are non-blocking P2/P3 findings:

  • P2 — packages/runtime/src/openai-computer-codec.ts:49-57,150-214 and openai-responses-transport.ts:41-46: requests do not include the Responses API store body field, so desktop screenshots inherit the API's default retention. The transport test's store=false query parameter does not set the request-body option. Make the storage choice explicit, or use a continuation that does not depend on a stored response.

  • P2 — packages/runtime/src/openai-computer-loop.ts:84-101: top-level in_progress and per-call in_progress/incomplete states are accepted as actionable. An empty in_progress response is returned as completed, while an incomplete call's actions are executed. Only terminal completed responses and calls should advance the loop.

  • P2 — packages/runtime/src/openai-computer-loop.ts:24-48,157-164: once a batch starts, the result type cannot represent partial delivery or an unknown outcome. If action two throws after action one succeeded, the caller receives only the raw exception and can retry the already-delivered action.

  • P2 — packages/runtime/src/openai-computer-loop.ts:157-176: the final allowed turn still executes its actions and captures a screenshot, then throws max_turns_exceeded without sending that screenshot or reporting the delivered actions. Check the continuation budget before dispatch, or return the delivery state.

  • P2 — packages/runtime/src/openai-computer-codec.ts:73-76 and openai-computer-loop.ts:74-78: maxTurns limits responses, not actions, and it accepts Infinity. One response can contain an unbounded actions[]; even the default-allowed wait action consumes two seconds per item. Add finite turn and per-batch action limits.

  • P2 — packages/runtime/src/openai-computer-actions.ts:78-83,108-112: the default policy calls this path observation-only but allows move, which is converted to a raw host coordinate and sent to an executor with no isolated-target or display-identity proof. A normal host executor can therefore move the user's real pointer without allowAction.

  • P3 — packages/runtime/src/openai-computer-actions.ts:108-110 and openai-computer-loop.ts:157-164: a provider screenshot action is sent through the executor, then the screenshot provider is called unconditionally. That turns one requested capture into two capture paths while discarding the executor's result.

  • P3 — packages/runtime/src/openai-computer-loop.ts:74-81: when no signal is supplied, the loop creates an AbortController that never aborts. A stalled transport, executor, or capture can hang forever despite maxTurns; add a default deadline or make the required caller timeout explicit.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Superseded by #985, which consolidates #920 and #925 on current main and includes the outstanding review fixes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hqhq1025@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(cu): add fenced OpenAI computer observation loop by hqhq1025 · Pull Request #920 · apache/maka · GitHub
Skip to content

feat(cu): add fenced OpenAI computer observation loop - #920

Closed
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop
Closed

feat(cu): add fenced OpenAI computer observation loop#920
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

Adds a provider-native OpenAI Responses computer-call codec, bounded transport, and pure loop as an observation-only experimental surface.

This is not the primary Maka Computer path. The primary product path remains the provider-neutral maka_computer function tool, where the model observes an AX tree and explicitly uses semantic element actions. The native OpenAI loop does not implicitly convert coordinates into Accessibility elements.

Safety boundary

  • default native actions: screenshot, wait, and visual-only move;
  • click, type, scroll, drag, and keypress are rejected before execution unless a future caller supplies an explicit policy backed by an isolated executor;
  • the whole action batch is validated before its first side effect;
  • pending safety checks require explicit acknowledgement;
  • parallel computer calls fail closed;
  • failed/incomplete Responses are not treated as completion;
  • continuation uses the exact response and call IDs with a screenshot output.

Protocol hardening

  • strict GA actions[] and preview action dialects remain separate;
  • stable safety instructions stay outside user input;
  • parallel_tool_calls is disabled;
  • Responses bodies are capped at 16 MiB;
  • HTTP error details are bounded and redacted;
  • malformed success JSON does not echo response content;
  • OpenAI strict-object adapter emits all properties required+nullable, rejects unknown/accessor keys, and projects known fields per action without weakening the core parser.

Real evidence

Using the local Azure Responses bridge and gpt-5.6-sol, the GA native computer tool returned only screenshot under the default policy. The new transport/codec/loop completed the screenshot continuation in two turns and executed no physical input action.

Verification

  • Runtime full suite: 1530 pass, 7 skip, 0 fail.
  • Full repository build and typecheck pass.
  • Focused action/codec/loop/policy/transport/strict-adapter tests pass.
  • No Desktop, Computer Use executor, or provider credential files are modified.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

@Astro-Han#920 is clean and all CI checks pass. It is deliberately observation-only by default: real gpt-5.6-sol via the Azure Responses bridge completed a two-turn native computer screenshot continuation with no physical input action. The primary Accessibility-first product model path is isolated in fork stacked PR hqhq1025#9 and will be opened upstream after #920 merges.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Ready for review. This remains an observation-only native OpenAI surface; the primary product mutation path is the AX-first provider-neutral function tool continued in #925. cc @Astro-Han

@hqhq1025
hqhq1025force-pushed the codex/cu-openai-observation-loop branch from 14c0387 to 258dba8CompareJuly 13, 2026 20:27

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did not find a P0 or P1. The loop is still an explicit experimental API rather than the default product path, so these are non-blocking P2/P3 findings:

  • P2 — packages/runtime/src/openai-computer-codec.ts:49-57,150-214 and openai-responses-transport.ts:41-46: requests do not include the Responses API store body field, so desktop screenshots inherit the API's default retention. The transport test's store=false query parameter does not set the request-body option. Make the storage choice explicit, or use a continuation that does not depend on a stored response.

  • P2 — packages/runtime/src/openai-computer-loop.ts:84-101: top-level in_progress and per-call in_progress/incomplete states are accepted as actionable. An empty in_progress response is returned as completed, while an incomplete call's actions are executed. Only terminal completed responses and calls should advance the loop.

  • P2 — packages/runtime/src/openai-computer-loop.ts:24-48,157-164: once a batch starts, the result type cannot represent partial delivery or an unknown outcome. If action two throws after action one succeeded, the caller receives only the raw exception and can retry the already-delivered action.

  • P2 — packages/runtime/src/openai-computer-loop.ts:157-176: the final allowed turn still executes its actions and captures a screenshot, then throws max_turns_exceeded without sending that screenshot or reporting the delivered actions. Check the continuation budget before dispatch, or return the delivery state.

  • P2 — packages/runtime/src/openai-computer-codec.ts:73-76 and openai-computer-loop.ts:74-78: maxTurns limits responses, not actions, and it accepts Infinity. One response can contain an unbounded actions[]; even the default-allowed wait action consumes two seconds per item. Add finite turn and per-batch action limits.

  • P2 — packages/runtime/src/openai-computer-actions.ts:78-83,108-112: the default policy calls this path observation-only but allows move, which is converted to a raw host coordinate and sent to an executor with no isolated-target or display-identity proof. A normal host executor can therefore move the user's real pointer without allowAction.

  • P3 — packages/runtime/src/openai-computer-actions.ts:108-110 and openai-computer-loop.ts:157-164: a provider screenshot action is sent through the executor, then the screenshot provider is called unconditionally. That turns one requested capture into two capture paths while discarding the executor's result.

  • P3 — packages/runtime/src/openai-computer-loop.ts:74-81: when no signal is supplied, the loop creates an AbortController that never aborts. A stalled transport, executor, or capture can hang forever despite maxTurns; add a default deadline or make the required caller timeout explicit.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Superseded by #985, which consolidates #920 and #925 on current main and includes the outstanding review fixes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hqhq1025@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(cu): add fenced OpenAI computer observation loop by hqhq1025 · Pull Request #920 · apache/maka · GitHub
Skip to content

feat(cu): add fenced OpenAI computer observation loop - #920

Closed
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop
Closed

feat(cu): add fenced OpenAI computer observation loop#920
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

Adds a provider-native OpenAI Responses computer-call codec, bounded transport, and pure loop as an observation-only experimental surface.

This is not the primary Maka Computer path. The primary product path remains the provider-neutral maka_computer function tool, where the model observes an AX tree and explicitly uses semantic element actions. The native OpenAI loop does not implicitly convert coordinates into Accessibility elements.

Safety boundary

  • default native actions: screenshot, wait, and visual-only move;
  • click, type, scroll, drag, and keypress are rejected before execution unless a future caller supplies an explicit policy backed by an isolated executor;
  • the whole action batch is validated before its first side effect;
  • pending safety checks require explicit acknowledgement;
  • parallel computer calls fail closed;
  • failed/incomplete Responses are not treated as completion;
  • continuation uses the exact response and call IDs with a screenshot output.

Protocol hardening

  • strict GA actions[] and preview action dialects remain separate;
  • stable safety instructions stay outside user input;
  • parallel_tool_calls is disabled;
  • Responses bodies are capped at 16 MiB;
  • HTTP error details are bounded and redacted;
  • malformed success JSON does not echo response content;
  • OpenAI strict-object adapter emits all properties required+nullable, rejects unknown/accessor keys, and projects known fields per action without weakening the core parser.

Real evidence

Using the local Azure Responses bridge and gpt-5.6-sol, the GA native computer tool returned only screenshot under the default policy. The new transport/codec/loop completed the screenshot continuation in two turns and executed no physical input action.

Verification

  • Runtime full suite: 1530 pass, 7 skip, 0 fail.
  • Full repository build and typecheck pass.
  • Focused action/codec/loop/policy/transport/strict-adapter tests pass.
  • No Desktop, Computer Use executor, or provider credential files are modified.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

@Astro-Han#920 is clean and all CI checks pass. It is deliberately observation-only by default: real gpt-5.6-sol via the Azure Responses bridge completed a two-turn native computer screenshot continuation with no physical input action. The primary Accessibility-first product model path is isolated in fork stacked PR hqhq1025#9 and will be opened upstream after #920 merges.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Ready for review. This remains an observation-only native OpenAI surface; the primary product mutation path is the AX-first provider-neutral function tool continued in #925. cc @Astro-Han

@hqhq1025
hqhq1025force-pushed the codex/cu-openai-observation-loop branch from 14c0387 to 258dba8CompareJuly 13, 2026 20:27

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did not find a P0 or P1. The loop is still an explicit experimental API rather than the default product path, so these are non-blocking P2/P3 findings:

  • P2 — packages/runtime/src/openai-computer-codec.ts:49-57,150-214 and openai-responses-transport.ts:41-46: requests do not include the Responses API store body field, so desktop screenshots inherit the API's default retention. The transport test's store=false query parameter does not set the request-body option. Make the storage choice explicit, or use a continuation that does not depend on a stored response.

  • P2 — packages/runtime/src/openai-computer-loop.ts:84-101: top-level in_progress and per-call in_progress/incomplete states are accepted as actionable. An empty in_progress response is returned as completed, while an incomplete call's actions are executed. Only terminal completed responses and calls should advance the loop.

  • P2 — packages/runtime/src/openai-computer-loop.ts:24-48,157-164: once a batch starts, the result type cannot represent partial delivery or an unknown outcome. If action two throws after action one succeeded, the caller receives only the raw exception and can retry the already-delivered action.

  • P2 — packages/runtime/src/openai-computer-loop.ts:157-176: the final allowed turn still executes its actions and captures a screenshot, then throws max_turns_exceeded without sending that screenshot or reporting the delivered actions. Check the continuation budget before dispatch, or return the delivery state.

  • P2 — packages/runtime/src/openai-computer-codec.ts:73-76 and openai-computer-loop.ts:74-78: maxTurns limits responses, not actions, and it accepts Infinity. One response can contain an unbounded actions[]; even the default-allowed wait action consumes two seconds per item. Add finite turn and per-batch action limits.

  • P2 — packages/runtime/src/openai-computer-actions.ts:78-83,108-112: the default policy calls this path observation-only but allows move, which is converted to a raw host coordinate and sent to an executor with no isolated-target or display-identity proof. A normal host executor can therefore move the user's real pointer without allowAction.

  • P3 — packages/runtime/src/openai-computer-actions.ts:108-110 and openai-computer-loop.ts:157-164: a provider screenshot action is sent through the executor, then the screenshot provider is called unconditionally. That turns one requested capture into two capture paths while discarding the executor's result.

  • P3 — packages/runtime/src/openai-computer-loop.ts:74-81: when no signal is supplied, the loop creates an AbortController that never aborts. A stalled transport, executor, or capture can hang forever despite maxTurns; add a default deadline or make the required caller timeout explicit.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Superseded by #985, which consolidates #920 and #925 on current main and includes the outstanding review fixes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hqhq1025@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(cu): add fenced OpenAI computer observation loop by hqhq1025 · Pull Request #920 · apache/maka · GitHub
Skip to content

feat(cu): add fenced OpenAI computer observation loop - #920

Closed
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop
Closed

feat(cu): add fenced OpenAI computer observation loop#920
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

Adds a provider-native OpenAI Responses computer-call codec, bounded transport, and pure loop as an observation-only experimental surface.

This is not the primary Maka Computer path. The primary product path remains the provider-neutral maka_computer function tool, where the model observes an AX tree and explicitly uses semantic element actions. The native OpenAI loop does not implicitly convert coordinates into Accessibility elements.

Safety boundary

  • default native actions: screenshot, wait, and visual-only move;
  • click, type, scroll, drag, and keypress are rejected before execution unless a future caller supplies an explicit policy backed by an isolated executor;
  • the whole action batch is validated before its first side effect;
  • pending safety checks require explicit acknowledgement;
  • parallel computer calls fail closed;
  • failed/incomplete Responses are not treated as completion;
  • continuation uses the exact response and call IDs with a screenshot output.

Protocol hardening

  • strict GA actions[] and preview action dialects remain separate;
  • stable safety instructions stay outside user input;
  • parallel_tool_calls is disabled;
  • Responses bodies are capped at 16 MiB;
  • HTTP error details are bounded and redacted;
  • malformed success JSON does not echo response content;
  • OpenAI strict-object adapter emits all properties required+nullable, rejects unknown/accessor keys, and projects known fields per action without weakening the core parser.

Real evidence

Using the local Azure Responses bridge and gpt-5.6-sol, the GA native computer tool returned only screenshot under the default policy. The new transport/codec/loop completed the screenshot continuation in two turns and executed no physical input action.

Verification

  • Runtime full suite: 1530 pass, 7 skip, 0 fail.
  • Full repository build and typecheck pass.
  • Focused action/codec/loop/policy/transport/strict-adapter tests pass.
  • No Desktop, Computer Use executor, or provider credential files are modified.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

@Astro-Han#920 is clean and all CI checks pass. It is deliberately observation-only by default: real gpt-5.6-sol via the Azure Responses bridge completed a two-turn native computer screenshot continuation with no physical input action. The primary Accessibility-first product model path is isolated in fork stacked PR hqhq1025#9 and will be opened upstream after #920 merges.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Ready for review. This remains an observation-only native OpenAI surface; the primary product mutation path is the AX-first provider-neutral function tool continued in #925. cc @Astro-Han

@hqhq1025
hqhq1025force-pushed the codex/cu-openai-observation-loop branch from 14c0387 to 258dba8CompareJuly 13, 2026 20:27

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did not find a P0 or P1. The loop is still an explicit experimental API rather than the default product path, so these are non-blocking P2/P3 findings:

  • P2 — packages/runtime/src/openai-computer-codec.ts:49-57,150-214 and openai-responses-transport.ts:41-46: requests do not include the Responses API store body field, so desktop screenshots inherit the API's default retention. The transport test's store=false query parameter does not set the request-body option. Make the storage choice explicit, or use a continuation that does not depend on a stored response.

  • P2 — packages/runtime/src/openai-computer-loop.ts:84-101: top-level in_progress and per-call in_progress/incomplete states are accepted as actionable. An empty in_progress response is returned as completed, while an incomplete call's actions are executed. Only terminal completed responses and calls should advance the loop.

  • P2 — packages/runtime/src/openai-computer-loop.ts:24-48,157-164: once a batch starts, the result type cannot represent partial delivery or an unknown outcome. If action two throws after action one succeeded, the caller receives only the raw exception and can retry the already-delivered action.

  • P2 — packages/runtime/src/openai-computer-loop.ts:157-176: the final allowed turn still executes its actions and captures a screenshot, then throws max_turns_exceeded without sending that screenshot or reporting the delivered actions. Check the continuation budget before dispatch, or return the delivery state.

  • P2 — packages/runtime/src/openai-computer-codec.ts:73-76 and openai-computer-loop.ts:74-78: maxTurns limits responses, not actions, and it accepts Infinity. One response can contain an unbounded actions[]; even the default-allowed wait action consumes two seconds per item. Add finite turn and per-batch action limits.

  • P2 — packages/runtime/src/openai-computer-actions.ts:78-83,108-112: the default policy calls this path observation-only but allows move, which is converted to a raw host coordinate and sent to an executor with no isolated-target or display-identity proof. A normal host executor can therefore move the user's real pointer without allowAction.

  • P3 — packages/runtime/src/openai-computer-actions.ts:108-110 and openai-computer-loop.ts:157-164: a provider screenshot action is sent through the executor, then the screenshot provider is called unconditionally. That turns one requested capture into two capture paths while discarding the executor's result.

  • P3 — packages/runtime/src/openai-computer-loop.ts:74-81: when no signal is supplied, the loop creates an AbortController that never aborts. A stalled transport, executor, or capture can hang forever despite maxTurns; add a default deadline or make the required caller timeout explicit.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Superseded by #985, which consolidates #920 and #925 on current main and includes the outstanding review fixes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hqhq1025@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(cu): add fenced OpenAI computer observation loop by hqhq1025 · Pull Request #920 · apache/maka · GitHub
Skip to content

feat(cu): add fenced OpenAI computer observation loop - #920

Closed
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop
Closed

feat(cu): add fenced OpenAI computer observation loop#920
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

Adds a provider-native OpenAI Responses computer-call codec, bounded transport, and pure loop as an observation-only experimental surface.

This is not the primary Maka Computer path. The primary product path remains the provider-neutral maka_computer function tool, where the model observes an AX tree and explicitly uses semantic element actions. The native OpenAI loop does not implicitly convert coordinates into Accessibility elements.

Safety boundary

  • default native actions: screenshot, wait, and visual-only move;
  • click, type, scroll, drag, and keypress are rejected before execution unless a future caller supplies an explicit policy backed by an isolated executor;
  • the whole action batch is validated before its first side effect;
  • pending safety checks require explicit acknowledgement;
  • parallel computer calls fail closed;
  • failed/incomplete Responses are not treated as completion;
  • continuation uses the exact response and call IDs with a screenshot output.

Protocol hardening

  • strict GA actions[] and preview action dialects remain separate;
  • stable safety instructions stay outside user input;
  • parallel_tool_calls is disabled;
  • Responses bodies are capped at 16 MiB;
  • HTTP error details are bounded and redacted;
  • malformed success JSON does not echo response content;
  • OpenAI strict-object adapter emits all properties required+nullable, rejects unknown/accessor keys, and projects known fields per action without weakening the core parser.

Real evidence

Using the local Azure Responses bridge and gpt-5.6-sol, the GA native computer tool returned only screenshot under the default policy. The new transport/codec/loop completed the screenshot continuation in two turns and executed no physical input action.

Verification

  • Runtime full suite: 1530 pass, 7 skip, 0 fail.
  • Full repository build and typecheck pass.
  • Focused action/codec/loop/policy/transport/strict-adapter tests pass.
  • No Desktop, Computer Use executor, or provider credential files are modified.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

@Astro-Han#920 is clean and all CI checks pass. It is deliberately observation-only by default: real gpt-5.6-sol via the Azure Responses bridge completed a two-turn native computer screenshot continuation with no physical input action. The primary Accessibility-first product model path is isolated in fork stacked PR hqhq1025#9 and will be opened upstream after #920 merges.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Ready for review. This remains an observation-only native OpenAI surface; the primary product mutation path is the AX-first provider-neutral function tool continued in #925. cc @Astro-Han

@hqhq1025
hqhq1025force-pushed the codex/cu-openai-observation-loop branch from 14c0387 to 258dba8CompareJuly 13, 2026 20:27

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did not find a P0 or P1. The loop is still an explicit experimental API rather than the default product path, so these are non-blocking P2/P3 findings:

  • P2 — packages/runtime/src/openai-computer-codec.ts:49-57,150-214 and openai-responses-transport.ts:41-46: requests do not include the Responses API store body field, so desktop screenshots inherit the API's default retention. The transport test's store=false query parameter does not set the request-body option. Make the storage choice explicit, or use a continuation that does not depend on a stored response.

  • P2 — packages/runtime/src/openai-computer-loop.ts:84-101: top-level in_progress and per-call in_progress/incomplete states are accepted as actionable. An empty in_progress response is returned as completed, while an incomplete call's actions are executed. Only terminal completed responses and calls should advance the loop.

  • P2 — packages/runtime/src/openai-computer-loop.ts:24-48,157-164: once a batch starts, the result type cannot represent partial delivery or an unknown outcome. If action two throws after action one succeeded, the caller receives only the raw exception and can retry the already-delivered action.

  • P2 — packages/runtime/src/openai-computer-loop.ts:157-176: the final allowed turn still executes its actions and captures a screenshot, then throws max_turns_exceeded without sending that screenshot or reporting the delivered actions. Check the continuation budget before dispatch, or return the delivery state.

  • P2 — packages/runtime/src/openai-computer-codec.ts:73-76 and openai-computer-loop.ts:74-78: maxTurns limits responses, not actions, and it accepts Infinity. One response can contain an unbounded actions[]; even the default-allowed wait action consumes two seconds per item. Add finite turn and per-batch action limits.

  • P2 — packages/runtime/src/openai-computer-actions.ts:78-83,108-112: the default policy calls this path observation-only but allows move, which is converted to a raw host coordinate and sent to an executor with no isolated-target or display-identity proof. A normal host executor can therefore move the user's real pointer without allowAction.

  • P3 — packages/runtime/src/openai-computer-actions.ts:108-110 and openai-computer-loop.ts:157-164: a provider screenshot action is sent through the executor, then the screenshot provider is called unconditionally. That turns one requested capture into two capture paths while discarding the executor's result.

  • P3 — packages/runtime/src/openai-computer-loop.ts:74-81: when no signal is supplied, the loop creates an AbortController that never aborts. A stalled transport, executor, or capture can hang forever despite maxTurns; add a default deadline or make the required caller timeout explicit.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Superseded by #985, which consolidates #920 and #925 on current main and includes the outstanding review fixes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hqhq1025@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(cu): add fenced OpenAI computer observation loop by hqhq1025 · Pull Request #920 · apache/maka · GitHub
Skip to content

feat(cu): add fenced OpenAI computer observation loop - #920

Closed
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop
Closed

feat(cu): add fenced OpenAI computer observation loop#920
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

Adds a provider-native OpenAI Responses computer-call codec, bounded transport, and pure loop as an observation-only experimental surface.

This is not the primary Maka Computer path. The primary product path remains the provider-neutral maka_computer function tool, where the model observes an AX tree and explicitly uses semantic element actions. The native OpenAI loop does not implicitly convert coordinates into Accessibility elements.

Safety boundary

  • default native actions: screenshot, wait, and visual-only move;
  • click, type, scroll, drag, and keypress are rejected before execution unless a future caller supplies an explicit policy backed by an isolated executor;
  • the whole action batch is validated before its first side effect;
  • pending safety checks require explicit acknowledgement;
  • parallel computer calls fail closed;
  • failed/incomplete Responses are not treated as completion;
  • continuation uses the exact response and call IDs with a screenshot output.

Protocol hardening

  • strict GA actions[] and preview action dialects remain separate;
  • stable safety instructions stay outside user input;
  • parallel_tool_calls is disabled;
  • Responses bodies are capped at 16 MiB;
  • HTTP error details are bounded and redacted;
  • malformed success JSON does not echo response content;
  • OpenAI strict-object adapter emits all properties required+nullable, rejects unknown/accessor keys, and projects known fields per action without weakening the core parser.

Real evidence

Using the local Azure Responses bridge and gpt-5.6-sol, the GA native computer tool returned only screenshot under the default policy. The new transport/codec/loop completed the screenshot continuation in two turns and executed no physical input action.

Verification

  • Runtime full suite: 1530 pass, 7 skip, 0 fail.
  • Full repository build and typecheck pass.
  • Focused action/codec/loop/policy/transport/strict-adapter tests pass.
  • No Desktop, Computer Use executor, or provider credential files are modified.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

@Astro-Han#920 is clean and all CI checks pass. It is deliberately observation-only by default: real gpt-5.6-sol via the Azure Responses bridge completed a two-turn native computer screenshot continuation with no physical input action. The primary Accessibility-first product model path is isolated in fork stacked PR hqhq1025#9 and will be opened upstream after #920 merges.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Ready for review. This remains an observation-only native OpenAI surface; the primary product mutation path is the AX-first provider-neutral function tool continued in #925. cc @Astro-Han

@hqhq1025
hqhq1025force-pushed the codex/cu-openai-observation-loop branch from 14c0387 to 258dba8CompareJuly 13, 2026 20:27

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did not find a P0 or P1. The loop is still an explicit experimental API rather than the default product path, so these are non-blocking P2/P3 findings:

  • P2 — packages/runtime/src/openai-computer-codec.ts:49-57,150-214 and openai-responses-transport.ts:41-46: requests do not include the Responses API store body field, so desktop screenshots inherit the API's default retention. The transport test's store=false query parameter does not set the request-body option. Make the storage choice explicit, or use a continuation that does not depend on a stored response.

  • P2 — packages/runtime/src/openai-computer-loop.ts:84-101: top-level in_progress and per-call in_progress/incomplete states are accepted as actionable. An empty in_progress response is returned as completed, while an incomplete call's actions are executed. Only terminal completed responses and calls should advance the loop.

  • P2 — packages/runtime/src/openai-computer-loop.ts:24-48,157-164: once a batch starts, the result type cannot represent partial delivery or an unknown outcome. If action two throws after action one succeeded, the caller receives only the raw exception and can retry the already-delivered action.

  • P2 — packages/runtime/src/openai-computer-loop.ts:157-176: the final allowed turn still executes its actions and captures a screenshot, then throws max_turns_exceeded without sending that screenshot or reporting the delivered actions. Check the continuation budget before dispatch, or return the delivery state.

  • P2 — packages/runtime/src/openai-computer-codec.ts:73-76 and openai-computer-loop.ts:74-78: maxTurns limits responses, not actions, and it accepts Infinity. One response can contain an unbounded actions[]; even the default-allowed wait action consumes two seconds per item. Add finite turn and per-batch action limits.

  • P2 — packages/runtime/src/openai-computer-actions.ts:78-83,108-112: the default policy calls this path observation-only but allows move, which is converted to a raw host coordinate and sent to an executor with no isolated-target or display-identity proof. A normal host executor can therefore move the user's real pointer without allowAction.

  • P3 — packages/runtime/src/openai-computer-actions.ts:108-110 and openai-computer-loop.ts:157-164: a provider screenshot action is sent through the executor, then the screenshot provider is called unconditionally. That turns one requested capture into two capture paths while discarding the executor's result.

  • P3 — packages/runtime/src/openai-computer-loop.ts:74-81: when no signal is supplied, the loop creates an AbortController that never aborts. A stalled transport, executor, or capture can hang forever despite maxTurns; add a default deadline or make the required caller timeout explicit.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Superseded by #985, which consolidates #920 and #925 on current main and includes the outstanding review fixes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hqhq1025@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(cu): add fenced OpenAI computer observation loop by hqhq1025 · Pull Request #920 · apache/maka · GitHub
Skip to content

feat(cu): add fenced OpenAI computer observation loop - #920

Closed
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop
Closed

feat(cu): add fenced OpenAI computer observation loop#920
hqhq1025 wants to merge 3 commits into
apache:mainfrom
hqhq1025:codex/cu-openai-observation-loop

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

Adds a provider-native OpenAI Responses computer-call codec, bounded transport, and pure loop as an observation-only experimental surface.

This is not the primary Maka Computer path. The primary product path remains the provider-neutral maka_computer function tool, where the model observes an AX tree and explicitly uses semantic element actions. The native OpenAI loop does not implicitly convert coordinates into Accessibility elements.

Safety boundary

  • default native actions: screenshot, wait, and visual-only move;
  • click, type, scroll, drag, and keypress are rejected before execution unless a future caller supplies an explicit policy backed by an isolated executor;
  • the whole action batch is validated before its first side effect;
  • pending safety checks require explicit acknowledgement;
  • parallel computer calls fail closed;
  • failed/incomplete Responses are not treated as completion;
  • continuation uses the exact response and call IDs with a screenshot output.

Protocol hardening

  • strict GA actions[] and preview action dialects remain separate;
  • stable safety instructions stay outside user input;
  • parallel_tool_calls is disabled;
  • Responses bodies are capped at 16 MiB;
  • HTTP error details are bounded and redacted;
  • malformed success JSON does not echo response content;
  • OpenAI strict-object adapter emits all properties required+nullable, rejects unknown/accessor keys, and projects known fields per action without weakening the core parser.

Real evidence

Using the local Azure Responses bridge and gpt-5.6-sol, the GA native computer tool returned only screenshot under the default policy. The new transport/codec/loop completed the screenshot continuation in two turns and executed no physical input action.

Verification

  • Runtime full suite: 1530 pass, 7 skip, 0 fail.
  • Full repository build and typecheck pass.
  • Focused action/codec/loop/policy/transport/strict-adapter tests pass.
  • No Desktop, Computer Use executor, or provider credential files are modified.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

@Astro-Han#920 is clean and all CI checks pass. It is deliberately observation-only by default: real gpt-5.6-sol via the Azure Responses bridge completed a two-turn native computer screenshot continuation with no physical input action. The primary Accessibility-first product model path is isolated in fork stacked PR hqhq1025#9 and will be opened upstream after #920 merges.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Ready for review. This remains an observation-only native OpenAI surface; the primary product mutation path is the AX-first provider-neutral function tool continued in #925. cc @Astro-Han

@hqhq1025
hqhq1025force-pushed the codex/cu-openai-observation-loop branch from 14c0387 to 258dba8CompareJuly 13, 2026 20:27

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did not find a P0 or P1. The loop is still an explicit experimental API rather than the default product path, so these are non-blocking P2/P3 findings:

  • P2 — packages/runtime/src/openai-computer-codec.ts:49-57,150-214 and openai-responses-transport.ts:41-46: requests do not include the Responses API store body field, so desktop screenshots inherit the API's default retention. The transport test's store=false query parameter does not set the request-body option. Make the storage choice explicit, or use a continuation that does not depend on a stored response.

  • P2 — packages/runtime/src/openai-computer-loop.ts:84-101: top-level in_progress and per-call in_progress/incomplete states are accepted as actionable. An empty in_progress response is returned as completed, while an incomplete call's actions are executed. Only terminal completed responses and calls should advance the loop.

  • P2 — packages/runtime/src/openai-computer-loop.ts:24-48,157-164: once a batch starts, the result type cannot represent partial delivery or an unknown outcome. If action two throws after action one succeeded, the caller receives only the raw exception and can retry the already-delivered action.

  • P2 — packages/runtime/src/openai-computer-loop.ts:157-176: the final allowed turn still executes its actions and captures a screenshot, then throws max_turns_exceeded without sending that screenshot or reporting the delivered actions. Check the continuation budget before dispatch, or return the delivery state.

  • P2 — packages/runtime/src/openai-computer-codec.ts:73-76 and openai-computer-loop.ts:74-78: maxTurns limits responses, not actions, and it accepts Infinity. One response can contain an unbounded actions[]; even the default-allowed wait action consumes two seconds per item. Add finite turn and per-batch action limits.

  • P2 — packages/runtime/src/openai-computer-actions.ts:78-83,108-112: the default policy calls this path observation-only but allows move, which is converted to a raw host coordinate and sent to an executor with no isolated-target or display-identity proof. A normal host executor can therefore move the user's real pointer without allowAction.

  • P3 — packages/runtime/src/openai-computer-actions.ts:108-110 and openai-computer-loop.ts:157-164: a provider screenshot action is sent through the executor, then the screenshot provider is called unconditionally. That turns one requested capture into two capture paths while discarding the executor's result.

  • P3 — packages/runtime/src/openai-computer-loop.ts:74-81: when no signal is supplied, the loop creates an AbortController that never aborts. A stalled transport, executor, or capture can hang forever despite maxTurns; add a default deadline or make the required caller timeout explicit.

@hqhq1025

Copy link
Copy Markdown
ContributorAuthor

Superseded by #985, which consolidates #920 and #925 on current main and includes the outstanding review fixes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hqhq1025@Astro-Han