Uh oh!
There was an error while loading. Please reload this page.
fix(cu): revalidate native keyboard targets - #932
Closed
hqhq1025 wants to merge 1 commit into
Closed
Conversation
Astro-Han
requested changes
Jul 14, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Two P1 target-binding problems remain in the native text path:
- P1: The editable target is selected from a snapshot before the coordinate click. If layout changes before dispatch, the click can land elsewhere while keyboard ownership is still assigned to the pre-click field; subsequent text may be written to a field the user did not click.
- P1:
role/label/valueis not a stable AX identity. Re-resolution and post-write verification can bind to another matching field and cannot prove that the readback belongs to the node passed toset_value. - P2: A successful write does not update the saved value, so retrying the same
typeoperation is no longer idempotent.
Please establish ownership from the actual clicked/focused AX node and use a stable node identity through resolution, write, and readback. If the protocol cannot provide that identity, fail closed when the node changes.
hqhq1025
commented
Jul 14, 2026
ContributorAuthor
Superseded by #984, which consolidates #930-#933 into one target-identity boundary and addresses the requested changes. Stable AX token delivery is tracked in trycua/cua#2210. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_value, so layout reflow cannot redirect text to another fieldElectron text identity is intentionally unchanged; stable DOM-local identity needs a separate protocol extension.
Verification
@maka/core,@maka/storage, and@maka/runtimeseriallynpm --workspace @maka/computer-use test(129/129 passing)git diff --check