[NETBEANS-378,NETBEANS-2455] HiDPI splash screen with product version by eirikbakke · Pull Request #1246 · apache/netbeans

eirikbakke · 2019-05-11T22:02:26Z

These commits (1) add the ability for the NetBeans splash screen to be automatically imprinted with the NetBeans product version and build number (2) makes the splash screen and "About" box look good on HiDPI displays, and (3) adds new simplified splash screen graphics.

(We could also ask David Schulz if he'd like to make an updated version of the old splash screen, making space for the version string. In that case the graphics uploaded here just serves as an example.)

This resolves https://issues.apache.org/jira/browse/NETBEANS-2455 and https://issues.apache.org/jira/browse/NETBEANS-378 . See attached screenshot.

Old splash screen showing HiDPI scaling artifacts on Windows 10 at 150% DPI scaling:

Tested on Windows 10; it would be great if someone else can test it on MacOS (with a Retina screen) and Linux as well.

AlexFalappa · 2019-05-15T12:51:01Z

I see you used a very recent JDK (12.0.1) but are these modifications supported on older JDKs?
Does this also show up nicely on JDK 8 (Oracle and AdoptOpen implementations)?

eirikbakke · 2019-05-15T13:13:57Z

On Windows, HiDPI screens are supported from JDK 9 and upwards; on MacOS it might have been introduced earlier (not sure).

On Java versions that do not support HiDPI screens, the splash screen should show up in low resolution, like before. I have confirmed this on JDK8 on Windows (I don't have a Mac to test).

The way this works is that the splash screen PNG is now double resolution, but resized to 50% (to SPLASH_WIDTH*SPLASH_HEIGHT logical pixels) via a transform on the paint method's Graphics2D object. JDK versions that support HiDPI will in turn apply its own transform to scale the image back up to a higher device pixel resolution.

AlexFalappa · 2019-05-20T13:17:24Z

@eirikbakke thanks for the details.

You answered to my concerns, that is your implementation also degrades gracefully on older JDKs.

…us line, in preparation for adding a separate optional version text box. No behavior should change as a result of this commit (refactoring only).

… splash screen. Also added a horizontal alignment setting for the splash screen text box settings.

… (The splash screen image was already added in high resolution in a previous commit.)

eirikbakke · 2019-06-07T15:54:33Z

The changes to ImageUtilities are now already merged as part of another PR ( #1273 ). Rebased this PR to remove merge conflicts.

eirikbakke · 2019-06-09T21:02:14Z

Adding API change label since this PR adds new properties that can be added to the branding file to set the location of the version string on the splash screen.

neilcsmith-net · 2019-06-10T15:50:56Z

Added NB11.1 label. Would love to get this merged this week so I don't have to faff around with splash screens during the release process! 😄

eirikbakke · 2019-06-10T17:32:29Z

Added a comment on https://issues.apache.org/jira/browse/NETBEANS-2455 to see if there's consensus on this approach.

GeertjanWielenga · 2019-06-10T17:48:24Z

Just merge it unless there’d be any reason to disagree with this.

eirikbakke · 2019-06-12T22:59:48Z

Will merge Friday, before feature freeze... just wanted to give David Schulz a chance to provide updated splash screen artwork, so I don't "overwrite" his work.

geertjanw · 2019-06-13T19:23:18Z

Awesome, let's get it in for 11.1. :-)

geertjanw · 2019-06-14T07:07:10Z

@eirikbakke, I leave this to you to merge, OK?

eirikbakke · 2019-06-14T12:14:30Z

Done. If we get new splash screen artwork but it's after the feature freeze it can just go in the following version.

neilcsmith-net · 2019-06-14T14:12:06Z

@eirikbakke great! 👍 Personally, I don't think there's a problem with merging new artwork after feature freeze if people want it. At the same time, I prefer your artwork anyway - it's cleaner and more legible.

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

eirikbakke · 2019-06-15T15:26:06Z

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

That would be a simple change to make. Feel free to open a JIRA issue for it. It should be done after the PR at #1278 gets merged, because the latter can make all the caching logic in ScaledBitmapIcon.java go into a superclass (I will make said simplification as part of that other PR).

eirikbakke · 2019-05-11T22:02:26Z

These commits (1) add the ability for the NetBeans splash screen to be automatically imprinted with the NetBeans product version and build number (2) makes the splash screen and "About" box look good on HiDPI displays, and (3) adds new simplified splash screen graphics.

(We could also ask David Schulz if he'd like to make an updated version of the old splash screen, making space for the version string. In that case the graphics uploaded here just serves as an example.)

This resolves https://issues.apache.org/jira/browse/NETBEANS-2455 and https://issues.apache.org/jira/browse/NETBEANS-378 . See attached screenshot.

Old splash screen showing HiDPI scaling artifacts on Windows 10 at 150% DPI scaling:

Tested on Windows 10; it would be great if someone else can test it on MacOS (with a Retina screen) and Linux as well.

AlexFalappa · 2019-05-15T12:51:01Z

I see you used a very recent JDK (12.0.1) but are these modifications supported on older JDKs?
Does this also show up nicely on JDK 8 (Oracle and AdoptOpen implementations)?

eirikbakke · 2019-05-15T13:13:57Z

On Windows, HiDPI screens are supported from JDK 9 and upwards; on MacOS it might have been introduced earlier (not sure).

On Java versions that do not support HiDPI screens, the splash screen should show up in low resolution, like before. I have confirmed this on JDK8 on Windows (I don't have a Mac to test).

The way this works is that the splash screen PNG is now double resolution, but resized to 50% (to SPLASH_WIDTH*SPLASH_HEIGHT logical pixels) via a transform on the paint method's Graphics2D object. JDK versions that support HiDPI will in turn apply its own transform to scale the image back up to a higher device pixel resolution.

AlexFalappa · 2019-05-20T13:17:24Z

@eirikbakke thanks for the details.

You answered to my concerns, that is your implementation also degrades gracefully on older JDKs.

…us line, in preparation for adding a separate optional version text box. No behavior should change as a result of this commit (refactoring only).

… splash screen. Also added a horizontal alignment setting for the splash screen text box settings.

… (The splash screen image was already added in high resolution in a previous commit.)

eirikbakke · 2019-06-07T15:54:33Z

The changes to ImageUtilities are now already merged as part of another PR ( #1273 ). Rebased this PR to remove merge conflicts.

eirikbakke · 2019-06-09T21:02:14Z

Adding API change label since this PR adds new properties that can be added to the branding file to set the location of the version string on the splash screen.

neilcsmith-net · 2019-06-10T15:50:56Z

Added NB11.1 label. Would love to get this merged this week so I don't have to faff around with splash screens during the release process! 😄

eirikbakke · 2019-06-10T17:32:29Z

Added a comment on https://issues.apache.org/jira/browse/NETBEANS-2455 to see if there's consensus on this approach.

GeertjanWielenga · 2019-06-10T17:48:24Z

Just merge it unless there’d be any reason to disagree with this.

eirikbakke · 2019-06-12T22:59:48Z

Will merge Friday, before feature freeze... just wanted to give David Schulz a chance to provide updated splash screen artwork, so I don't "overwrite" his work.

geertjanw · 2019-06-13T19:23:18Z

Awesome, let's get it in for 11.1. :-)

geertjanw · 2019-06-14T07:07:10Z

@eirikbakke, I leave this to you to merge, OK?

eirikbakke · 2019-06-14T12:14:30Z

Done. If we get new splash screen artwork but it's after the feature freeze it can just go in the following version.

neilcsmith-net · 2019-06-14T14:12:06Z

@eirikbakke great! 👍 Personally, I don't think there's a problem with merging new artwork after feature freeze if people want it. At the same time, I prefer your artwork anyway - it's cleaner and more legible.

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

eirikbakke · 2019-06-15T15:26:06Z

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

That would be a simple change to make. Feel free to open a JIRA issue for it. It should be done after the PR at #1278 gets merged, because the latter can make all the caching logic in ScaledBitmapIcon.java go into a superclass (I will make said simplification as part of that other PR).

eirikbakke · 2019-05-11T22:02:26Z

These commits (1) add the ability for the NetBeans splash screen to be automatically imprinted with the NetBeans product version and build number (2) makes the splash screen and "About" box look good on HiDPI displays, and (3) adds new simplified splash screen graphics.

(We could also ask David Schulz if he'd like to make an updated version of the old splash screen, making space for the version string. In that case the graphics uploaded here just serves as an example.)

This resolves https://issues.apache.org/jira/browse/NETBEANS-2455 and https://issues.apache.org/jira/browse/NETBEANS-378 . See attached screenshot.

Old splash screen showing HiDPI scaling artifacts on Windows 10 at 150% DPI scaling:

Tested on Windows 10; it would be great if someone else can test it on MacOS (with a Retina screen) and Linux as well.

AlexFalappa · 2019-05-15T12:51:01Z

I see you used a very recent JDK (12.0.1) but are these modifications supported on older JDKs?
Does this also show up nicely on JDK 8 (Oracle and AdoptOpen implementations)?

eirikbakke · 2019-05-15T13:13:57Z

On Windows, HiDPI screens are supported from JDK 9 and upwards; on MacOS it might have been introduced earlier (not sure).

On Java versions that do not support HiDPI screens, the splash screen should show up in low resolution, like before. I have confirmed this on JDK8 on Windows (I don't have a Mac to test).

The way this works is that the splash screen PNG is now double resolution, but resized to 50% (to SPLASH_WIDTH*SPLASH_HEIGHT logical pixels) via a transform on the paint method's Graphics2D object. JDK versions that support HiDPI will in turn apply its own transform to scale the image back up to a higher device pixel resolution.

AlexFalappa · 2019-05-20T13:17:24Z

@eirikbakke thanks for the details.

You answered to my concerns, that is your implementation also degrades gracefully on older JDKs.

…us line, in preparation for adding a separate optional version text box. No behavior should change as a result of this commit (refactoring only).

… splash screen. Also added a horizontal alignment setting for the splash screen text box settings.

… (The splash screen image was already added in high resolution in a previous commit.)

eirikbakke · 2019-06-07T15:54:33Z

The changes to ImageUtilities are now already merged as part of another PR ( #1273 ). Rebased this PR to remove merge conflicts.

eirikbakke · 2019-06-09T21:02:14Z

Adding API change label since this PR adds new properties that can be added to the branding file to set the location of the version string on the splash screen.

neilcsmith-net · 2019-06-10T15:50:56Z

Added NB11.1 label. Would love to get this merged this week so I don't have to faff around with splash screens during the release process! 😄

eirikbakke · 2019-06-10T17:32:29Z

Added a comment on https://issues.apache.org/jira/browse/NETBEANS-2455 to see if there's consensus on this approach.

GeertjanWielenga · 2019-06-10T17:48:24Z

Just merge it unless there’d be any reason to disagree with this.

eirikbakke · 2019-06-12T22:59:48Z

Will merge Friday, before feature freeze... just wanted to give David Schulz a chance to provide updated splash screen artwork, so I don't "overwrite" his work.

geertjanw · 2019-06-13T19:23:18Z

Awesome, let's get it in for 11.1. :-)

geertjanw · 2019-06-14T07:07:10Z

@eirikbakke, I leave this to you to merge, OK?

eirikbakke · 2019-06-14T12:14:30Z

Done. If we get new splash screen artwork but it's after the feature freeze it can just go in the following version.

neilcsmith-net · 2019-06-14T14:12:06Z

@eirikbakke great! 👍 Personally, I don't think there's a problem with merging new artwork after feature freeze if people want it. At the same time, I prefer your artwork anyway - it's cleaner and more legible.

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

eirikbakke · 2019-06-15T15:26:06Z

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

That would be a simple change to make. Feel free to open a JIRA issue for it. It should be done after the PR at #1278 gets merged, because the latter can make all the caching logic in ScaledBitmapIcon.java go into a superclass (I will make said simplification as part of that other PR).

eirikbakke · 2019-05-11T22:02:26Z

These commits (1) add the ability for the NetBeans splash screen to be automatically imprinted with the NetBeans product version and build number (2) makes the splash screen and "About" box look good on HiDPI displays, and (3) adds new simplified splash screen graphics.

(We could also ask David Schulz if he'd like to make an updated version of the old splash screen, making space for the version string. In that case the graphics uploaded here just serves as an example.)

This resolves https://issues.apache.org/jira/browse/NETBEANS-2455 and https://issues.apache.org/jira/browse/NETBEANS-378 . See attached screenshot.

Old splash screen showing HiDPI scaling artifacts on Windows 10 at 150% DPI scaling:

Tested on Windows 10; it would be great if someone else can test it on MacOS (with a Retina screen) and Linux as well.

AlexFalappa · 2019-05-15T12:51:01Z

I see you used a very recent JDK (12.0.1) but are these modifications supported on older JDKs?
Does this also show up nicely on JDK 8 (Oracle and AdoptOpen implementations)?

eirikbakke · 2019-05-15T13:13:57Z

On Windows, HiDPI screens are supported from JDK 9 and upwards; on MacOS it might have been introduced earlier (not sure).

On Java versions that do not support HiDPI screens, the splash screen should show up in low resolution, like before. I have confirmed this on JDK8 on Windows (I don't have a Mac to test).

The way this works is that the splash screen PNG is now double resolution, but resized to 50% (to SPLASH_WIDTH*SPLASH_HEIGHT logical pixels) via a transform on the paint method's Graphics2D object. JDK versions that support HiDPI will in turn apply its own transform to scale the image back up to a higher device pixel resolution.

AlexFalappa · 2019-05-20T13:17:24Z

@eirikbakke thanks for the details.

You answered to my concerns, that is your implementation also degrades gracefully on older JDKs.

…us line, in preparation for adding a separate optional version text box. No behavior should change as a result of this commit (refactoring only).

… splash screen. Also added a horizontal alignment setting for the splash screen text box settings.

… (The splash screen image was already added in high resolution in a previous commit.)

eirikbakke · 2019-06-07T15:54:33Z

The changes to ImageUtilities are now already merged as part of another PR ( #1273 ). Rebased this PR to remove merge conflicts.

eirikbakke · 2019-06-09T21:02:14Z

Adding API change label since this PR adds new properties that can be added to the branding file to set the location of the version string on the splash screen.

neilcsmith-net · 2019-06-10T15:50:56Z

Added NB11.1 label. Would love to get this merged this week so I don't have to faff around with splash screens during the release process! 😄

eirikbakke · 2019-06-10T17:32:29Z

Added a comment on https://issues.apache.org/jira/browse/NETBEANS-2455 to see if there's consensus on this approach.

GeertjanWielenga · 2019-06-10T17:48:24Z

Just merge it unless there’d be any reason to disagree with this.

eirikbakke · 2019-06-12T22:59:48Z

Will merge Friday, before feature freeze... just wanted to give David Schulz a chance to provide updated splash screen artwork, so I don't "overwrite" his work.

geertjanw · 2019-06-13T19:23:18Z

Awesome, let's get it in for 11.1. :-)

geertjanw · 2019-06-14T07:07:10Z

@eirikbakke, I leave this to you to merge, OK?

eirikbakke · 2019-06-14T12:14:30Z

Done. If we get new splash screen artwork but it's after the feature freeze it can just go in the following version.

neilcsmith-net · 2019-06-14T14:12:06Z

@eirikbakke great! 👍 Personally, I don't think there's a problem with merging new artwork after feature freeze if people want it. At the same time, I prefer your artwork anyway - it's cleaner and more legible.

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

eirikbakke · 2019-06-15T15:26:06Z

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

That would be a simple change to make. Feel free to open a JIRA issue for it. It should be done after the PR at #1278 gets merged, because the latter can make all the caching logic in ScaledBitmapIcon.java go into a superclass (I will make said simplification as part of that other PR).

eirikbakke · 2019-05-11T22:02:26Z

These commits (1) add the ability for the NetBeans splash screen to be automatically imprinted with the NetBeans product version and build number (2) makes the splash screen and "About" box look good on HiDPI displays, and (3) adds new simplified splash screen graphics.

(We could also ask David Schulz if he'd like to make an updated version of the old splash screen, making space for the version string. In that case the graphics uploaded here just serves as an example.)

This resolves https://issues.apache.org/jira/browse/NETBEANS-2455 and https://issues.apache.org/jira/browse/NETBEANS-378 . See attached screenshot.

Old splash screen showing HiDPI scaling artifacts on Windows 10 at 150% DPI scaling:

Tested on Windows 10; it would be great if someone else can test it on MacOS (with a Retina screen) and Linux as well.

AlexFalappa · 2019-05-15T12:51:01Z

I see you used a very recent JDK (12.0.1) but are these modifications supported on older JDKs?
Does this also show up nicely on JDK 8 (Oracle and AdoptOpen implementations)?

eirikbakke · 2019-05-15T13:13:57Z

On Windows, HiDPI screens are supported from JDK 9 and upwards; on MacOS it might have been introduced earlier (not sure).

On Java versions that do not support HiDPI screens, the splash screen should show up in low resolution, like before. I have confirmed this on JDK8 on Windows (I don't have a Mac to test).

The way this works is that the splash screen PNG is now double resolution, but resized to 50% (to SPLASH_WIDTH*SPLASH_HEIGHT logical pixels) via a transform on the paint method's Graphics2D object. JDK versions that support HiDPI will in turn apply its own transform to scale the image back up to a higher device pixel resolution.

AlexFalappa · 2019-05-20T13:17:24Z

@eirikbakke thanks for the details.

You answered to my concerns, that is your implementation also degrades gracefully on older JDKs.

…us line, in preparation for adding a separate optional version text box. No behavior should change as a result of this commit (refactoring only).

… splash screen. Also added a horizontal alignment setting for the splash screen text box settings.

… (The splash screen image was already added in high resolution in a previous commit.)

eirikbakke · 2019-06-07T15:54:33Z

The changes to ImageUtilities are now already merged as part of another PR ( #1273 ). Rebased this PR to remove merge conflicts.

eirikbakke · 2019-06-09T21:02:14Z

Adding API change label since this PR adds new properties that can be added to the branding file to set the location of the version string on the splash screen.

neilcsmith-net · 2019-06-10T15:50:56Z

Added NB11.1 label. Would love to get this merged this week so I don't have to faff around with splash screens during the release process! 😄

eirikbakke · 2019-06-10T17:32:29Z

Added a comment on https://issues.apache.org/jira/browse/NETBEANS-2455 to see if there's consensus on this approach.

GeertjanWielenga · 2019-06-10T17:48:24Z

Just merge it unless there’d be any reason to disagree with this.

eirikbakke · 2019-06-12T22:59:48Z

Will merge Friday, before feature freeze... just wanted to give David Schulz a chance to provide updated splash screen artwork, so I don't "overwrite" his work.

geertjanw · 2019-06-13T19:23:18Z

Awesome, let's get it in for 11.1. :-)

geertjanw · 2019-06-14T07:07:10Z

@eirikbakke, I leave this to you to merge, OK?

eirikbakke · 2019-06-14T12:14:30Z

Done. If we get new splash screen artwork but it's after the feature freeze it can just go in the following version.

neilcsmith-net · 2019-06-14T14:12:06Z

@eirikbakke great! 👍 Personally, I don't think there's a problem with merging new artwork after feature freeze if people want it. At the same time, I prefer your artwork anyway - it's cleaner and more legible.

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

eirikbakke · 2019-06-15T15:26:06Z

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

That would be a simple change to make. Feel free to open a JIRA issue for it. It should be done after the PR at #1278 gets merged, because the latter can make all the caching logic in ScaledBitmapIcon.java go into a superclass (I will make said simplification as part of that other PR).

eirikbakke · 2019-05-11T22:02:26Z

These commits (1) add the ability for the NetBeans splash screen to be automatically imprinted with the NetBeans product version and build number (2) makes the splash screen and "About" box look good on HiDPI displays, and (3) adds new simplified splash screen graphics.

(We could also ask David Schulz if he'd like to make an updated version of the old splash screen, making space for the version string. In that case the graphics uploaded here just serves as an example.)

This resolves https://issues.apache.org/jira/browse/NETBEANS-2455 and https://issues.apache.org/jira/browse/NETBEANS-378 . See attached screenshot.

Old splash screen showing HiDPI scaling artifacts on Windows 10 at 150% DPI scaling:

Tested on Windows 10; it would be great if someone else can test it on MacOS (with a Retina screen) and Linux as well.

AlexFalappa · 2019-05-15T12:51:01Z

I see you used a very recent JDK (12.0.1) but are these modifications supported on older JDKs?
Does this also show up nicely on JDK 8 (Oracle and AdoptOpen implementations)?

eirikbakke · 2019-05-15T13:13:57Z

On Windows, HiDPI screens are supported from JDK 9 and upwards; on MacOS it might have been introduced earlier (not sure).

On Java versions that do not support HiDPI screens, the splash screen should show up in low resolution, like before. I have confirmed this on JDK8 on Windows (I don't have a Mac to test).

The way this works is that the splash screen PNG is now double resolution, but resized to 50% (to SPLASH_WIDTH*SPLASH_HEIGHT logical pixels) via a transform on the paint method's Graphics2D object. JDK versions that support HiDPI will in turn apply its own transform to scale the image back up to a higher device pixel resolution.

AlexFalappa · 2019-05-20T13:17:24Z

@eirikbakke thanks for the details.

You answered to my concerns, that is your implementation also degrades gracefully on older JDKs.

…us line, in preparation for adding a separate optional version text box. No behavior should change as a result of this commit (refactoring only).

… splash screen. Also added a horizontal alignment setting for the splash screen text box settings.

… (The splash screen image was already added in high resolution in a previous commit.)

eirikbakke · 2019-06-07T15:54:33Z

The changes to ImageUtilities are now already merged as part of another PR ( #1273 ). Rebased this PR to remove merge conflicts.

eirikbakke · 2019-06-09T21:02:14Z

Adding API change label since this PR adds new properties that can be added to the branding file to set the location of the version string on the splash screen.

neilcsmith-net · 2019-06-10T15:50:56Z

Added NB11.1 label. Would love to get this merged this week so I don't have to faff around with splash screens during the release process! 😄

eirikbakke · 2019-06-10T17:32:29Z

Added a comment on https://issues.apache.org/jira/browse/NETBEANS-2455 to see if there's consensus on this approach.

GeertjanWielenga · 2019-06-10T17:48:24Z

Just merge it unless there’d be any reason to disagree with this.

eirikbakke · 2019-06-12T22:59:48Z

Will merge Friday, before feature freeze... just wanted to give David Schulz a chance to provide updated splash screen artwork, so I don't "overwrite" his work.

geertjanw · 2019-06-13T19:23:18Z

Awesome, let's get it in for 11.1. :-)

geertjanw · 2019-06-14T07:07:10Z

@eirikbakke, I leave this to you to merge, OK?

eirikbakke · 2019-06-14T12:14:30Z

Done. If we get new splash screen artwork but it's after the feature freeze it can just go in the following version.

neilcsmith-net · 2019-06-14T14:12:06Z

@eirikbakke great! 👍 Personally, I don't think there's a problem with merging new artwork after feature freeze if people want it. At the same time, I prefer your artwork anyway - it's cleaner and more legible.

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

eirikbakke · 2019-06-15T15:26:06Z

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

That would be a simple change to make. Feel free to open a JIRA issue for it. It should be done after the PR at #1278 gets merged, because the latter can make all the caching logic in ScaledBitmapIcon.java go into a superclass (I will make said simplification as part of that other PR).

eirikbakke · 2019-05-11T22:02:26Z

These commits (1) add the ability for the NetBeans splash screen to be automatically imprinted with the NetBeans product version and build number (2) makes the splash screen and "About" box look good on HiDPI displays, and (3) adds new simplified splash screen graphics.

(We could also ask David Schulz if he'd like to make an updated version of the old splash screen, making space for the version string. In that case the graphics uploaded here just serves as an example.)

This resolves https://issues.apache.org/jira/browse/NETBEANS-2455 and https://issues.apache.org/jira/browse/NETBEANS-378 . See attached screenshot.

Old splash screen showing HiDPI scaling artifacts on Windows 10 at 150% DPI scaling:

Tested on Windows 10; it would be great if someone else can test it on MacOS (with a Retina screen) and Linux as well.

AlexFalappa · 2019-05-15T12:51:01Z

I see you used a very recent JDK (12.0.1) but are these modifications supported on older JDKs?
Does this also show up nicely on JDK 8 (Oracle and AdoptOpen implementations)?

eirikbakke · 2019-05-15T13:13:57Z

On Windows, HiDPI screens are supported from JDK 9 and upwards; on MacOS it might have been introduced earlier (not sure).

On Java versions that do not support HiDPI screens, the splash screen should show up in low resolution, like before. I have confirmed this on JDK8 on Windows (I don't have a Mac to test).

The way this works is that the splash screen PNG is now double resolution, but resized to 50% (to SPLASH_WIDTH*SPLASH_HEIGHT logical pixels) via a transform on the paint method's Graphics2D object. JDK versions that support HiDPI will in turn apply its own transform to scale the image back up to a higher device pixel resolution.

AlexFalappa · 2019-05-20T13:17:24Z

@eirikbakke thanks for the details.

You answered to my concerns, that is your implementation also degrades gracefully on older JDKs.

…us line, in preparation for adding a separate optional version text box. No behavior should change as a result of this commit (refactoring only).

… splash screen. Also added a horizontal alignment setting for the splash screen text box settings.

… (The splash screen image was already added in high resolution in a previous commit.)

eirikbakke · 2019-06-07T15:54:33Z

The changes to ImageUtilities are now already merged as part of another PR ( #1273 ). Rebased this PR to remove merge conflicts.

eirikbakke · 2019-06-09T21:02:14Z

Adding API change label since this PR adds new properties that can be added to the branding file to set the location of the version string on the splash screen.

neilcsmith-net · 2019-06-10T15:50:56Z

Added NB11.1 label. Would love to get this merged this week so I don't have to faff around with splash screens during the release process! 😄

eirikbakke · 2019-06-10T17:32:29Z

Added a comment on https://issues.apache.org/jira/browse/NETBEANS-2455 to see if there's consensus on this approach.

GeertjanWielenga · 2019-06-10T17:48:24Z

Just merge it unless there’d be any reason to disagree with this.

eirikbakke · 2019-06-12T22:59:48Z

Will merge Friday, before feature freeze... just wanted to give David Schulz a chance to provide updated splash screen artwork, so I don't "overwrite" his work.

geertjanw · 2019-06-13T19:23:18Z

Awesome, let's get it in for 11.1. :-)

geertjanw · 2019-06-14T07:07:10Z

@eirikbakke, I leave this to you to merge, OK?

eirikbakke · 2019-06-14T12:14:30Z

Done. If we get new splash screen artwork but it's after the feature freeze it can just go in the following version.

neilcsmith-net · 2019-06-14T14:12:06Z

@eirikbakke great! 👍 Personally, I don't think there's a problem with merging new artwork after feature freeze if people want it. At the same time, I prefer your artwork anyway - it's cleaner and more legible.

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

eirikbakke · 2019-06-15T15:26:06Z

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

That would be a simple change to make. Feel free to open a JIRA issue for it. It should be done after the PR at #1278 gets merged, because the latter can make all the caching logic in ScaledBitmapIcon.java go into a superclass (I will make said simplification as part of that other PR).

eirikbakke · 2019-05-11T22:02:26Z

These commits (1) add the ability for the NetBeans splash screen to be automatically imprinted with the NetBeans product version and build number (2) makes the splash screen and "About" box look good on HiDPI displays, and (3) adds new simplified splash screen graphics.

(We could also ask David Schulz if he'd like to make an updated version of the old splash screen, making space for the version string. In that case the graphics uploaded here just serves as an example.)

This resolves https://issues.apache.org/jira/browse/NETBEANS-2455 and https://issues.apache.org/jira/browse/NETBEANS-378 . See attached screenshot.

Old splash screen showing HiDPI scaling artifacts on Windows 10 at 150% DPI scaling:

Tested on Windows 10; it would be great if someone else can test it on MacOS (with a Retina screen) and Linux as well.

AlexFalappa · 2019-05-15T12:51:01Z

I see you used a very recent JDK (12.0.1) but are these modifications supported on older JDKs?
Does this also show up nicely on JDK 8 (Oracle and AdoptOpen implementations)?

eirikbakke · 2019-05-15T13:13:57Z

On Windows, HiDPI screens are supported from JDK 9 and upwards; on MacOS it might have been introduced earlier (not sure).

On Java versions that do not support HiDPI screens, the splash screen should show up in low resolution, like before. I have confirmed this on JDK8 on Windows (I don't have a Mac to test).

The way this works is that the splash screen PNG is now double resolution, but resized to 50% (to SPLASH_WIDTH*SPLASH_HEIGHT logical pixels) via a transform on the paint method's Graphics2D object. JDK versions that support HiDPI will in turn apply its own transform to scale the image back up to a higher device pixel resolution.

AlexFalappa · 2019-05-20T13:17:24Z

@eirikbakke thanks for the details.

You answered to my concerns, that is your implementation also degrades gracefully on older JDKs.

…us line, in preparation for adding a separate optional version text box. No behavior should change as a result of this commit (refactoring only).

… splash screen. Also added a horizontal alignment setting for the splash screen text box settings.

… (The splash screen image was already added in high resolution in a previous commit.)

eirikbakke · 2019-06-07T15:54:33Z

The changes to ImageUtilities are now already merged as part of another PR ( #1273 ). Rebased this PR to remove merge conflicts.

eirikbakke · 2019-06-09T21:02:14Z

Adding API change label since this PR adds new properties that can be added to the branding file to set the location of the version string on the splash screen.

neilcsmith-net · 2019-06-10T15:50:56Z

Added NB11.1 label. Would love to get this merged this week so I don't have to faff around with splash screens during the release process! 😄

eirikbakke · 2019-06-10T17:32:29Z

Added a comment on https://issues.apache.org/jira/browse/NETBEANS-2455 to see if there's consensus on this approach.

GeertjanWielenga · 2019-06-10T17:48:24Z

Just merge it unless there’d be any reason to disagree with this.

eirikbakke · 2019-06-12T22:59:48Z

Will merge Friday, before feature freeze... just wanted to give David Schulz a chance to provide updated splash screen artwork, so I don't "overwrite" his work.

geertjanw · 2019-06-13T19:23:18Z

Awesome, let's get it in for 11.1. :-)

geertjanw · 2019-06-14T07:07:10Z

@eirikbakke, I leave this to you to merge, OK?

eirikbakke · 2019-06-14T12:14:30Z

Done. If we get new splash screen artwork but it's after the feature freeze it can just go in the following version.

neilcsmith-net · 2019-06-14T14:12:06Z

@eirikbakke great! 👍 Personally, I don't think there's a problem with merging new artwork after feature freeze if people want it. At the same time, I prefer your artwork anyway - it's cleaner and more legible.

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

eirikbakke · 2019-06-15T15:26:06Z

One possible enhancement for this might be to also consider screen resolution in deciding splash size? I have a large 2560x1440 display, but with DPI scaling set to 1. Still be nice to have larger splash on such a setup.

That would be a simple change to make. Feel free to open a JIRA issue for it. It should be done after the PR at #1278 gets merged, because the latter can make all the caching logic in ScaledBitmapIcon.java go into a superclass (I will make said simplification as part of that other PR).

eirikbakke added 5 commits June 7, 2019 11:50

Factored out the parameter parsing logic for the splash screen's stat…
df92710
…us line, in preparation for adding a separate optional version text box. No behavior should change as a result of this commit (refactoring only).

Added the ability to have a version string automatically added to the…
beb76ae
… splash screen. Also added a horizontal alignment setting for the splash screen text box settings.

Add splash screen with dynamic version information added at runtime.
28de07e

Support proper HiDPI rendering of splash screen and About box images.…
894f854
… (The splash screen image was already added in high resolution in a previous commit.)

Some formatting fixes related to the commits in this PR.
8e81440

eirikbakke force-pushed the NETBEANS-2455 branch from b4c0e1d to 8e81440Compare June 7, 2019 15:53

eirikbakke mentioned this pull request Jun 9, 2019
[NETBEANS-2604] Support SVG icon loading from ImageUtilities #1278
Merged

eirikbakke added the API Change [ci] enable extra API related tests label Jun 9, 2019

neilcsmith-net added the NB11.1 label Jun 10, 2019

eirikbakke merged commit 7d7d0f7 into apache:masterJun 14, 2019

eirikbakke mentioned this pull request Jan 31, 2022
Larger icon sizes missing in platform branding UI #3544
Closed
3 tasks

eirikbakke deleted the NETBEANS-2455 branch October 5, 2022 13:24

neilcsmith-net mentioned this pull request Mar 28, 2026
Move Splash initialization to EDT and make it no longer modal #9303
Merged