Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions by Param-S · Pull Request #24 · apache/openwhisk-runtime-java

Param-S · 2018-03-05T13:16:57Z

Eclipse OpenJ9 runtime for Java is opensource runtime which is available as binary through AdoptOpenJDK community builds. By making available of the Eclipse OpenJ9 for OW Java actions, it gives the developers the option to choose between different Java runtime implementations.

Signed-off-by: Parameswaran Selvam sparameswara@gmail.com

csantanapr · 2018-03-05T17:29:10Z

@@ -0,0 +1,10 @@
+FROM adoptopenjdk/openjdk8-openj9:x86_64-ubuntu-jdk8u152-b16


We should replace the current image using oracle jdk and replcae the current java8action one with with this openjdk which uses ubuntu/debian based, transparent transition

then we can close the other PR as this takes care of it ???

kameshsampath

When I checked the docker hub of AdpotOpenJDK I just see adoptopenjdk/openjdk8-openj9, where are you getting this Adoptopenjdk/openjdk8-openj9:x86_64-ubuntu-jdk8u152-b16 from ?

Param-S · 2018-03-06T05:42:09Z

Please refer the tags section https://hub.docker.com/r/adoptopenjdk/openjdk8-openj9/tags/

x86_64-ubuntu-jdk8u152-b16

kameshsampath · 2018-03-06T16:16:53Z

@Param-S @csantanapr check this https://github.com/kameshsampath/adoptopenjdk , I have made the docker images temptable which right now builds JDK8/JDK9 for Centos/Debian using AdoptOpenJDK builds for both hotspot/openj9. This should reduce our maintenance much easier. WDYT?

Param-S · 2018-03-07T13:51:58Z

@kameshsampath It will be useful. But, I think, we can have separate discussion as we may need to focus on less footprint images (like alpine based). We can have this discussion separately in issues, discuss on the need to support another distro, advantages & etc.

csantanapr

please replace current image do not create new one.

csantanapr · 2018-03-07T14:41:30Z

 dockerRetries = project.hasProperty('dockerRetries') ? dockerRetries.toInteger() : 3
 dockerBinary = project.hasProperty('dockerBinary') ? [dockerBinary] : ['docker']
 dockerBuildArg = ['build']
+ dockerFile = project.hasProperty('dockerFile') ? dockerFile : 'Dockerfile'


No need to change docker.gradle.
Please replace the current image in https://github.com/apache/incubator-openwhisk-runtime-java/blob/master/core/javaAction/Dockerfile

dinogun · 2018-03-08T08:04:59Z

Just thought it is relevant to this discussion - Advantages with OpenJ9

Param-S · 2018-03-12T14:01:40Z

@csantanapr made modification to make AdoptOpenJDK_EclipseOpenJ9 JDK image is the default for Java actions

Param-S · 2018-03-13T06:26:58Z

actionContainers.JavaActionContainerTests > Java action should handle unicode in source, input params, logs, and result FAILED.

Looking at the failure

csantanapr · 2018-03-13T10:08:10Z

It could be related to locale and utf need to be set in env in the runtime

rabbah · 2018-03-13T10:32:11Z

-ENV LANG en_US.UTF-8
-ENV LANGUAGE en_US:en
-ENV LC_ALL en_US.UTF-8
-


You’ll want to restore these.

I haven’t looked at the new dockerfile dependence below. If these aren’t set you’ll need to reset them.

Yep those are the ones I was referring 👍

Restored the locale specific environment variable settings.

Thanks @rabbah @csantanapr Restoring the environment variable solved the issue. All checks passed.

Just noticed you added the locales package here. Good belt-and-suspenders approach.

dinogun · 2018-03-15T16:12:40Z

The latest OpenJ9 Docker images have now been marked as TCK certified, and so the Dont use in Production banner has been removed as well.

@Param-S Please use the tag jdk8u162-b12_openj9-0.8.0 (This is a multi-arch tag and works on x86_64, ppc64le and s390x)

Param-S · 2018-03-16T08:55:16Z

Updated Docker file with latest AdoptOpenJDK TCK compliant docker build.

dinogun · 2018-03-16T09:19:49Z

@@ -1,38 +1,23 @@
-FROM buildpack-deps:trusty-curl
+FROM adoptopenjdk/openjdk8-openj9:x86_64-ubuntu-jdk8u162-b12_openj9-0.8.0


As I mentioned in my comment, use the jdk8u162-b12_openj9-0.8.0 tag rather than the x86_64-ubuntu-jdk8u162-b12_openj9-0.8.0

jonpspri · 2018-03-17T17:32:12Z

I’m working my way through a multi-architecture build for this. Is there a reason we feel the need to build the proxy JAR within the Docker image? My gut would be to build it once on the build machine and copy the resulting JAR onto the Docker image. Thoughts?

jonpspri · 2018-03-19T23:00:43Z

Running into the unicode failure again using jdk8u162-b12_openj9-0.8.0. The environment variables mentioned above are set in the runtime and also in the test compile environment. Any thoughts on additional potential causes?

Param-S · 2018-03-20T06:19:46Z

@jonpspri which testcase fails with the latest Docker image.

jonpspri · 2018-03-20T13:37:03Z

@Param-S The same unicode test case as above. Hold tight — I seem to have some classpath issues and may not be running the correct test issues. Will be filing a PR over in incubator-openwhisk about that shortly.

jonpspri · 2018-03-21T13:35:44Z

I think I found my problem buried in a circular dependency on incubator-openwhisk for some of the core test classes, which means I was never sure what locale settings any given class was compiled under. I’m working on some separate PRs for that but it appears that the multi-architecture tag will give us a clean build and test on all architectures.

jonpspri · 2018-03-21T17:45:51Z

Found it. For whatever reason, the proxy was running using the ‘US-ASCII’ code page to log to the Docker log. Safest and most explicit resolution is to add ‘-Dfile.encoding=UTF-8’ to the CMD line. That way there’s no room for confusion.

jonpspri · 2018-03-21T17:46:58Z

+	&& ./compileClassCache.sh

-CMD ["java", "-jar", "/javaAction/build/libs/javaAction-all.jar"]
+CMD ["java", "-Xshareclasses:cacheDir=/javaSharedCache,readonly", "-Xquickstart", "-jar", "/javaAction/build/libs/javaAction-all.jar"]


Suggest also adding ‘-Dfile.encoding=UTF-8’. I think that may even do away with the need to use the locales apt package (though nothing is certain when it comes to locales.)

agree. I update the PR

csantanapr

LGTM

csantanapr · 2018-04-05T14:21:27Z

@Param-S could you rebase the PR?

Enable AdoptOpenJDK + Eclipse OpenJ9 JVM is the Java runtime for OpenWhisk Java actions. Signed-off-by: Parameswaran Selvam <sparameswara@gmail.com>

Param-S · 2018-04-05T16:00:58Z

@csantanapr rebased the PR.

Param-S mentioned this pull request Mar 5, 2018
Provide Eclipse OpenJ9 as alternative Java runtime for OW java action #22
Closed

csantanapr reviewed Mar 5, 2018
View reviewed changes

kameshsampath mentioned this pull request Mar 5, 2018
Rebase OW JavaRuntime to use OpenJDK 8 #18
Closed

kameshsampath reviewed Mar 6, 2018
View reviewed changes

kameshsampath mentioned this pull request Mar 7, 2018
Multiple Distros for Java Runtimes #26
Open

csantanapr requested changes Mar 7, 2018
View reviewed changes

Param-S force-pushed the SupportAdoptOpenJDKEclipseOpenJ9 branch from 7adbbce to 32ab6baCompare March 12, 2018 13:53

Param-S changed the title ~~AdoptOpenJDK Eclipse OpenJ9 as alternative Java runtime~~Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actionsMar 12, 2018

rabbah reviewed Mar 13, 2018
View reviewed changes

Param-S force-pushed the SupportAdoptOpenJDKEclipseOpenJ9 branch from 32ab6ba to 9589f83Compare March 13, 2018 11:54

Param-S force-pushed the SupportAdoptOpenJDKEclipseOpenJ9 branch 2 times, most recently from 45bd5c9 to a9289f6Compare March 16, 2018 08:23

dinogun reviewed Mar 16, 2018
View reviewed changes

Param-S force-pushed the SupportAdoptOpenJDKEclipseOpenJ9 branch from a9289f6 to c05de88Compare March 16, 2018 10:59

jonpspri reviewed Mar 21, 2018
View reviewed changes

Param-S force-pushed the SupportAdoptOpenJDKEclipseOpenJ9 branch from c05de88 to e842640Compare March 22, 2018 11:41

csantanapr approved these changes Apr 5, 2018
View reviewed changes

AdoptOpenJDK Eclipse OpenJ9 the Java runtime for OpenWhisk Java actions
d55dc47
Enable AdoptOpenJDK + Eclipse OpenJ9 JVM is the Java runtime for OpenWhisk Java actions. Signed-off-by: Parameswaran Selvam <sparameswara@gmail.com>

Param-S force-pushed the SupportAdoptOpenJDKEclipseOpenJ9 branch from e842640 to d55dc47Compare April 5, 2018 14:45

csantanapr merged commit aeda0a4 into apache:masterApr 16, 2018

Param-S mentioned this pull request Apr 26, 2018
Enable Class Data Sharing option for Java runtime #21
Closed

		@@ -0,0 +1,10 @@
		FROM adoptopenjdk/openjdk8-openj9:x86_64-ubuntu-jdk8u152-b16

		@@ -1,38 +1,23 @@
		FROM buildpack-deps:trusty-curl
		FROM adoptopenjdk/openjdk8-openj9:x86_64-ubuntu-jdk8u162-b12_openj9-0.8.0

Uh oh!

Conversation

Param-S commented Mar 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kameshsampath left a comment

Choose a reason for hiding this comment

Uh oh!

Param-S commented Mar 6, 2018

Uh oh!

kameshsampath commented Mar 6, 2018

Uh oh!

Param-S commented Mar 7, 2018

Uh oh!

csantanapr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dinogun commented Mar 8, 2018

Uh oh!

Param-S commented Mar 12, 2018

Uh oh!

Param-S commented Mar 13, 2018

Uh oh!

csantanapr commented Mar 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Param-SMar 13, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dinogun commented Mar 15, 2018

Uh oh!

Param-S commented Mar 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonpspri commented Mar 17, 2018

Uh oh!

jonpspri commented Mar 19, 2018

Uh oh!

Param-S commented Mar 20, 2018

Uh oh!

jonpspri commented Mar 20, 2018

Uh oh!

jonpspri commented Mar 21, 2018

Uh oh!

jonpspri commented Mar 21, 2018

Uh oh!

jonpspriMar 21, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

csantanapr left a comment

Choose a reason for hiding this comment

Uh oh!

csantanapr commented Apr 5, 2018

Uh oh!

Param-S commented Apr 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Param-SMar 13, 2018•
edited
Loading

jonpspriMar 21, 2018•
edited
Loading