Uh oh!
There was an error while loading. Please reload this page.
ORC-1364: Pin spotless to 2.30.0 - #1395
Merged
Merged
Conversation
dongjoon-hyun
commented
Feb 1, 2023
MemberAuthor
cc @williamhyun |
cxzl25
approved these changes
Feb 6, 2023
dongjoon-hyun
commented
Feb 6, 2023
MemberAuthor
Thank you , @cxzl25 . |
dongjoon-hyun added a commit
that referenced
this pull request
Mar 9, 2023
### What changes were proposed in this pull request? This PR pins `spotless` to 2.30.0. ### Why are the changes needed? `spotless` dropped Java 8 support at 2.31.0. - diffplug/spotless#1514 - #1392 ### How was this patch tested? Manual review. (cherry picked from commit 14fba6a) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
MemberAuthor
This is going to be included in Apache ORC 1.8.3 release. |
cxzl25 pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR pins `spotless` to 2.30.0. ### Why are the changes needed? `spotless` dropped Java 8 support at 2.31.0. - diffplug/spotless#1514 - apache#1392 ### How was this patch tested? Manual review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR pins
spotlessto 2.30.0.Why are the changes needed?
spotlessdropped Java 8 support at 2.31.0.How was this patch tested?
Manual review.