Uh oh!
There was an error while loading. Please reload this page.
ORC-1525: Fix bad read in RleDecoderV2::readByte - #1641
Closed
hoffermei wants to merge 5 commits into
Closed
Conversation
hoffermeiforce-pushed
the
present_supress_bugfix
branch
from
October 23, 2023 02:07
be57b97 to
be284c8Comparewgtmac
reviewed
Oct 23, 2023
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix and adding the test! Could you create a JIRA issue and add it to the PR title?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wgtmac
commented
Oct 30, 2023
Member
Gentle ping @hoffermei |
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
Could you fix this, @hoffermei ? Currently, CIs complain on that.
/Users/runner/work/orc/orc/c++/test/TestWriter.cc:2150:47: error: use of old-style cast [-Werror,-Wold-style-cast]
size_t rowIndex = rowsWrite + row + (size_t) 1;
dongjoon-hyun
commented
Oct 31, 2023
Member
I created a JIRA, ORC-1525, for this. |
dongjoon-hyun
commented
Oct 31, 2023
Member
If this is originated from ORC-1130, we need to backport this to branch-1.9 and branch-1.8. |
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
RleDecoderV2::readBytedongjoon-hyun
approved these changes
Oct 31, 2023
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM from my side.
Could you review this once more, @wgtmac ?
wgtmac
approved these changes
Nov 1, 2023
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks @dongjoon-hyun! LGTM. I agree with you that we need to backport this.
dongjoon-hyun
commented
Nov 1, 2023
Member
Thank you, @wgtmac ! |
dongjoon-hyun pushed a commit
that referenced
this pull request
Nov 1, 2023
This PR aims to fix#1640 by resetting `BooleanRleEncoderImpl::current` and `BooleanRleEncoderImpl::bitsRemained` when suppress As #1640 suppress no null present stream leaves dirty data of BooleanRleEncoderImpl::current and BooleanRleEncoderImpl::bitsRemained, which will be flush to next stripe's present stream if it has some null values. I hava add a test testSuppressPresentStreamInPreStripe, which will construct a orc file with two stripe, the first stripe has no null value and seconds stripe has some null values. The constructed orc file writer have some dirty data in BooleanRleEncoderImpl for present stream. In the test I have add check for read ok and read result is same as write. Closes#1640 . Closes#1641 from hoffermei/present_supress_bugfix. Lead-authored-by: hoffermei <meihaifeng.hust@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 24beffb) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
commented
Nov 1, 2023
Member
Unfortunately, it turns out that we need additional PR for branch-1.8 because This PR is merged to |
dongjoon-hyun
commented
Nov 1, 2023
Member
To @hoffermei , I'd like to assign ORC-1525 to you. Do you have Apache JIRA ID? |
wgtmac
commented
Nov 1, 2023
Member
I will take a look |
wgtmac pushed a commit
to wgtmac/orc
that referenced
this pull request
Nov 2, 2023
This PR aims to fixapache#1640 by resetting `BooleanRleEncoderImpl::current` and `BooleanRleEncoderImpl::bitsRemained` when suppress As apache#1640 suppress no null present stream leaves dirty data of BooleanRleEncoderImpl::current and BooleanRleEncoderImpl::bitsRemained, which will be flush to next stripe's present stream if it has some null values. I hava add a test testSuppressPresentStreamInPreStripe, which will construct a orc file with two stripe, the first stripe has no null value and seconds stripe has some null values. The constructed orc file writer have some dirty data in BooleanRleEncoderImpl for present stream. In the test I have add check for read ok and read result is same as write. Closesapache#1640 . Closesapache#1641 from hoffermei/present_supress_bugfix. Lead-authored-by: hoffermei <meihaifeng.hust@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
cxzl25 pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
This PR aims to fixapache#1640 by resetting `BooleanRleEncoderImpl::current` and `BooleanRleEncoderImpl::bitsRemained` when suppress As apache#1640 suppress no null present stream leaves dirty data of BooleanRleEncoderImpl::current and BooleanRleEncoderImpl::bitsRemained, which will be flush to next stripe's present stream if it has some null values. I hava add a test testSuppressPresentStreamInPreStripe, which will construct a orc file with two stripe, the first stripe has no null value and seconds stripe has some null values. The constructed orc file writer have some dirty data in BooleanRleEncoderImpl for present stream. In the test I have add check for read ok and read result is same as write. Closesapache#1640 . Closesapache#1641 from hoffermei/present_supress_bugfix. Lead-authored-by: hoffermei <meihaifeng.hust@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix#1640 by resetting
BooleanRleEncoderImpl::currentandBooleanRleEncoderImpl::bitsRemainedwhen suppressWhy are the changes needed?
As #1640 suppress no null present stream leaves dirty data of BooleanRleEncoderImpl::current and BooleanRleEncoderImpl::bitsRemained, which will be flush to next stripe's present stream if it has some null values.
How was this patch tested?
I hava add a test testSuppressPresentStreamInPreStripe, which will construct a orc file with two stripe, the first stripe has no null value and seconds stripe has some null values. The constructed orc file writer have some dirty data in BooleanRleEncoderImpl for present stream. In the test I have add check for read ok and read result is same as write.
Closes#1640 .