Uh oh!
There was an error while loading. Please reload this page.
ORC-1549: [C++] Update libhdfspp.tar.gz by adding #include <cstdint> - #1685
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
ORC-1549: [C++] Update libhdfspp.tar.gz by adding #include <cstdint>#1685dongjoon-hyun wants to merge 1 commit into
libhdfspp.tar.gz by adding #include <cstdint>#1685dongjoon-hyun wants to merge 1 commit into
Conversation
libhdfspp.tar.gz by adding #include <cstdint>libhdfspp.tar.gz by adding #include <cstdint>dongjoon-hyun
commented
Dec 7, 2023
MemberAuthor
Could you review this, @wgtmac ? |
dongjoon-hyun
commented
Dec 7, 2023
MemberAuthor
Thank you, @wgtmac . |
cxzl25 pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to add `#include <cstdint>` to `libhdfspp.tar.gz`. ``` $ diff -r before after diff --color -r /Users/dongjoon/APACHE/orc-merge/c++/libs/libhdfspp/tmp/include/hdfspp/content_summary.h ./tmp/include/hdfspp/content_summary.h 20a21 > #include <cstdint> diff --color -r /Users/dongjoon/APACHE/orc-merge/c++/libs/libhdfspp/tmp/include/hdfspp/fsinfo.h ./tmp/include/hdfspp/fsinfo.h 20a21 > #include <cstdint> diff --color -r /Users/dongjoon/APACHE/orc-merge/c++/libs/libhdfspp/tmp/include/hdfspp/statinfo.h ./tmp/include/hdfspp/statinfo.h 20a21 > #include <cstdint> diff --color -r /Users/dongjoon/APACHE/orc-merge/c++/libs/libhdfspp/tmp/include/hdfspp/uri.h ./tmp/include/hdfspp/uri.h 21a22 > #include <cstdint> ``` ### Why are the changes needed? To fix a compilation error in `GNU C/CXX compiler: 13.2.0` environment. ### How was this patch tested? Manually compile with `GNU C/CXX compiler: 13.2.0`. Closesapache#1685 from dongjoon-hyun/ORC-1549. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
#include <cstdint>tolibhdfspp.tar.gz.Why are the changes needed?
To fix a compilation error in
GNU C/CXX compiler: 13.2.0environment.How was this patch tested?
Manually compile with
GNU C/CXX compiler: 13.2.0.