Skip to content

ORC-1662: [C++] Upgrade protobuf to 3.21.12 - #1857

Closed
ffacs wants to merge 3 commits into
apache:mainfrom
ffacs:bump_protobuf_version
Closed

ORC-1662: [C++] Upgrade protobuf to 3.21.12#1857
ffacs wants to merge 3 commits into
apache:mainfrom
ffacs:bump_protobuf_version

Conversation

@ffacs

@ffacsffacs commented Mar 21, 2024

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Upgrade protobuf to 3.21.12

Why are the changes needed?

To fix compilation failure on vs2022

How was this patch tested?

UT passed

Was this patch authored or co-authored using generative AI tooling?

NO

@wgtmac

wgtmac commented Mar 22, 2024

Copy link
Copy Markdown
Member

Thanks for the PR! Unfortunately the new protobuf version is not compatible to compile libhdfspp. Let me investigate this.

@wgtmac

wgtmac commented Mar 22, 2024

Copy link
Copy Markdown
Member

Update: I tried to upgrade libhdfspp. But unfortunately, I ran this command https://github.com/apache/orc/blob/main/c%2B%2B/libs/libhdfspp/pull_hdfs.sh#L25 without check. It wiped out my current directory (which is the root user profile).

@dongjoon-hyun

dongjoon-hyun commented Mar 22, 2024

Copy link
Copy Markdown
Member

Oh, too bad for the accident.

@ffacsffacs mentioned this pull request Mar 27, 2024
Closed
@wgtmacwgtmac mentioned this pull request Apr 11, 2024
Closed
@wgtmacwgtmac mentioned this pull request Apr 23, 2024
Closed
@dongjoon-hyundongjoon-hyun mentioned this pull request Feb 20, 2025
Closed
@dongjoon-hyundongjoon-hyun added this to the 2.2.0 milestone Feb 20, 2025
@dongjoon-hyun

dongjoon-hyun commented Feb 20, 2025•
edited
Loading

Copy link
Copy Markdown
Member

I re-target this to Apache ORC 3.0.0 with the following, @ffacs and @wgtmac .

@dongjoon-hyundongjoon-hyun mentioned this pull request Feb 20, 2025
Closed
@dongjoon-hyundongjoon-hyun modified the milestones: 2.2.0, 3.0.0Feb 20, 2025
@dongjoon-hyundongjoon-hyun mentioned this pull request Jun 25, 2025
Closed
@dongjoon-hyundongjoon-hyun mentioned this pull request Feb 23, 2026
Closed
dongjoon-hyun added a commit that referenced this pull request Feb 23, 2026
@dongjoon-hyun
ORC-2102: [C++] Remove HDFS support
24eece3
### What changes were proposed in this pull request?
This PR aims to remove HDFS support code from Apache ORC repository.
### Why are the changes needed?
Apache ORC 2.0.1 deprecated HDFS Support to address the following issues.
- #1885
- #1857
- #2134
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: `Gemini 3.1 Pro (High)` on `Antigravity`
This closes#2136 .
Closes#2544 from dongjoon-hyun/ORC-2102.
Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun

dongjoon-hyun commented Feb 23, 2026

Copy link
Copy Markdown
Member

Could you rebase this PR, @ffacs ?

ffacsand others added 3 commits February 25, 2026 19:38
@ffacs
[C++] Upgrade protobuf to 3.21.12
121f0b0
@ffacs@cursoragent
[C++] Fix vendored Protobuf target conflicts for version >= 3.21
2486de0
Guard alias creation for protobuf::libprotobuf and protobuf::protoc to
avoid duplicate target errors when Protobuf >= 3.21 already exports
them. Also mark protobuf headers as SYSTEM to suppress compiler
warnings from protobuf code.
Co-authored-by: Cursor <cursoragent@cursor.com>
@ffacs@cursoragent
[C++] Bump meson protobuf wrap from 3.5.1 to 3.21.12
91a336a
Align the meson build protobuf version with the CMake build (3.21.12)
using the latest wrapdb patch (3.21.12-5).
Co-authored-by: Cursor <cursoragent@cursor.com>
@ffacs
ffacsforce-pushed the bump_protobuf_version branch from f9737e2 to 91a336aCompareFebruary 25, 2026 11:43
dongjoon-hyun
dongjoon-hyun reviewed Feb 25, 2026
View reviewed changes

@dongjoon-hyundongjoon-hyun left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ffacs and @wgtmac .

Shall we bump to more recent version like v25.x , v29.6, or v33.5 because this is the only chance to upgrade? WDYT?

For example, Apache Spark community moved to v33.5 already for this summer release (Spark 4.2.0)

For ORC Java part, I made a PR.

@wgtmac

wgtmac commented Feb 25, 2026

Copy link
Copy Markdown
Member

@dongjoon-hyun I think it is a good idea to bump protobuf to a higher version. FTR, we internally upgraded to protobuf/5.27.0 for C++.

@wgtmac

wgtmac commented Feb 25, 2026

Copy link
Copy Markdown
Member

Arrow is still using v21.3: https://github.com/apache/arrow/blob/main/cpp/thirdparty/versions.txt#L95

@dongjoon-hyun

dongjoon-hyun commented Feb 25, 2026

Copy link
Copy Markdown
Member

Given that Arrow community is our big customer for ORC C++, I'm fine with the AS-IS PR also.

Then, I'll bump the protobuf-java only because Spark community is our big customer for ORC java.

Thank you!

@dongjoon-hyun

dongjoon-hyun commented Feb 25, 2026

Copy link
Copy Markdown
Member

Merged to main for Apache ORC 3.0.0. Thank you again ,@ffacs and @wgtmac .

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyundongjoon-hyundongjoon-hyun approved these changes

Assignees

No one assigned

Labels

BUILD

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ffacs@wgtmac@dongjoon-hyun