Skip to content

ORC-1936: Get build and example dir from build system rather than gtest - #2291

Closed
WillAyd wants to merge 1 commit into
apache:mainfrom
WillAyd:improve-gtest-cli
Closed

ORC-1936: Get build and example dir from build system rather than gtest#2291
WillAyd wants to merge 1 commit into
apache:mainfrom
WillAyd:improve-gtest-cli

Conversation

@WillAyd

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Rather than pulling the build and example directory from gtest arguments, this pulls it from the build system.

Why are the changes needed?

When orc is used as a subproject, the current method of grabbing the arguments from the build system fails

How was this patch tested?

Tests were run locally

Was this patch authored or co-authored using generative AI tooling?

No

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make CIs happy, @WillAyd ?

@WillAyd
WillAydforce-pushed the improve-gtest-cli branch 4 times, most recently from 0a650cd to 3955b59CompareJune 20, 2025 17:22
@WillAyd

Copy link
Copy Markdown
ContributorAuthor

Sorry about the delay - all green!

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @WillAyd .
Merged to main for Apache ORC 2.2.0.

@dongjoon-hyun

dongjoon-hyun commented Jun 23, 2025

Copy link
Copy Markdown
Member

Oh my. ORC-2238 doesn't exist, @WillAyd . I'll reset this commit first.

Please don't do like this again. As you know, Apache repository uses ORC-XXX as a hyperlink pattern for the JIRA system.

Screenshot 2025-06-23 at 09 41 57

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed from master branch due to the invalid ORC JIRA ID.

@WillAyd

Copy link
Copy Markdown
ContributorAuthor

Ah sorry - I used the issue number which is 2238. Where can I find the Jira number?

@dongjoon-hyun

Copy link
Copy Markdown
Member

Here is the Apache ORC developer guideline.

https://orc.apache.org/develop/

Each code change requires a jira to track the discussion of the change.

In addition, it seems that you missed my previous comment here.

@WillAyd

Copy link
Copy Markdown
ContributorAuthor

OK great. I'll open a Jira ticket to track the github issue then. Should we reopen and update the title of this PR after that or should I create a new PR entirely?

Thanks for the patience - every project is a little different so its a challenge to keep track of all of their requirements :-)

@WillAyd

Copy link
Copy Markdown
ContributorAuthor

@dongjoon-hyundongjoon-hyun changed the title ORC-2238: Get build and example dir from build system rather than gtestORC-1936: Get build and example dir from build system rather than gtestJun 23, 2025
@dongjoon-hyundongjoon-hyun added this to the 2.2.0 milestone Jun 23, 2025
@dongjoon-hyun

Copy link
Copy Markdown
Member

Thank you. I reopened this PR with your new JIRA ID, ORC-1936 .

@dongjoon-hyun

Copy link
Copy Markdown
Member

After passing CI agains, I will put it back to main branch again.

@dongjoon-hyun

dongjoon-hyun commented Jun 23, 2025

Copy link
Copy Markdown
Member

Merged to the main branch again.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@WillAyd@dongjoon-hyun