Uh oh!
There was an error while loading. Please reload this page.
ORC-1936: Get build and example dir from build system rather than gtest - #2291
ORC-1936: Get build and example dir from build system rather than gtest#2291WillAyd wants to merge 1 commit into
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you make CIs happy, @WillAyd ?
0a650cd to
3955b59CompareWillAyd
commented
Jun 23, 2025
Sorry about the delay - all green! |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @WillAyd .
Merged to main for Apache ORC 2.2.0.
dongjoon-hyun
left a comment
There was a problem hiding this comment.
This is removed from master branch due to the invalid ORC JIRA ID.
WillAyd
commented
Jun 23, 2025
Ah sorry - I used the issue number which is 2238. Where can I find the Jira number? |
dongjoon-hyun
commented
Jun 23, 2025
Here is the Apache ORC developer guideline. https://orc.apache.org/develop/
In addition, it seems that you missed my previous comment here. |
WillAyd
commented
Jun 23, 2025
OK great. I'll open a Jira ticket to track the github issue then. Should we reopen and update the title of this PR after that or should I create a new PR entirely? Thanks for the patience - every project is a little different so its a challenge to keep track of all of their requirements :-) |
WillAyd
commented
Jun 23, 2025
https://issues.apache.org/jira/browse/ORC-1936 has been opened |
dongjoon-hyun
commented
Jun 23, 2025
Thank you. I reopened this PR with your new JIRA ID, ORC-1936 . |
dongjoon-hyun
commented
Jun 23, 2025
After passing CI agains, I will put it back to |
Merged to the |

What changes were proposed in this pull request?
Rather than pulling the build and example directory from gtest arguments, this pulls it from the build system.
Why are the changes needed?
When orc is used as a subproject, the current method of grabbing the arguments from the build system fails
How was this patch tested?
Tests were run locally
Was this patch authored or co-authored using generative AI tooling?
No