Uh oh!
There was an error while loading. Please reload this page.
ORC-1924: [CI] Add Windows-2025 Action job - #2363
Closed
luffy-zh wants to merge 12 commits into
Closed
Conversation
dongjoon-hyun
commented
Sep 15, 2025
Member
Thank you for updating, @luffy-zh . Is it ready to pass the CI? |
luffy-zh
commented
Sep 16, 2025
ContributorAuthor
Not yet. I'm still working on it. |
wgtmac
reviewed
Sep 21, 2025
| meson setup build -Dbuildtype=release | ||
| meson compile -C build | ||
| meson test -C build | ||
| meson test -C build No newline at end of file |
| TEST(TestTimezone, testZoneCache) { | ||
| // FIXME: Temporarily disable the test due to the failure on CI system | ||
| // https://issues.apache.org/jira/projects/ORC/issues/ORC-1976?filter=allopenissues |
Member
There was a problem hiding this comment.
Suggested change
| // https://issues.apache.org/jira/projects/ORC/issues/ORC-1976?filter=allopenissues | |
| // https://issues.apache.org/jira/projects/ORC/issues/ORC-1976 |
| TEST(TestTimezone, testTzdbFromCondaEnv) { | ||
| // FIXME: Temporarily disable the test due to the failure on CI system | ||
| // https://issues.apache.org/jira/projects/ORC/issues/ORC-1976?filter=allopenissues |
Member
There was a problem hiding this comment.
Suggested change
| // https://issues.apache.org/jira/projects/ORC/issues/ORC-1976?filter=allopenissues | |
| // https://issues.apache.org/jira/projects/ORC/issues/ORC-1976 |
| run: | | ||
| mkdir build | ||
| cd build | ||
| cmake .. -G "Visual Studio 17 2022" -DCMAKE_BUILD_TYPE=RELEASE -DBUILD_LIBHDFSPP=OFF -DBUILD_TOOLS=OFF -DBUILD_JAVA=OFF -DANALYZE_JAVA=OFF -DCMAKE_TOOLCHAIN_FILE="$VCPKG_ROOT/scripts/buildsystems/vcpkg.cmake" -DProtobuf_ROOT="$VCPKG_ROOT/installed/x64-windows" -DCMAKE_PREFIX_PATH="$VCPKG_ROOT/installed/x64-windows" -DORC_PACKAGE_KIND=vcpkg |
Member
There was a problem hiding this comment.
This line is too long. Can we break it into multiple lines?
| mkdir build | ||
| cd build | ||
| cmake .. -G "Visual Studio 17 2022" -DCMAKE_BUILD_TYPE=RELEASE -DBUILD_LIBHDFSPP=OFF -DBUILD_TOOLS=OFF -DBUILD_JAVA=OFF -DANALYZE_JAVA=OFF -DCMAKE_TOOLCHAIN_FILE="$VCPKG_ROOT/scripts/buildsystems/vcpkg.cmake" -DProtobuf_ROOT="$VCPKG_ROOT/installed/x64-windows" -DCMAKE_PREFIX_PATH="$VCPKG_ROOT/installed/x64-windows" -DORC_PACKAGE_KIND=vcpkg | ||
| cmake --build . --config Debug |
Member
There was a problem hiding this comment.
Can we be consistent with -DCMAKE_BUILD_TYPE=RELEASE?
| cmake --build . --config Debug | ||
| if [ $? -ne 0 ]; then | ||
| echo "Build failed" | ||
| ls -la |
| TEST_P(WriterTest, writeTimestamp) { | ||
| // FIXME: Temporarily disable the test due to the failure on CI system | ||
| // https://issues.apache.org/jira/projects/ORC/issues/ORC-1976?filter=allopenissues |
| } | ||
| TEST(TestTimezone, testZoneCache) { | ||
| // FIXME: Temporarily disable the test due to the failure on CI system |
Member
There was a problem hiding this comment.
Suggested change
| // FIXME: Temporarily disable the test due to the failure on CI system | |
| // FIXME: Temporarily disable the test to make Windows CI happy |
| list (APPEND ORC_SYSTEM_DEPENDENCIES ZLIB) | ||
| list (APPEND ORC_INSTALL_INTERFACE_TARGETS "$<INSTALL_INTERFACE:ZLIB::ZLIB>") | ||
| elseif (ORC_PACKAGE_KIND STREQUAL "vcpkg") | ||
| list (APPEND ORC_SYSTEM_DEPENDENCIES Protobuf) | ||
| list (APPEND ORC_INSTALL_INTERFACE_TARGETS "$<INSTALL_INTERFACE:protobuf::libprotobuf>") | ||
| orc_provide_find_module (Protobuf) | ||
| elseif (ORC_PACKAGE_KIND STREQUAL "vcpkg") |
Member
There was a problem hiding this comment.
Will this branch ever be hit? It has the same branch at line 511.
wgtmac
approved these changes
Sep 23, 2025
Member
Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Windows 2025 CI job.
Why are the changes needed?
The existing Windows CI has been deprecated.
How was this patch tested?
CI job validates this patch.
Was this patch authored or co-authored using generative AI tooling?
No.