Uh oh!
There was an error while loading. Please reload this page.
HDDS-3694. Reduce dn-audit log - #1001
Merged
Merged
Conversation
ContributorAuthor
Failure is unrelated to patch, failed due to timeout. |
adoroszlai
requested changes
Jun 2, 2020
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dineshchitlangia for working on this.
Can this performance/security improvement be re-titled to clarify the change? I don't think this is a refactoring, since behavior is being changed.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
adoroszlai
approved these changes
Jun 3, 2020
adoroszlai
commented
Jun 3, 2020
Contributor
Thanks @dineshchitlangia for updating the patch. |
dineshchitlangia
commented
Jun 3, 2020
ContributorAuthor
Thanks @adoroszlai for review/commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
reduced dn audit log:
As discussed in community call
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3694
How was this patch tested?
Build and deployed 3 node cluster, created a few keys. Confirmed that DN audit log no longer logs for CHUNK/BLOCK related operations.