Uh oh!
There was an error while loading. Please reload this page.
HDDS-15085. Add DN and Cluster Readiness - #10757
Merged
Merged
Conversation
henrybear327
commented
Jul 14, 2026
ContributorAuthor
PTAL @peterxcli , thank you! |
henrybear327force-pushed
the
HDDS-15085
branch
2 times, most recently
from
July 16, 2026 06:23
3a38005 to
c36b14aCompare
chungen0126
left a comment
Contributor
There was a problem hiding this comment.
Thanks @henrybear327 for working on this.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Bolin Lin <linbolin1230@gmail.com>
chungen0126
approved these changes
Jul 20, 2026
chungen0126
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM. However, I think we should log some information when some critical configuration error occurs.
henrybear327
commented
Jul 20, 2026
ContributorAuthor
Thanks for the review @chungen0126! What do you have in mind as the critical configuration error? I can improve this in a follow up PR. Thanks. |
peterxcli
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Original work was done in #10159 by https://github.com/YutaLin
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15085
How was this patch tested?
https://github.com/apache/ozone/actions/runs/29327332184