HDDS-15709. Replace random name suffix with uniqueObjectName by prathmesh12-coder · Pull Request #10773 · apache/ozone

prathmesh12-coder · 2026-07-15T06:38:32Z

What changes were proposed in this pull request?

we have intermittent BUCKET_ALREADY_EXISTS error during integration tests due to RandomStringUtils.secure().nextNumeric(...)
Replaced RandomStringUtils.secure().nextNumeric(...) with OzoneTestBase.uniqueObjectName(...) for Ozone object names (volume/bucket/key/snapshot) in integration tests.
Identity names (user/admin/owner), loop-indexed names, and nextNumeric(32) usages left unchanged.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15709

How was this patch tested?

Reviewed remaining RandomStringUtils.secure().nextNumeric(...) in hadoop-ozone/integration-test/ with:

grep -rF 'RandomStringUtils.secure().nextNumeric' hadoop-ozone/integration-test

CI success : https://github.com/prathmesh12-coder/ozone/actions/runs/29388650631

…s to avoid intermittent BUCKET_ALREADY_EXISTS Replaced RandomStringUtils.secure().nextNumeric(...) with OzoneTestBase.uniqueObjectName(...) for Ozone object names (volume/bucket/key/snapshot) in integration tests. Identity names (user/admin/owner), loop-indexed names, and nextNumeric(32) usages are left unchanged.

sarvekshayr

Thanks @prathmesh12-coder for working on this.

Please resolve the merge conflicts in this PR.

# Conflicts: # hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestAddRemoveOzoneManager.java

sarvekshayr

Please fix the CI checkstyle failure.

sarvekshayr · 2026-07-15T07:32:35Z

- String volumeName = "volume" + RandomStringUtils.secure().nextNumeric(5);
- String bucketName = "volume" + RandomStringUtils.secure().nextNumeric(5);
+ String volumeName = uniqueObjectName("volume");
+ String bucketName = uniqueObjectName("volume");


Incorrect bucket prefix -
Suggested change
StringbucketName = uniqueObjectName("volume");
StringbucketName = uniqueObjectName("bucket");

Thanks @sarvekshayr for review !!
I left this as it was before, will change the similar occurrences. volName -> "vol.." , bucName -> "buc.." etc.
cc : @adoroszlai

done..bucket prefix fixed in both files.

sarvekshayr · 2026-07-15T07:37:05Z

- String volumeName = "volume" + RandomStringUtils.secure().nextNumeric(5);
- String bucketName = "volume" + RandomStringUtils.secure().nextNumeric(5);
+ String volumeName = uniqueObjectName("volume");
+ String bucketName = uniqueObjectName("volume");


Incorrect bucket prefix -
Suggested change
StringbucketName = uniqueObjectName("volume");
StringbucketName = uniqueObjectName("bucket");

adoroszlai · 2026-07-15T15:05:38Z

Thanks @prathmesh12-coder for the patch, @sarvekshayr for the review.

* master: (53 commits) HDDS-15876. Remove ozone-csi (apache#10780) HDDS-15508. Add 2.2.0 to compatibility/upgrade test (apache#10782) HDDS-15867. [JDK25] Bump byte-buddy to 1.18.11 (apache#10776) HDDS-15809. Validate x-amz-copy-source-range on UploadPartCopy (apache#10711). HDDS-15678. OFS isDirectory/isFile should not trigger pipeline refresh or return block locations (apache#10741) HDDS-15171. Add available space check on follower during bootstrap. (apache#10185) HDDS-14043. Fix ls -e UnsupportedOperationException on ofs/o3fs (apache#10209) HDDS-15709. Replace random name suffix with uniqueObjectName (apache#10773) HDDS-15849. Force channel shutdown in XceiverClientGrpc.close (apache#10747) HDDS-15765. Fail fast when --node-id is omitted for OM compact/defrag on an HA cluster (apache#10699) HDDS-14989. Delay follower SCM DN server start until Ratis log catch-up. (apache#10617). HDDS-15456. Add SCM DB lookup and identify orphan(wrt SCM) and deleted-but-present containers (apache#10547) HDDS-15812. Rename test utils for naming convention (apache#10766) HDDS-15600. Fix ListObjects response for encoding-type and empty delimiter (apache#10586). HDDS-15656. Fix non-atomic data size accumulation in ContainerBalancer move callback (apache#10708) HDDS-15667. `containerbalancer status`: show stop reason and iteration details after stop (apache#10681) HDDS-15823. Fix flaky TestFailureHandlingByClient#testContainerExclusionWithClosedContainerException (apache#10721) HDDS-15837. Add health-aware container ID listing in SCM (apache#10736) HDDS-15851. Return 403 for expired or out-of-range pre-signed S3 URLs (apache#10749) HDDS-15836. Add Archiver.appendFile for incremental TAR writes (apache#10735) ... Conflicts: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeMetrics.java hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/RepeatedOmKeyInfo.java hadoop-ozone/dist/src/main/compose/upgrade/test.sh hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/HddsUpgradeTestUtils.java hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/TestDNDataDistributionFinalization.java hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/TestHDDSUpgrade.java hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/TestScmDataDistributionFinalization.java hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/TestScmHAFinalization.java hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/service/TestBlockDeletionService.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java

* HDDS-14496-zdu: (56 commits) HDDS-15848. Add new upgrade action annotations for component versions (apache#10744) HDDS-15876. Remove ozone-csi (apache#10780) HDDS-14825. Add Grafana Dashboard and Metrics for ZDU (apache#10602) HDDS-15508. Add 2.2.0 to compatibility/upgrade test (apache#10782) HDDS-15867. [JDK25] Bump byte-buddy to 1.18.11 (apache#10776) HDDS-15809. Validate x-amz-copy-source-range on UploadPartCopy (apache#10711). HDDS-15678. OFS isDirectory/isFile should not trigger pipeline refresh or return block locations (apache#10741) HDDS-15171. Add available space check on follower during bootstrap. (apache#10185) HDDS-14043. Fix ls -e UnsupportedOperationException on ofs/o3fs (apache#10209) HDDS-15709. Replace random name suffix with uniqueObjectName (apache#10773) HDDS-15677. Update client side version checks to use `isSupportedBy`. (apache#10611) HDDS-15849. Force channel shutdown in XceiverClientGrpc.close (apache#10747) HDDS-15765. Fail fast when --node-id is omitted for OM compact/defrag on an HA cluster (apache#10699) HDDS-14989. Delay follower SCM DN server start until Ratis log catch-up. (apache#10617). HDDS-15456. Add SCM DB lookup and identify orphan(wrt SCM) and deleted-but-present containers (apache#10547) HDDS-15812. Rename test utils for naming convention (apache#10766) HDDS-15600. Fix ListObjects response for encoding-type and empty delimiter (apache#10586). HDDS-15656. Fix non-atomic data size accumulation in ContainerBalancer move callback (apache#10708) HDDS-15667. `containerbalancer status`: show stop reason and iteration details after stop (apache#10681) HDDS-15823. Fix flaky TestFailureHandlingByClient#testContainerExclusionWithClosedContainerException (apache#10721) ... Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerPrepare.java

…ation * HDDS-14496-zdu: (57 commits) HDDS-14687. Add test that OM can finalize from a snapshot (apache#10832) HDDS-14580. Remove OM Prepare for Upgrade Code for ZDU (apache#9723) HDDS-15848. Add new upgrade action annotations for component versions (apache#10744) HDDS-15876. Remove ozone-csi (apache#10780) HDDS-14825. Add Grafana Dashboard and Metrics for ZDU (apache#10602) HDDS-15508. Add 2.2.0 to compatibility/upgrade test (apache#10782) HDDS-15867. [JDK25] Bump byte-buddy to 1.18.11 (apache#10776) HDDS-15809. Validate x-amz-copy-source-range on UploadPartCopy (apache#10711). HDDS-15678. OFS isDirectory/isFile should not trigger pipeline refresh or return block locations (apache#10741) HDDS-15171. Add available space check on follower during bootstrap. (apache#10185) HDDS-14043. Fix ls -e UnsupportedOperationException on ofs/o3fs (apache#10209) HDDS-15709. Replace random name suffix with uniqueObjectName (apache#10773) HDDS-15849. Force channel shutdown in XceiverClientGrpc.close (apache#10747) HDDS-15765. Fail fast when --node-id is omitted for OM compact/defrag on an HA cluster (apache#10699) HDDS-14989. Delay follower SCM DN server start until Ratis log catch-up. (apache#10617). HDDS-15456. Add SCM DB lookup and identify orphan(wrt SCM) and deleted-but-present containers (apache#10547) HDDS-15812. Rename test utils for naming convention (apache#10766) HDDS-15600. Fix ListObjects response for encoding-type and empty delimiter (apache#10586). HDDS-15656. Fix non-atomic data size accumulation in ContainerBalancer move callback (apache#10708) HDDS-15667. `containerbalancer status`: show stop reason and iteration details after stop (apache#10681) ... Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMUpgradeFinalization.java hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto

…dation * HDDS-14496-zdu: (62 commits) HDDS-15875. OM should validate software versions of peers before accepting finalize command (apache#10777) HDDS-15417. Handle mixed datanode versions on the replication path (apache#10570) HDDS-15716. Replace layout version protos with new version-named protos in the DN–SCM protocol (apache#10817) HDDS-15715. Add helpful CLI flags to finalization CLIs (apache#10678) HDDS-14687. Add test that OM can finalize from a snapshot (apache#10832) HDDS-14580. Remove OM Prepare for Upgrade Code for ZDU (apache#9723) HDDS-15848. Add new upgrade action annotations for component versions (apache#10744) HDDS-15876. Remove ozone-csi (apache#10780) HDDS-14825. Add Grafana Dashboard and Metrics for ZDU (apache#10602) HDDS-15508. Add 2.2.0 to compatibility/upgrade test (apache#10782) HDDS-15867. [JDK25] Bump byte-buddy to 1.18.11 (apache#10776) HDDS-15809. Validate x-amz-copy-source-range on UploadPartCopy (apache#10711). HDDS-15678. OFS isDirectory/isFile should not trigger pipeline refresh or return block locations (apache#10741) HDDS-15171. Add available space check on follower during bootstrap. (apache#10185) HDDS-14043. Fix ls -e UnsupportedOperationException on ofs/o3fs (apache#10209) HDDS-15709. Replace random name suffix with uniqueObjectName (apache#10773) HDDS-15677. Update client side version checks to use `isSupportedBy`. (apache#10611) HDDS-15849. Force channel shutdown in XceiverClientGrpc.close (apache#10747) HDDS-15765. Fail fast when --node-id is omitted for OM compact/defrag on an HA cluster (apache#10699) HDDS-14989. Delay follower SCM DN server start until Ratis log catch-up. (apache#10617). ... Conflicts: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeManager.java

prathmesh12-coder added 2 commits July 14, 2026 18:35

HDDS-15709. Fixed CI: revert testGetFileStatus to nextNumeric(5)
e8f653a

sarvekshayr reviewed Jul 15, 2026
View reviewed changes

Merge remote-tracking branch 'upstream/master' into HDDS-15709
5c73652
# Conflicts: # hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestAddRemoveOzoneManager.java

sarvekshayr reviewed Jul 15, 2026
View reviewed changes

sarvekshayr requested a review from adoroszlai July 15, 2026 07:44

prathmesh12-coder added 2 commits July 15, 2026 14:34

HDDS-15709. Fixed import order in TestAddRemoveOzoneManager
93e6472

HDDS-15709. Fixed bucket prefix
2f83c31

adoroszlai approved these changes Jul 15, 2026
View reviewed changes

adoroszlai changed the title ~~HDDS-15709. Use uniqueObjectName for object names in integration tests to avoid intermittent BUCKET_ALREADY_EXISTS~~HDDS-15709. Replace random name suffix with uniqueObjectNameJul 15, 2026

adoroszlai added the test label Jul 15, 2026

adoroszlai merged commit 398709d into apache:masterJul 15, 2026
32 checks passed

Navigation Menu

Uh oh!

HDDS-15709. Replace random name suffix with uniqueObjectName - #10773

HDDS-15709. Replace random name suffix with uniqueObjectName#10773
adoroszlai merged 5 commits into
apache:masterfrom
prathmesh12-coder:HDDS-15709

prathmesh12-coder commented Jul 15, 2026•
edited
Loading

Uh oh!

sarvekshayr left a comment

Uh oh!

sarvekshayr left a comment

Uh oh!

sarvekshayrJul 15, 2026

Uh oh!

prathmesh12-coderJul 15, 2026

Uh oh!

prathmesh12-coderJul 15, 2026

Uh oh!

sarvekshayrJul 15, 2026

Uh oh!

Uh oh!

adoroszlai commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	StringbucketName = uniqueObjectName("volume");
	StringbucketName = uniqueObjectName("bucket");

Uh oh!

Conversation

prathmesh12-coder commented Jul 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

sarvekshayr left a comment

Choose a reason for hiding this comment

Uh oh!

sarvekshayr left a comment

Choose a reason for hiding this comment

Uh oh!

sarvekshayrJul 15, 2026

Choose a reason for hiding this comment

Uh oh!

prathmesh12-coderJul 15, 2026

Choose a reason for hiding this comment

Uh oh!

prathmesh12-coderJul 15, 2026

Choose a reason for hiding this comment

Uh oh!

sarvekshayrJul 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adoroszlai commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

prathmesh12-coder commented Jul 15, 2026•
edited
Loading