Skip to content

HDDS-15935. Extract ExportFileManager and document container export directory layout - #10866

Merged
szetszwo merged 7 commits into
apache:masterfrom
sarvekshayr:export-tool-5
Aug 1, 2026
Merged

HDDS-15935. Extract ExportFileManager and document container export directory layout#10866
szetszwo merged 7 commits into
apache:masterfrom
sarvekshayr:export-tool-5

Conversation

@sarvekshayr

@sarvekshayrsarvekshayr commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • Document on-disk export layout under {scm.db.dirs}/exports.
  • Centralize markers, TAR paths, startup orphan cleanup, failure cleanup in ExportFileManager

Part 3 in splitting HDDS-15496#10673 container ID export.

#10813 will rebase to delegate file operations here after this merges.

What is the link to the Apache JIRA

HDDS-15935

How was this patch tested?

Added tests in TestExportFileManager.

@sarvekshayr
sarvekshayr marked this pull request as ready for review July 25, 2026 12:27
szetszwo
szetszwo reviewed Jul 26, 2026
View reviewed changes

@szetszwoszetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarvekshayr , thanks for working on this! Got some questions/suggestions on the layout. Will review the code once the layout has been fixed.

Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
szetszwo
szetszwo reviewed Jul 27, 2026
View reviewed changes

@szetszwoszetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarvekshayr , thanks for the update! Please see the comments inlined.

Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
szetszwo
szetszwo reviewed Jul 29, 2026
View reviewed changes

@szetszwoszetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarvekshayr , thanks for the update! Please see the comments inlined.

Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
szetszwo
szetszwo reviewed Jul 31, 2026
View reviewed changes

@szetszwoszetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarvekshayr , Thanks for the update! Please see the comments inlined.

Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
Comment thread...p-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportScope.java Outdated
szetszwo
szetszwo reviewed Aug 1, 2026
View reviewed changes

@szetszwoszetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarvekshayr , thanks for the update! Just found one more comment inlined.

Comment thread.../server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/export/ExportFileManager.java Outdated
szetszwo
szetszwo approved these changes Aug 1, 2026
View reviewed changes

@szetszwoszetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo
szetszwo merged commit 3a18da7 into apache:masterAug 1, 2026
88 of 89 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szetszwoszetszwoszetszwo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarvekshayr@szetszwo