Uh oh!
There was an error while loading. Please reload this page.
HDDS-16024. Make OM and SCM proto finalization status an enum - #10902
Merged
errose28 merged 3 commits intoAug 3, 2026
Conversation
errose28
marked this pull request as ready for review
July 31, 2026 00:40
dombizita
left a comment
Contributor
There was a problem hiding this comment.
Thanks Ethan, overall it looks good to me, I just have two questions about the possibilities of the statuses.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dombizita
approved these changes
Aug 1, 2026
dombizita
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the comments in the code, looks good to me!
Uh oh!
There was an error while loading. Please reload this page.
errose28 added a commit
to errose28/ozone
that referenced
this pull request
Aug 3, 2026
…dation * HDDS-14496-zdu: HDDS-16024. Make OM and SCM proto finalization status an enum (apache#10902) HDDS-14754. Add ZDU upgrade action to clean up leftover state (apache#10889) HDDS-16023. Create OM request versioning annotations compatible with new versioning framework (apache#10903) Conflicts: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/server/TestSCMClientProtocolServer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use enum instead of boolean to indicate finalization status from SCM and OM to Clients. This allows us to use a more descriptive "in progress" state when only some datanodes are finalized and OM is waiting. It also allows more states to be added in the future if needed.
What is the link to the Apache JIRA
HDDS-16024
How was this patch tested?