Uh oh!
There was an error while loading. Please reload this page.
HDDS-14753. Do not prematurely serialize client version - #10936
Merged
errose28 merged 3 commits intoAug 13, 2026
Merged
Conversation
errose28
commented
Aug 4, 2026
ContributorAuthor
cc @octachoron |
errose28
marked this pull request as ready for review
August 4, 2026 17:51
…changes * HDDS-14496-zdu: HDDS-15885. SCM should validate software versions of peers before accepting finalize command (apache#10783) HDDS-15641. SCM should send write pipeline version with DatanodeDetails on block allocation (apache#10878)
errose28
commented
Aug 11, 2026
ContributorAuthor
Resolved the merge conflicts and did some minor cleanup on top. @dombizita PTAL. |
dombizita
approved these changes
Aug 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
errose28 added a commit
to errose28/ozone
that referenced
this pull request
Aug 13, 2026
* HDDS-14496-zdu: HDDS-14753. Do not prematurely serialize client version (apache#10936) HDDS-15885. SCM should validate software versions of peers before accepting finalize command (apache#10783) HDDS-15641. SCM should send write pipeline version with DatanodeDetails on block allocation (apache#10878) Conflicts: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/protocol/TestDatanodeDetails.java hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocolServerSideTranslatorPB.java hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockDataStreamOutput.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMRecoverLeaseRequest.java
errose28 added a commit
to errose28/ozone
that referenced
this pull request
Aug 17, 2026
* HDDS-14496-zdu: HDDS-16153. DatanodeDetails should use HDDSVersion instead of int (apache#10994) HDDS-15549. Recon's INITIAL_VERSION should not have an upgrade action (apache#10935) HDDS-14753. Do not prematurely serialize client version (apache#10936) HDDS-15885. SCM should validate software versions of peers before accepting finalize command (apache#10783) HDDS-15641. SCM should send write pipeline version with DatanodeDetails on block allocation (apache#10878) Conflicts: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/protocol/TestDatanodeDetails.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocolServerSideTranslatorPB.java hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockDataStreamOutput.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMRecoverLeaseRequest.java
errose28 added a commit
to errose28/ozone
that referenced
this pull request
Aug 21, 2026
* HDDS-14496-zdu: HDDS-16154. Datanode should assign DatanodeDetails#currentVersion based on its apparent version (apache#11006) HDDS-16153. DatanodeDetails should use HDDSVersion instead of int (apache#10994) HDDS-15549. Recon's INITIAL_VERSION should not have an upgrade action (apache#10935) HDDS-14753. Do not prematurely serialize client version (apache#10936) HDDS-15885. SCM should validate software versions of peers before accepting finalize command (apache#10783) HDDS-15641. SCM should send write pipeline version with DatanodeDetails on block allocation (apache#10878)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the new versioning framework, the
ClientVersionclass should be used within the java code, and only delegate toClientVersion#serialize/deserializeat the translation layers of the client and server. This PR updates existing usage ofClientVersionto follow this practice. The main change was in the protobuf translators forDatanodeDetails, which now take aClientVersionand callserializesince those methods are already in charge of serialization. This creates a ripple effect to classes that useDatanodeDetailswhich have been updated to pass it aClientVersioninstead of serializing the version themselves before passing it in.Many files were touched, but it is a simple substitution that does not amount in a large number of lines changed.
What is the link to the Apache JIRA
HDDS-14753
How was this patch tested?
No functional change. All existing tests should pass. Changes do not affect protobuf/disk/wire protocols