HDDS-2321. Ozone Block Token verify should not apply to all datanode …

[xiaoyuyao]

What changes were proposed in this pull request?

• Change the TokenVerifier interface to check the command type and the block id.
• Token verification based on token encode in the command done inside HddsDispatcher.
• Remove the Grpc Client/Server CredentialInterceptor as it cannot fit into Ratis commands.
• Added more unit test coverage on the Tokenverifier.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2321

How was this patch tested?

Added Unit test testBlockTokenVerifier()
Update Unit test in TestSecureContainerServer.java
ozone secure smoke test.

[xiaoyuyao]

/retest

[anuengineer]

I am +1, on this patch. Some minor comments in on this version.

[adoroszlai]

This fixes ozonesecure acceptance test, which has been consistently failing on master recently. Big thanks @xiaoyuyao for that.

Note that there are some CI issues introduced by this change:

• Failure of TestSecureContainerServer looks related.
• There are some checkstyle issues.

[xiaoyuyao]

Thanks @adoroszlai and @anuengineer for the review. The unit test and checkstyle issues are fixed.

[xiaoyuyao]

/retest

[adoroszlai]

/retest

[adoroszlai]

Thanks @xiaoyuyao for the update.

Acceptance test failure is unrelated, it happens on master, too. Details: #11 (comment)

Integration test failure is also unrelated, already tracked in Jira (HDDS-2367 and HDDS-2392).

[xiaoyuyao]

Thanks @adoroszlai for the confirmation. I will merge the PR shortly.