Skip to content

HDDS-4051. Remove whitelist/blacklist terminology from Ozone - #1306

Merged
vivekratnavel merged 2 commits into
apache:masterfrom
vivekratnavel:HDDS-4051
Aug 10, 2020
Merged

HDDS-4051. Remove whitelist/blacklist terminology from Ozone#1306
vivekratnavel merged 2 commits into
apache:masterfrom
vivekratnavel:HDDS-4051

Conversation

@vivekratnavel

@vivekratnavelvivekratnavel commented Aug 9, 2020

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • Replace whitelist/blacklist with allowlist/blocklist

There are still some occurrences of these terminologies in javascript frameworks like bootstrap and angular. Hopefully, these frameworks will update these terminologies in their future releases.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4051

How was this patch tested?

No test is needed.

adoroszlai
adoroszlai reviewed Aug 9, 2020
View reviewed changes

@adoroszlaiadoroszlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vivekratnavel for working on this. I think "blocklist" might be confusing, since "block" is an already existing concept in Ozone. I propose "ignore" instead.

Comment thread...p-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java Outdated
Comment thread...p-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java Outdated
Comment thread...p-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java Outdated
Comment thread...one/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestReconTaskControllerImpl.java Outdated
Comment thread...one/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestReconTaskControllerImpl.java Outdated
Comment thread...p-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java Outdated
Comment thread...p-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java Outdated
@amaliujia

amaliujia commented Aug 9, 2020

Copy link
Copy Markdown
Contributor

+1 on the ignore/ignorelist proposal

@vivekratnavel@adoroszlai
Apply suggestions from code review
bc00022
Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
@adoroszlai

adoroszlai commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @vivekratnavel for updating the patch, LGTM.

avijayanhwx
avijayanhwx approved these changes Aug 10, 2020
View reviewed changes

@avijayanhwxavijayanhwx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @vivekratnavel.

@vivekratnavel
vivekratnavel merged commit d418f00 into apache:masterAug 10, 2020
@vivekratnavel

vivekratnavel commented Aug 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reviews @adoroszlai@avijayanhwx@amaliujia !

errose28 added a commit to errose28/ozone that referenced this pull request Aug 12, 2020
@errose28
Merge branch 'master' into HDDS-3869
2de4e70
* master: (28 commits)
HDDS-4037. Incorrect container numberOfKeys and usedBytes in SCM after key deletion (apache#1295)
HDDS-3232. Include the byteman scripts in the distribution tar file (apache#1309)
HDDS-4095. Byteman script to debug HCFS performance (apache#1311)
HDDS-4057. Failed acceptance test missing from bundle (apache#1283)
HDDS-4040. [OFS] BasicRootedOzoneFileSystem to support batchDelete (apache#1286)
HDDS-4061. Pending delete blocks are not always included in #BLOCKCOUNT metadata (apache#1288)
HDDS-4067. Implement toString for OMTransactionInfo (apache#1300)
HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config (apache#1149)
HDDS-3833. Use Pipeline choose policy to choose pipeline from exist pipeline list (apache#1096)
HDDS-3979. Make bufferSize configurable for stream copy (apache#1212)
HDDS-4048. Show more information while SCM version info mismatch (apache#1278)
HDDS-4078. Use HDDS InterfaceAudience/Stability annotations (apache#1302)
HDDS-4034. Add Unit Test for HadoopNestedDirGenerator. (apache#1266)
HDDS-4076. Translate CSI.md into Chinese (apache#1299)
HDDS-4046. Extensible subcommands for CLI applications (apache#1276)
HDDS-4051. Remove whitelist/blacklist terminology from Ozone (apache#1306)
HDDS-4055. Cleanup GitHub workflow (apache#1282)
HDDS-4042. Update documentation for the GA release (apache#1269)
HDDS-4066. Add core-site.xml to intellij configuration (apache#1292)
HDDS-4073. Remove leftover robot.robot (apache#1297)
...
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
@vivekratnavel@rakeshadr
HDDS-4051. Remove whitelist/blacklist terminology from Ozone (apache#…
52aaa21
…1306)
Co-authored-by: Doroszlai, Attila
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adoroszlaiadoroszlaiadoroszlai left review comments
@avijayanhwxavijayanhwxavijayanhwx approved these changes
@swagleswagleAwaiting requested review from swagle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vivekratnavel@amaliujia@adoroszlai@avijayanhwx