Skip to content

HDDS-4117. Normalize Keypath for listKeys. - #1331

Closed
bharatviswa504 wants to merge 8 commits into
apache:masterfrom
bharatviswa504:HDDS-4117
Closed

HDDS-4117. Normalize Keypath for listKeys.#1331
bharatviswa504 wants to merge 8 commits into
apache:masterfrom
bharatviswa504:HDDS-4117

Conversation

@bharatviswa504

@bharatviswa504bharatviswa504 commented Aug 13, 2020

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Normalize Keypath for listKeys.
When ozone.om.enable.filesystem.paths, OM normalizes path, and stores the Keyname in the OM DB KeyTable.

When listKeys uses given keyName(not normalized key path) as prefix and Starkey the list-keys will return an empty results.

Similar to HDDS-4102, we should normalize Starkey and keyPrefix.

Note:
This PR is based on top of #1328
To get CI, posted a PR with both fixes included.
The changes for this commit start from ab0cee5

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4117

How was this patch tested?

Added a test.

@bharatviswa504bharatviswa504 changed the title HDDS-4117. HDDS-4117. Normalize Keypath for listKeys.Aug 13, 2020
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1331 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #1331 +/- ##
============================================
- Coverage 74.41% 74.35% -0.07% - Complexity 10301 10324 +23 
============================================
Files 984 985 +1 Lines 50394 50549 +155 Branches 4914 4937 +23 ============================================
+ Hits 37503 37587 +84 - Misses 10531 10600 +69 - Partials 2360 2362 +2 
Impacted FilesCoverage ΔComplexity Δ
...src/main/java/org/apache/hadoop/ozone/OmUtils.java80.66% <100.00%> (+1.08%)49.00 <3.00> (+3.00)
...ava/org/apache/hadoop/ozone/om/KeyManagerImpl.java65.34% <100.00%> (+0.43%)140.00 <4.00> (+4.00)
...pache/hadoop/ozone/om/request/OMClientRequest.java81.17% <100.00%> (-1.25%)29.00 <1.00> (-2.00)
...hdds/scm/container/common/helpers/ExcludeList.java78.26% <0.00%> (-21.74%)17.00% <0.00%> (-5.00%)
...doop/ozone/om/exceptions/OMNotLeaderException.java48.48% <0.00%> (-18.19%)3.00% <0.00%> (-2.00%)
.../apache/hadoop/hdds/scm/node/StaleNodeHandler.java88.88% <0.00%> (-11.12%)4.00% <0.00%> (ø%)
...e/hadoop/ozone/recon/tasks/OMDBUpdatesHandler.java60.93% <0.00%> (-9.66%)9.00% <0.00%> (-8.00%)
...ache/hadoop/ozone/om/codec/S3SecretValueCodec.java90.90% <0.00%> (-9.10%)3.00% <0.00%> (-1.00%)
...va/org/apache/hadoop/hdds/utils/db/RDBMetrics.java92.85% <0.00%> (-7.15%)14.00% <0.00%> (-1.00%)
...ozone/container/ozoneimpl/ContainerController.java76.31% <0.00%> (-5.27%)13.00% <0.00%> (-1.00%)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c22180...d9bbc1e. Read the comment docs.

@elekelek changed the title HDDS-4117. Normalize Keypath for listKeys.HDDS-4117. Normalize Keypath for listKeys.Aug 25, 2020
@bharatviswa504

Copy link
Copy Markdown
ContributorAuthor

Closing this. Opened #1451 to track this issue.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bharatviswa504@codecov-commenter