Uh oh!
There was an error while loading. Please reload this page.
HDDS-2417 Add the list trash command to the client side - #138
Conversation
adoroszlai
commented
Nov 10, 2019
/retest |
There was a problem hiding this comment.
I think we need to add OMUtils#isReadOnly function. I think we should add this command as a read only command to that function.
The Unit test failure is related to that.
Otherwise the patch looks excellent, and as soon as we fix it I will get it committed. Thanks
There was a problem hiding this comment.
As a future JIRA, I was thinking it might be useful to get just the list of buckets that are deleted. It might be interesting.
dineshchitlangia
left a comment
There was a problem hiding this comment.
+1 LGTM.
Integration failure is unrelated.
Although it says Acceptance finished with failed status, however, I see all tests in acceptance have passed.
dineshchitlangia
commented
Nov 11, 2019
@mbsharp Thank you for the contribution and thanks @anuengineer for the reviews. |
…in Recon UI. (apache#7149) (apache#138) (cherry picked from commit 4b47812) Co-authored-by: Arafat2198 <arafatp126@gmail.com>
What changes were proposed in this pull request?
This is the first commit for a new trash feature for Ozone. This PR tackles adding client side changes to support a list trash command which will show deleted keys from the deleted keys tables.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2417
How was this patch tested?
New tests will be added as this is built out further with the core logic. For the initial changes in this PR, check style and local mvn build passed.