HDDS-4309. Fix inconsistency recon config keys starting with recon and not ozone

[frischHWC]

What changes were proposed in this pull request?

Fix recon configs inconsistent

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4309

How was this patch tested?

Build up project, launch dockers, and new default parameters were present but not old ones anymore.

On recon container:

> ozone getconf confKey recon.om.socket.timeout
Configuration recon.om.socket.timeout is missing.
> ozone getconf confKey ozone.recon.om.socket.timeout
5s

[vivekratnavel]

+1 LGTM

[vivekratnavel]

@frischHWC Thanks for working on this! The patch looks good to me except the failing checkstyles. Please fix those longer lines and I can merge it.

hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServerConfigKeys.java
74: Line is longer than 80 characters (found 86).
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java
128: Line is longer than 80 characters (found 82).
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/PrometheusServiceProviderImpl.java
68: Line is longer than 80 characters (found 84).
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconWithOzoneManager.java
99: Line is longer than 80 characters (found 82).
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java
72: Line is longer than 80 characters (found 82).

[adoroszlai]

Thanks @frischHWC for working on this.

The new key names look good, but if we simply change them, existing clusters would not respect after upgrade any custom value previously configured for these properties. Administrators would have to manually update their configs.

So I think we should keep the constants for the old names, and use them as fallback when looking up the config. For one of them (RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY) I have suggested two changes, which can be applied to all other old config keys.

Note: commit message should include Jira ID (and match Jira title), eg. HDDS-4309. Fix inconsistent Recon config keys that start with "recon.om.". Whoever merges this, please pay attention to prepend Jira ID in commit message.

[adoroszlai]

Suggested change

	OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
	OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_DEFAULT,
	OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
	configuration.get(
	ReconServerConfigKeys.RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY,
	OZONE_RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_DEFAULT),

[adoroszlai]

Thanks @frischHWC for updating the patch. Sorry, I forgot TestOzoneConfigurationFields, a unit test that checks whether properties in ozone-default.xml and the *ConfigKeys classes are in sync. We need to enumerate the deprecated constants in addPropertiesNotInXml, since these are no longer present in the XML.

https://github.com/apache/hadoop-ozone/blob/f9b1ca45fdeaaa63b9355c5c54fafc96ddf4597e/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java#L60-L76

[codecov-io]

Codecov Report

Merging #1478 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1478 +/- ##
=========================================
Coverage 75.49% 75.49% Complexity 10798 10798 =========================================
Files 1021 1021 Lines 52095 52095 Branches 5103 5103 =========================================
Hits 39328 39328 Misses 10321 10321 Partials 2446 2446 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b1ca4...a2bd180. Read the comment docs.

[vivekratnavel]

@adoroszlai Thanks for the review and @frischHWC thanks for the contribution.