HDDS-4296. SCM changes to process Layout Info in heartbeat request/response

[prashantpogde]

What changes were proposed in this pull request?

SCM changes to process Layout Info in heartbeat request/response

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4296

How was this patch tested?

UT. I will fix any CI failure.

[avijayanhwx]

cc @fapifta / @sodonnel Please review.

[linyiqun]

Hi @prashantpogde , some initial review comments from me.
It would be better if you can additionally add corresponding unit test for this PR change.

[avijayanhwx]

Thanks for working on this @prashantpogde. A couple of general comments.

• @fapifta has also introduced states a component can be in, with respect to Upgrade. We should discuss and use just one set of states.

• I am not convinced why we need another report for Layout Version handling. Layout version is like node metadata, and should be sent in every heartbeat. Also, I am not sure if we can handle the LayoutVersion report through an event handler since it is 'async' and there can be delay in handling.

[prashantpogde]

Updated with new set of changes after taking care of all review comments. Please take a look.

[avijayanhwx]

@prashantpogde Patch generally looks good to me. Can we add a unit test for the layout version check during heartbeat processing?

[avijayanhwx]

LGTM +1.

@prashantpogde Are you planning to comment out the other 2 unused variable findbug failures as well?
Can we trigger an empty commit to get acceptance tests(unsecure) to pass?

[prashantpogde]

Failure in TestOzoneManagerHAMetadataOnly is unrelated with the changes.

[avijayanhwx]

Thank you for the patch @prashantpogde and the review @linyiqun.