Skip to content

HDDS-4416. Update README.md after TLP separation - #1540

Merged
dineshchitlangia merged 2 commits into
apache:masterfrom
elek:HDDS-4416
Nov 5, 2020
Merged

HDDS-4416. Update README.md after TLP separation#1540
dineshchitlangia merged 2 commits into
apache:masterfrom
elek:HDDS-4416

Conversation

@elek

@elekelek commented Nov 2, 2020

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Update README.md with the TLP information

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4416

How was this patch tested?

Text only change. 👀

@linyiqunlinyiqun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks for updating this.

@adoroszlaiadoroszlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elek for taking care of this.

Comment threadREADME.md Outdated
Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>

@dineshchitlangiadineshchitlangia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @elek for the changes and others for the review.

@dineshchitlangia
dineshchitlangia merged commit 08151fa into apache:masterNov 5, 2020
@cxorm

cxorm commented Nov 5, 2020

Copy link
Copy Markdown
Member

Hi @elek, thank you for updating this after TLP separation.

Would we change the line 80
cd hadoop-ozone/dist/target/ozone-*/compose/ozone
to
cd ozone/dist/target/ozone-*/compose/ozone ?

I think it is my nit, but, if yes
I propose we could also update the link and add new label on Github About Part : )
Github_AboutPart

@elek

elek commented Nov 16, 2020

Copy link
Copy Markdown
MemberAuthor

Good findings @cxorm. Let me create a follow-up PR.

@elek

elek commented Nov 16, 2020

Copy link
Copy Markdown
MemberAuthor

Would we change the line 80 cd hadoop-ozone/dist/target/ozone-*/compose/ozone to cd ozone/dist/target/ozone-*/compose/ozone ?

Project names are not (yet) changed. It's a bigger task:

  1. we can rename those hadoop- prefixes from the dir
  2. we can change package names
  3. we can update pom.xml descriptions.

But these are bigger tasks (imho)...

@cxorm

Copy link
Copy Markdown
Member

Good findings @cxorm. Let me create a follow-up PR.

Thank you @elek for the task : )

Project names are not (yet) changed. It's a bigger task:

  1. we can rename those hadoop- prefixes from the dir
  2. we can change package names
  3. we can update pom.xml descriptions.

But these are bigger tasks (imho)...

Yeah, thanks for the clarification, I also agree with it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@elek@cxorm@adoroszlai@dineshchitlangia@linyiqun