Skip to content

HDDS-4358: Delete : make delete an atomic operation - #1607

Merged
rakeshadr merged 7 commits into
apache:HDDS-2939from
rakeshadr:HDDS-4358
Dec 7, 2020
Merged

HDDS-4358: Delete : make delete an atomic operation#1607
rakeshadr merged 7 commits into
apache:HDDS-2939from
rakeshadr:HDDS-4358

Conversation

@rakeshadr

@rakeshadrrakeshadr commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This task handles directory and file deletions. This won't cleanup the garbage and orphans which will be implemented in another jira.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4358

How was this patch tested?

TestOzoneFileSystemV1 suite

bharatviswa504
bharatviswa504 reviewed Nov 24, 2020
View reviewed changes

@bharatviswa504bharatviswa504 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You @rakeshadr for the PR.
Few comments inline.

Comment threadhadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java Outdated
Comment thread...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequestV1.java Outdated
Comment thread...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequestV1.java
Comment thread...one-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyDeleteResponseV1.java Outdated
Comment thread...p-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemV1.java
Comment threadhadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
@bharatviswa504

bharatviswa504 commented Nov 24, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

And also as discussed offline from S3G interface/Shell
Recursive=false should be default for key/directory deletion and the directory key can only be deleted when the directory is empty. (Currently, when fs path enabled directory deletion says KeynotFound, this will fix that behavior)

@rakeshadr

rakeshadr commented Dec 3, 2020

Copy link
Copy Markdown
ContributorAuthor

@bharatviswa504 updated patch by addressing your comments. Please let me know your feedback. Thanks!

linyiqun
linyiqun reviewed Dec 4, 2020
View reviewed changes

@linyiqunlinyiqun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest PR almost looks good. Please have a look for my minor comments below, @rakeshadr .

Comment thread...ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
Comment thread...ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
@linyiqunlinyiqun mentioned this pull request Dec 4, 2020
Closed
linyiqun
linyiqun approved these changes Dec 6, 2020
View reviewed changes

@linyiqunlinyiqun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks for addressing the comments, @rakeshadr .

@rakeshadr

rakeshadr commented Dec 7, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thanks @linyiqun and @bharatviswa504 for the useful review comments.

I'll merge this shortly.

@rakeshadr
rakeshadr merged this pull request into apache:HDDS-2939Dec 7, 2020
rakeshadr added a commit that referenced this pull request Dec 7, 2020
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
2611af0
@bharatviswa504bharatviswa504 mentioned this pull request Dec 8, 2020
Merged
rakeshadr added a commit that referenced this pull request Jan 6, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
6481a55
rakeshadr added a commit that referenced this pull request Jan 11, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
031e666
rakeshadr added a commit that referenced this pull request Jan 13, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
eb84c94
rakeshadr added a commit that referenced this pull request Jan 25, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
2433e01
rakeshadr added a commit that referenced this pull request Jan 28, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
2750478
rakeshadr added a commit that referenced this pull request Feb 1, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
ebadc58
rakeshadr added a commit that referenced this pull request Feb 1, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
2f2df59
rakeshadr added a commit that referenced this pull request Feb 3, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
d199b2e
rakeshadr added a commit that referenced this pull request Feb 5, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
9b9298a
rakeshadr added a commit that referenced this pull request Feb 15, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
b9ceda9
rakeshadr added a commit that referenced this pull request Feb 18, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
0a12595
rakeshadr added a commit that referenced this pull request Feb 25, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
0cae5cc
rakeshadr added a commit that referenced this pull request Mar 3, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
82ebae0
rakeshadr added a commit that referenced this pull request Mar 9, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
5888a46
rakeshadr added a commit that referenced this pull request Mar 27, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
602119f
rakeshadr added a commit that referenced this pull request Apr 7, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
4295d4e
rakeshadr added a commit that referenced this pull request Apr 8, 2021
@rakeshadr
HDDS-4358: Delete : make delete an atomic operation (#1607)
995b3bd
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharatviswa504bharatviswa504bharatviswa504 left review comments
+1 more reviewer
@linyiqunlinyiqunlinyiqun approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rakeshadr@bharatviswa504@linyiqun