Uh oh!
There was an error while loading. Please reload this page.
HDDS-4746. Fix delete container occurs unknown command type. - #1845
HDDS-4746. Fix delete container occurs unknown command type.#1845captainzmc wants to merge 1 commit into
Conversation
Thanks for working on this @captainzmc. Can we find out why and in which JIRA this command was removed? |
adoroszlai
commented
Jan 26, 2021
captainzmc
commented
Jan 26, 2021
hi @avijayanhwx This interface is not removed, this interface didn't work properly from the beginning. |
captainzmc
commented
Jan 26, 2021
@adoroszlai Thanks for the reminding. I will confirm the current status of #389. |
captainzmc
commented
Jan 26, 2021
Hi @maobaolong, Are you currently working on fixing #389? If not, I hope to take this Task, because we will use this interface. |
maobaolong
commented
Jan 26, 2021
@captainzmc Sure, please feel free to take it, hope you can finish this. |
By looking at the issues mentioned in #214 and #389, I found that in #1338(this PR is used to remove empty containers) these issues were well addressed and explained, by fixed ContainerReportHandler. |
We use this feature because HDDS-4334 relies on it. Now #1338 has implemented the remove all empty containers. So we can delete all the files through OFS, and the empty container will be deleted automatically. So we don't think it's necessary anymore, I'm going to turn off the PR. |
What changes were proposed in this pull request?
An exception "Unknown command type: DeleteContainer" occurs when we delete a container. This is a bug that needs to be fixed.

In fact, this part of the interface backend is already implemented, just not called.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4746
How was this patch tested?
UT added