Uh oh!
There was an error while loading. Please reload this page.
HDDS-5209. Datanode hasEnoughSpace check should apply on volume instead of global DN - #2246
Conversation
guihecheng
commented
May 13, 2021
Hi @ChenSammi please help review this one, I'll check the CI failures, not related at first glance, thanks~ |
ChenSammi
commented
May 13, 2021
Hi @guihecheng , we have leverage the DatanodeInfo value. It seems there is no need to add new API in NodeManager. You can refer to these piece of codes, final DatanodeInfo datanodeInfo = nodeStateManager |
guihecheng
commented
May 13, 2021
@ChenSammi ah, then I shall put the logic directly into hasEnoughSpace and avoid adding a new API, thanks~ |
a9fc6b3 to
d9299c5Compare@ChenSammi updated, thanks~ |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ChenSammi
commented
May 19, 2021
+1. Thanks @guihecheng for the contribution. |
What changes were proposed in this pull request?
When use placement policy to choose datanodes, we should check whether a datanode has a volume that
has enough space to hold the container, not check the space from all volumes together, because a container
could only be on a single volume not spread across volumes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5209
How was this patch tested?
extended existing ut.