Skip to content

HDDS-5206. Addendum: Support revoking S3 secret - #2270

Merged
smengcl merged 4 commits into
apache:masterfrom
smengcl:HDDS-5206-addendum
May 24, 2021
Merged

HDDS-5206. Addendum: Support revoking S3 secret#2270
smengcl merged 4 commits into
apache:masterfrom
smengcl:HDDS-5206-addendum

Conversation

@smengcl

Copy link
Copy Markdown
Contributor

This is an addendum to #2239 .

Fixes the typo which wasn't caught in the previous review for s3 getsecret / revokesecret admin permission check.

Change-Id: Id589dd30789fd49199f54bb2b472d024140fb48c

@adoroszlaiadoroszlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smengcl for updating the patch, LGTM.

@smengcl

Copy link
Copy Markdown
ContributorAuthor

Thank you @adoroszlai for reviewing.

@smengcl
smengcl merged commit e00fa80 into apache:masterMay 24, 2021
bharatviswa504 pushed a commit to bharatviswa504/hadoop-ozone that referenced this pull request Jul 25, 2021
(cherry picked from commit e00fa80)
Change-Id: I6c56a001f5d34dc9933e8db81f5b61c3e6f4a190
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@smengcl@adoroszlai