Uh oh!
There was an error while loading. Please reload this page.
HDDS-6440. Handle custom metadata (x-amz-meta) during put-object through S3 API. - #3728
Conversation
…nt/OzoneKey.java Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
…e into HDDS-6440-master
DaveTeng0
commented
Aug 29, 2022
cc. kerneltime, adoroszlai |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…s key filtering logic;create s3 request metadata size limit constant
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…nd gdpr enabled tag
DaveTeng0
commented
Sep 14, 2022
Uh oh!
There was an error while loading. Please reload this page.
| this.replicationConfig = ReplicationConfig.fromTypeAndFactor(type, | ||
| ReplicationFactor.valueOf(replicationFactor)); | ||
| this(volumeName, bucketName, keyName, size, creationTime, modificationTime, | ||
| ReplicationConfig.fromTypeAndFactor(type, |
There was a problem hiding this comment.
Setting the instance this(creationTime, modificationTime ) can remain initialized with Instant.ofEpochMilli(creationTime) and Instant.ofEpochMilli(modificationTime) respectively.
There was a problem hiding this comment.
@neils-dev can you please explain, I am not sure I understood your comment.
There was a problem hiding this comment.
Sure @kerneltime, the intialization for the creationTime, modification can retain its previous initialization prior to the change:
previous:
this.creationTime = Instant.ofEpochMilli(creationTime);
this.modificationTime = Instant.ofEpochMilli(modificationTime);
now:
line 73,this(volumeName, bucketName, keyName, size, Instant.ofEpochMilli(creationTime), Instant.ofEpochMilli(modificationTime), ...)
There was a problem hiding this comment.
The constructor called internally does the same, right?
Uh oh!
There was an error while loading. Please reload this page.
What changes were proposed in this pull request?
Handle user defined metadata supplied through the s3 interface.
Reference - https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingObjects.html
(This PR is a fork from #3200, with updates from latest master branch and resolve conflicts if there is any.)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6440
How was this patch tested?
Manually tested put, head and copy object.
Added acceptance tests.