Skip to content

HDDS-8304. [Snapshot] Reduce flakiness in testSkipTrackingWithZeroSnapshot - #4487

Merged
smengcl merged 1 commit into
apache:masterfrom
smengcl:HDDS-8304
Apr 4, 2023
Merged

HDDS-8304. [Snapshot] Reduce flakiness in testSkipTrackingWithZeroSnapshot#4487
smengcl merged 1 commit into
apache:masterfrom
smengcl:HDDS-8304

Conversation

@smengcl

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • #testSkipTrackingWithZeroSnapshot fails occasionally presumably because the compaction log directory isn't created yet.

e.g. https://github.com/apache/ozone/actions/runs/4540058938/jobs/8001489891?pr=3980

Error: Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 52.179 s <<< FAILURE! - in org.apache.hadoop.ozone.freon.TestOMSnapshotDAG
Error: org.apache.hadoop.ozone.freon.TestOMSnapshotDAG.testSkipTrackingWithZeroSnapshot Time elapsed: 11.135 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: not <null>
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
at org.junit.jupiter.api.Assertions.fail(Assertions.java:134)
at org.junit.jupiter.api.AssertNotNull.failNull(AssertNotNull.java:47)
at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:36)
at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:31)
at org.junit.jupiter.api.Assertions.assertNotNull(Assertions.java:300)
at org.apache.hadoop.ozone.freon.TestOMSnapshotDAG.testSkipTrackingWithZeroSnapshot(TestOMSnapshotDAG.java:307)

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8304

How was this patch tested?

  • Modified test itself.

…pshot
Change-Id: I601a191ca6ee10686637337d64fb892b189fd7c9
@smengclsmengcl added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Mar 28, 2023

@prashantpogdeprashantpogde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smengcl

Copy link
Copy Markdown
ContributorAuthor

Thanks @prashantpogde for the review.

@smengcl
smengcl merged commit 40e6875 into apache:masterApr 4, 2023
@smengcl
smengcl deleted the HDDS-8304 branch April 4, 2023 20:39
errose28 added a commit to errose28/ozone that referenced this pull request Apr 6, 2023
* master: (155 commits)
update readme (apache#4535)
HDDS-8374. Disable flaky unit test: TestContainerStateCounts
HDDS-8016. updated the ozone doc for linked bucket and deletion async limitation (apache#4526)
HDDS-8237. [Snapshot] loadDb() used by SstFiltering service creates extraneous directories. (apache#4446)
HDDS-8035. Intermittent timeout in TestOzoneManagerHAWithData.testOMHAMetrics (apache#4362)
HDDS-8039. Allow container inspector to run from ozone debug. (apache#4337)
HDDS-8304. [Snapshot] Reduce flakiness in testSkipTrackingWithZeroSnapshot (apache#4487)
HDDS-7974. [Snapshot] KeyDeletingService to be aware of Ozone snapshots (apache#4486)
HDDS-8368. ReplicationManager: Create ContainerReplicaOp with correct target Datanode (apache#4532)
HDDS-8358. Fix the space usage comparator in ContainerBalancerSelectionCriteria (apache#4527)
HDDS-8359. ReplicationManager: Fix getContainerReplicationHealth() so that it builds ContainerCheckRequest correctly (apache#4528)
HDDS-8361. Useless object in TestOzoneBlockTokenIdentifier (apache#4517)
HDDS-8325. Consolidate and refine RocksDB metrics of services (apache#4506)
HDDS-8135. Incorrect synchronization during certificate renewal in DefaultCertificateClient. (apache#4381)
HDDS-8127. Exclude deleted containers from Recon container count (apache#4440)
HDDS-8364. ReadReplicas may give wrong results with topology-aware read enabled (apache#4522)
HDDS-8354. Avoid WARNING about ObjectEndpoint#get (apache#4515)
HDDS-8324. DN data cache gets removed randomly asking for data from disk (apache#4499)
HDDS-8291. Upgrade to Hadoop 3.3.5 (apache#4484)
HDDS-8355. Mark TestOMRatisSnapshots#testInstallSnapshot as flaky
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshothttps://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@smengcl@prashantpogde