HDDS-8677. Ozone admin OM CLI command for block tokens by tanvipenumudy · Pull Request #4760 · apache/ozone

tanvipenumudy · 2023-05-23T13:39:37Z

What changes were proposed in this pull request?

Introduce an Ozone admin OM CLI command to fetch the current secret key.

Format: ozone admin om fetch-current-key -id=omServiceId

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8677

How was this patch tested?

Added integration test cases.

tanvipenumudy · 2023-05-23T16:44:22Z

@duongkame, @kerneltime, @sadanand48 could you please take a look? Thanks

adoroszlai

Thanks @tanvipenumudy for working on this. (Note: I haven't checked the whole patch, only POM and CLI.)

ashishkumar50

Hi @tanvipenumudy, Thanks for working on this.
Left a small suggestion.

comments have been addressed

adoroszlai · 2023-05-30T09:14:25Z

Thanks @tanvipenumudy for addressing my comments.

…/om/FetchKeySubCommand.java Modify description to CLI command Co-authored-by: Duong Nguyen <duongnt.is@gmail.com>

tanvipenumudy · 2023-06-01T12:37:44Z

Thank you for the reviews, I have addressed the comments on the PR.

The Git CI: integration (ozone) seems to fail at org.apache.hadoop.ozone.TestSecretKeysApi - but the test cases have been passing locally, re-triggering the checks.

duongkame

Thanks for the patch @tanvipenumudy, LGTM.

fix merge upstream.

* master: (73 commits) HDDS-8587. Test that CertificateClient can store multiple rootCA certificates (apache#4852) HDDS-8801. ReplicationManager: Add metric to count how often replication is throttled (apache#4864) HDDS-8477. Unit test for Snapdiff using tombstone entries (apache#4678) HDDS-7507. [Snapshot] Implement List Snapshot API Pagination (apache#4065) (apache#4861) HDDS-8373. Document that setquota doesn't accept decimals (apache#4856) HDDS-8779. Recon - Expose flag for enable/disable of heatmap. (apache#4845) HDDS-8677. Ozone admin OM CLI command for block tokens (apache#4760) HDDS-8164. Authorize secret key APIs (apache#4597) HDDS-7945. Integrate secret keys to SCM snapshot (apache#4549) HDDS-8003. E2E integration test cases for block tokens (apache#4547) HDDS-7831. Use symmetric secret key to sign and verify token (apache#4417) HDDS-7830. SCM API for OM and Datanode to get secret keys (apache#4345) HDDS-7734. Implement symmetric SecretKeys lifescycle management in SCM (apache#4194) HDDS-8679. Add dedicated, configurable thread pool for OM gRPC server (apache#4771) HDDS-8790. Split EC acceptance tests (apache#4855) HDDS-8714. TestScmHAFinalization: mark testFinalizationWithRestart as flaky, enable other test cases HDDS-8787. Reduce ozone sh calls in robot tests (apache#4854) HDDS-8774. Log allocation stack trace for leaked CodecBuffer (apache#4840) HDDS-8729. Add metric for count of blocks pending deletion on datanode (apache#4800) HDDS-8780. Leak of ManagedChannel in HASecurityUtils (apache#4850) ...

* tmp-dir-refactor: (73 commits) HDDS-8587. Test that CertificateClient can store multiple rootCA certificates (apache#4852) HDDS-8801. ReplicationManager: Add metric to count how often replication is throttled (apache#4864) HDDS-8477. Unit test for Snapdiff using tombstone entries (apache#4678) HDDS-7507. [Snapshot] Implement List Snapshot API Pagination (apache#4065) (apache#4861) HDDS-8373. Document that setquota doesn't accept decimals (apache#4856) HDDS-8779. Recon - Expose flag for enable/disable of heatmap. (apache#4845) HDDS-8677. Ozone admin OM CLI command for block tokens (apache#4760) HDDS-8164. Authorize secret key APIs (apache#4597) HDDS-7945. Integrate secret keys to SCM snapshot (apache#4549) HDDS-8003. E2E integration test cases for block tokens (apache#4547) HDDS-7831. Use symmetric secret key to sign and verify token (apache#4417) HDDS-7830. SCM API for OM and Datanode to get secret keys (apache#4345) HDDS-7734. Implement symmetric SecretKeys lifescycle management in SCM (apache#4194) HDDS-8679. Add dedicated, configurable thread pool for OM gRPC server (apache#4771) HDDS-8790. Split EC acceptance tests (apache#4855) HDDS-8714. TestScmHAFinalization: mark testFinalizationWithRestart as flaky, enable other test cases HDDS-8787. Reduce ozone sh calls in robot tests (apache#4854) HDDS-8774. Log allocation stack trace for leaked CodecBuffer (apache#4840) HDDS-8729. Add metric for count of blocks pending deletion on datanode (apache#4800) HDDS-8780. Leak of ManagedChannel in HASecurityUtils (apache#4850) ...

HDDS-8677. Ozone admin OM CLI command for block tokens
92b53bb

Fix basic (findbugs)
3996e7c

duongkame self-requested a review May 24, 2023 05:50

duongkame reviewed May 24, 2023
View reviewed changes

Comment threadhadoop-hdds/framework/pom.xml Outdated
Comment threadhadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java Outdated

adoroszlai previously requested changes May 24, 2023
View reviewed changes

tanvipenumudy added 2 commits May 25, 2023 08:27

Rename CLI
971af3d

Use try-with-resources
e768848

ashishkumar50 reviewed May 25, 2023
View reviewed changes

Comment threadhadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/FetchKeySubCommand.java Outdated

tanvipenumudy added 2 commits May 25, 2023 09:33

Output expiration time as part of command
9bd5790

Simplify patch: avoid importing dependencies
f07031c

duongkame reviewed May 31, 2023
View reviewed changes

Comment threadhadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/om/FetchKeySubCommand.java Outdated

tanvipenumudyand others added 6 commits June 1, 2023 08:02

Update hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin…
0bc81a3
…/om/FetchKeySubCommand.java Modify description to CLI command Co-authored-by: Duong Nguyen <duongnt.is@gmail.com>

Refactor Request/Response names to RefetchSecretKey
3711d8c

fix checkstyle
f80fad9

Move tests to a separate class
b0b3ea7

Implement refetchSecretKey under DefaultSecretKeySignerClient
752bc5a

Modify refetchSecretKey() to return Secret Key ID
d749efa

duongkame approved these changes Jun 2, 2023
View reviewed changes

kerneltime merged this pull request into apache:HDDS-7733-Symmetric-TokensJun 8, 2023

duongkame pushed a commit to duongkame/ozone that referenced this pull request Jun 8, 2023
HDDS-8677. Ozone admin OM CLI command for block tokens (apache#4760)
741dba9
fix merge upstream.

duongkame pushed a commit that referenced this pull request Jun 8, 2023
HDDS-8677. Ozone admin OM CLI command for block tokens (#4760)
7bfa04e

Navigation Menu

Uh oh!

HDDS-8677. Ozone admin OM CLI command for block tokens - #4760

HDDS-8677. Ozone admin OM CLI command for block tokens#4760
kerneltime merged 12 commits into
apache:HDDS-7733-Symmetric-Tokensfrom
tanvipenumudy:HDDS-8677

tanvipenumudy commented May 23, 2023

Uh oh!

tanvipenumudy commented May 23, 2023

Uh oh!

Uh oh!

Uh oh!

adoroszlai left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ashishkumar50 left a comment

Uh oh!

Uh oh!

adoroszlai commented May 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tanvipenumudy commented Jun 1, 2023•
edited
Loading

Uh oh!

duongkame left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

tanvipenumudy commented May 23, 2023

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

tanvipenumudy commented May 23, 2023

Uh oh!

Uh oh!

Uh oh!

adoroszlai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ashishkumar50 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adoroszlai commented May 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tanvipenumudy commented Jun 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

duongkame left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tanvipenumudy commented Jun 1, 2023•
edited
Loading