Skip to content

HDDS-8970. Snapshot Diff should return path relative to bucket root - #5015

Merged
smengcl merged 9 commits into
apache:masterfrom
swamirishi:HDDS-8970
Jul 6, 2023
Merged

HDDS-8970. Snapshot Diff should return path relative to bucket root#5015
smengcl merged 9 commits into
apache:masterfrom
swamirishi:HDDS-8970

Conversation

@swamirishi

@swamirishiswamirishi commented Jul 1, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Snapshot diff currently returns absolute path which breaks distcp on snapdiff changes. Thus should return path relative to bucket root.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8970

How was this patch tested?

Existing UT changes

hemantk-12
hemantk-12 reviewed Jul 1, 2023
View reviewed changes

@hemantk-12hemantk-12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @swamirishi.

Overall looks good to me. Left a comment, please resolve that.

Comment threadhadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java Outdated
@prashantpogdeprashantpogde added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Jul 2, 2023
@adoroszlai

adoroszlai commented Jul 2, 2023

Copy link
Copy Markdown
Contributor

@swamirishi Failures in TestSnapshotDiffManager and TestRootedOzoneFileSystem.testSnapshotDiff seem to be related.

@prashantpogde@swagle Please check CI run in fork (1, 2) before triggering PR run.

smengcl
smengcl reviewed Jul 4, 2023
View reviewed changes
Comment threadhadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java Outdated
smengcl
smengcl reviewed Jul 4, 2023
View reviewed changes
Comment threadhadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java Outdated
smengcl
smengcl reviewed Jul 4, 2023
View reviewed changes
Comment threadhadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java Outdated
smengcl
smengcl reviewed Jul 4, 2023
View reviewed changes
Comment threadhadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java Outdated
smengcl
smengcl approved these changes Jul 6, 2023
View reviewed changes

@smengclsmengcl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swamirishi for the fix. Thanks @hemantk-12 for reviewing this.

@smengcl
smengcl merged commit 7e84609 into apache:masterJul 6, 2023
errose28 added a commit to errose28/ozone that referenced this pull request Jul 10, 2023
@errose28
Merge branch 'master' into HDDS-8062-container-log
46e73d5
* master: (36 commits)
HDDS-8990. Intermittent timeout waiting on datanode4 9856 to become available (apache#5039)
Revert "HDDS-7750. Incorrect WRITE ACL check. (apache#4992)"
HDDS-7750. Incorrect WRITE ACL check. (apache#4992)
HDDS-8985. Intermittent timeout exiting safe mode in HA secure tests (apache#5033)
HDDS-8593. Add RootCARotationPoller to CertClient (apache#5030)
HDDS-7645. Kubernetes check should fail fast if cluster cannot start (apache#5028)
HDDS-8981. TestRootedOzoneFileSystem runs out of disk space (apache#5029)
HDDS-8592. Fetch and save all root certificates during service's certificate rotation. (apache#5025)
HDDS-8981. Disable TestRootedOzoneFileSystem#testSafeMode
HDDS-8591. Create scheduler to check for new root ca certificates (apache#4961)
HDDS-8979. error validating kustomization.yaml (apache#5024)
HDDS-8973. Ozone SCM HA should not allocates duplicate IDs when transferring leadership (apache#5018)
HDDS-8970. Snapshot Diff should return path relative to bucket root (apache#5015)
HDDS-8975. Clarify SCM HA auto-bootstrap doc (apache#5021)
HDDS-8689. Rotate Root CA and Sub CA in SCM. (apache#4943)
HDDS-8436. Support setSafeMode(), isFileClosed() FileSystem API (apache#4825)
HDDS-8880. Intermittent fork timeout in TestOMRatisSnapshots (apache#5022)
HDDS-8962. Ensure docker env is stopped (apache#5011)
HDDS-7794. [snapshot] SnapshotDiff should throw better error messages for exception handling (apache#5007)
HDDS-7922. [FSO] S3G folder support fso layout filestatus s3A compatibility (apache#4448)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hemantk-12hemantk-12hemantk-12 left review comments
@smengclsmengclsmengcl approved these changes

Assignees

No one assigned

Labels

snapshothttps://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swamirishi@adoroszlai@hemantk-12@smengcl@prashantpogde