HDDS-7275. Improve error logging when blocks cannot be allocated with RATIS THREE.

[SaketaChalamchala]

What changes were proposed in this pull request?

Current implementation returns a null and later on ScmBlockLocationProtocolServerSideTranslatorPB#allocateScmBlock() throws an exception with #blocks allocated and requested.

# hdfs dfs -put /etc/krb5.conf ofs://ozone1/vol1/bucket/3
put: Allocated 0 blocks. Requested 1 blocks

Proposed changed returns an exception when a block cannot be allocated after trying all possible strategies

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7275

How was this patch tested?

Manual.

sh-4.2$ ozone sh key put /vol1/bucket1/key1 CONTRIBUTING.md
INTERNAL_ERROR Unable to allocate a container to the block of size: 1048576, replicationConfig: RATIS/THREE. Unable to find enough nodes that meet the space requirement of 10485760 bytes for metadata and 1073741824 bytes for data in healthy node set. Required 3. Found 2.
sh-4.2$ 

[errose28]

Thanks for improving this @SaketaChalamchala, this message has been confusing for users before. Could we also add a message summarizing why the allocation failed? For example, the log lines farther up in getContainer provide more information to the SCM log, but those messages could be returned to the client as well.

[SaketaChalamchala]

Thanks for improving this @SaketaChalamchala, this message has been confusing for users before. Could we also add a message summarizing why the allocation failed? For example, the log lines farther up in getContainer provide more information to the SCM log, but those messages could be returned to the client as well.

Done.

[errose28]

Functionally LGTM just minor comments remaining.

[errose28]

Thanks for fixing this @SaketaChalamchala. CI will likely fail until #5217 is merged (should be soon). I will hold off running CI on this PR until that is resolved.

[errose28]

Looks like #5217 is not progressing as fast as I thought, I will go ahead with the CI on this PR.

[errose28]

CI failures are fixed by #5217