Uh oh!
There was an error while loading. Please reload this page.
HDDS-8665. Implemented CopyObject for SnapshotInfo and moved out snapshot chain update form OMSnapshotPurgeResponse - #5201
Conversation
Uh oh!
There was an error while loading. Please reload this page.
smengcl
left a comment
There was a problem hiding this comment.
Structurally tha patch looks good to me.
@aswinshakil pls take a look. see if the chain operations are still consistent w/ the patch.
There was a problem hiding this comment.
Thank you for finding this issue and putting up the patch @hemantk-12 . Changes look good to me. Pending CI
| updateSnapshotInfoAndCache(nextSnapshot, omMetadataManager, | ||
| trxnLogIndex, updatedSnapInfos, true); | ||
| updateSnapshotChainAndCache(omMetadataManager, fromSnapshot, |
There was a problem hiding this comment.
There is a possibility that snapshot chain may get corrupted because of batch operation.
Created jira to revisit it: https://issues.apache.org/jira/browse/HDDS-9198
smengcl
commented
Aug 23, 2023
Thanks @hemantk-12 for the fix. Thanks @szetszwo for raising the issue. Thanks @aswinshakil for reviewing this. |
szetszwo
commented
Aug 23, 2023
@hemantk-12 , @smengcl , thanks a lot for fixing this! |
…ved out snapshot chain update form OMSnapshotPurgeResponse (apache#5201) (cherry picked from commit fcf5b17) Change-Id: I6df1b15926a10034a9d68f226b932392c1c67e9e
What changes were proposed in this pull request?
Issue is that at final stage of snapshot purge we update the snapshot chain and next global & path level snapshots in DB. When we update next global and path level snapshots in DB, it doesn’t not update the cache. SnapshotInfo read happens from the cache. When causes that test failures mentioned in HDDS-8665.
This change contains two main change.
OMSnapshotPurgeResponsetoOMSnapshotPurgeRequest.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8665
How was this patch tested?
Existing unit tests.