HDDS-9303. Display leader in table and highlight current node in OM web UI by smitajoshi12 · Pull Request #5311 · apache/ozone

smitajoshi12 · 2023-09-18T13:43:36Z

What changes were proposed in this pull request?

SCM web UI displays the leader information on the webUI and it makes debugging easier. Need to do similar in Ozone Manager.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9303

How was this patch tested?

Manually

Old Ozone UI

New Changes

When it is Standalone with no data hiding OM Roles (HA) Table with ozone-ha

Running ozone

Exception Handling

devmadhuu · 2023-09-19T06:14:45Z

@smitajoshi12 thanks for working on this patch, PR description says need to show leader information in ozone manager webUI, however I think we already show LEADER and FOLLOWER info in OM Web UI, but in JSON format, so pls correct the PR description and PR title.

dombizita · 2023-09-19T08:59:56Z

thanks for working on this @smitajoshi12!

@smitajoshi12 thanks for working on this patch, PR description says need to show leader information in ozone manager webUI, however I think we already show LEADER and FOLLOWER info in OM Web UI, but in JSON format, so pls correct the PR description and PR title.

I agree with Devesh, the OM roles are already present in the OM UI, it was added by @ArafatKhan2198 in HDDS-6863. For me it looks good already as it is, all the necessary information is present there.
This new table that is nested in another table looks a bit weird for me, but maybe that's just for me :) If we want to have a change like this, maybe it should be moved to a new table, but I'm not sure if that would improve the OM UI that much. In the SCM UI it also presents this information in JSON format. Let me know what you think!

smitajoshi12 · 2023-09-21T05:03:51Z

thanks for working on this @smitajoshi12!
@smitajoshi12 thanks for working on this patch, PR description says need to show leader information in ozone manager webUI, however I think we already show LEADER and FOLLOWER info in OM Web UI, but in JSON format, so pls correct the PR description and PR title.
I agree with Devesh, the OM roles are already present in the OM UI, it was added by @ArafatKhan2198 in HDDS-6863. For me it looks good already as it is, all the necessary information is present there. This new table that is nested in another table looks a bit weird for me, but maybe that's just for me :) If we want to have a change like this, maybe it should be moved to a new table, but I'm not sure if that would improve the OM UI that much. In the SCM UI it also presents this information in JSON format. Let me know what you think!

@dombizita
Hi ZIta,
Done Changes as suggested by you. Attached new Screenshot.

devmadhuu · 2023-09-21T07:17:30Z

thanks for working on this @smitajoshi12!
@smitajoshi12 thanks for working on this patch, PR description says need to show leader information in ozone manager webUI, however I think we already show LEADER and FOLLOWER info in OM Web UI, but in JSON format, so pls correct the PR description and PR title.
I agree with Devesh, the OM roles are already present in the OM UI, it was added by @ArafatKhan2198 in HDDS-6863. For me it looks good already as it is, all the necessary information is present there. This new table that is nested in another table looks a bit weird for me, but maybe that's just for me :) If we want to have a change like this, maybe it should be moved to a new table, but I'm not sure if that would improve the OM UI that much. In the SCM UI it also presents this information in JSON format. Let me know what you think!
@dombizita Hi ZIta, Done Changes as suggested by you. Attached new Screenshot.

@smitajoshi12 what is "tanle" format as you have mentioned in PR title. Is it by mistake ? Also PR description is not in line with what is being done in this patch. Also I agree with @dombizita , if this patch really needed as JSON format itself look fine and we want to keep any formatting or processing over OM UI as minimal as possible unless it is very much necessary. Can we keep same as in SCM webUI (in Json format) ? @dombizita @sumitagrawl pls suggest.

ArafatKhan2198

Thanks for the changes @smitajoshi12 for the OM-HA the table looks fine but what about when we have a standalone cluster will we want to display a table there as well, could you please attach a screenshot for that too.

smitajoshi12 · 2023-09-21T10:22:24Z

Thanks for the changes @smitajoshi12 for the OM-HA the table looks fine but what about when we have a standalone cluster will we want to display a table there as well, could you please attach a screenshot for that too.

@ArafatKhan2198
Attached New Screenshot with Standalone cluster with no Data.

sumitagrawl

@smitajoshi12 Thanks for working over this, have few comments.

sumitagrawl · 2023-10-09T13:27:08Z

ep same as in SCM webUI (in Json format)

Giving as JSON format, and showing in tablular format is good. I think its just render the page with data and may not have much impact for table.
Already given few comments for STANDALONE, non-ratis or exception cases, this is hidden now. That may need resolve for showing.

dombizita

Thanks for working on this @smitajoshi12, please take a look at my comments!

dombizita

Thanks for updating you patch @smitajoshi12, I added a few comments. Also there are 2 lines that are longer than 30 characters, you can check it here: https://github.com/smitajoshi12/ozone/actions/runs/6657443633/job/18092176653

sumitagrawl

@smitajoshi12 Given few minor comments, please check

…manager UI

… and highlight current node

… and highlight current node CSS removal

… and highlight current node. Review Comments

… and highlight current node Review Changes

… and highlight current node

… and highlight current node.Review Changes

adoroszlai · 2023-11-23T14:59:52Z

/pending If there is exception, how the output looks? do still accessing roles[1],... can have issue over UI in exception case?

github-actions

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

If there is exception, how the output looks? do still accessing roles[1],... can have issue over UI in exception case?

smitajoshi12 · 2023-11-27T03:18:13Z

/ready
@adoroszlai

I have attached screenshot for Exception Handling.
There is no issue over UI in terms of Exception Handling.

dombizita

Thanks for updating your PR and its description @smitajoshi12, I have one more comment, please take a look at it. Otherwise it's looking good to me!

… and highlight current node Review Change

…eb UI CheckStle Issue Solved

…eb UI CheckStle Issue

dombizita

Thanks for your continuous effort with this @smitajoshi12, could you take a look at my comments? Also please update the screenshots in the PR description with the changes.

…eb UI Review

…eb UI code formatting

sumitagrawl

@smitajoshi12 LGTM

…eb UI

dombizita · 2023-12-06T12:00:34Z

/ready

Blocking review request is removed.

dombizita · 2023-12-06T12:03:58Z

Thanks for working on this @smitajoshi12! Thank you for the review @devmadhuu, @ArafatKhan2198 and @sumitagrawl!

dombizita self-requested a review September 18, 2023 16:12

devmadhuu reviewed Sep 19, 2023
View reviewed changes

Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated

smitajoshi12 changed the title ~~HDDS-9303. Ozone Manager : Add Ozone leader information on the Ozone manager UI~~HDDS-9303. Ozone Manager : Display leader information on readable format and highlight current node.Sep 20, 2023

smitajoshi12 changed the title ~~HDDS-9303. Ozone Manager : Display leader information on readable format and highlight current node.~~HDDS-9303. Ozone Manager : Display leader information in tanle format and highlight current node.Sep 20, 2023

ArafatKhan2198 reviewed Sep 21, 2023
View reviewed changes

smitajoshi12 changed the title ~~HDDS-9303. Ozone Manager : Display leader information in tanle format and highlight current node.~~HDDS-9303. Ozone Manager : Display leader information in table format and highlight current node.Sep 21, 2023

sumitagrawl reviewed Oct 9, 2023
View reviewed changes

smitajoshi12 force-pushed the HDDS-9303 branch from c5107af to ef42695Compare October 23, 2023 09:43

dombizita reviewed Oct 25, 2023
View reviewed changes

Comment threadhadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java Outdated
Comment threadhadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java Outdated

dombizita reviewed Nov 2, 2023
View reviewed changes

Comment threadhadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/om-overview.html Outdated

dombizita reviewed Nov 2, 2023
View reviewed changes

sumitagrawl reviewed Nov 5, 2023
View reviewed changes

smitajoshi12 added 7 commits November 6, 2023 21:21

HDDS-9303. Ozone Manager : Add Ozone leader information on the Ozone …
d9c1902
…manager UI

HDDS-9303. Ozone Manager : Display leader information in tanle format…
ba23f0b
… and highlight current node

HDDS-9303. Ozone Manager : Display leader information in tanle format…
1d866ce
… and highlight current node CSS removal

HDDS-9303. Ozone Manager : Display leader information in table format…
342ae8e
… and highlight current node. Review Comments

HDDS-9303. Ozone Manager : Display leader information in table format…
b11bb5b
… and highlight current node Review Changes

HDDS-9303. Ozone Manager : Display leader information in table format…
a16bf03
… and highlight current node

HDDS-9303. Ozone Manager : Display leader information in table format…
c47bae6
… and highlight current node.Review Changes

smitajoshi12 force-pushed the HDDS-9303 branch from 8c6da69 to c47bae6Compare November 6, 2023 17:18

github-actionsBot previously requested changes Nov 23, 2023
View reviewed changes

github-actionsBot added the pending label Nov 23, 2023

dombizita reviewed Nov 27, 2023
View reviewed changes

Comment threadhadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/om-overview.html Outdated

HDDS-9303. Ozone Manager : Display leader information in table format…
b5c0712
… and highlight current node Review Change

adoroszlai changed the title ~~HDDS-9303. Ozone Manager : Display leader information in table format and highlight current node.~~HDDS-9303. Display leader in table and highlight current node in OM web UINov 27, 2023

adoroszlai requested a review from sumitagrawl November 27, 2023 11:42

smitajoshi12 added 2 commits November 27, 2023 19:25

HDDS-9303. Display leader in table and highlight current node in OM w…
120c441
…eb UI CheckStle Issue Solved

HDDS-9303. Display leader in table and highlight current node in OM w…
959e814
…eb UI CheckStle Issue

dombizita reviewed Nov 28, 2023
View reviewed changes

Comment threadhadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java Outdated
Comment threadhadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/om-overview.html Outdated

smitajoshi12 added 2 commits November 29, 2023 19:17

HDDS-9303. Display leader in table and highlight current node in OM w…
d5c848e
…eb UI Review

HDDS-9303. Display leader in table and highlight current node in OM w…
819fbe0
…eb UI code formatting

sumitagrawl approved these changes Dec 4, 2023
View reviewed changes

HDDS-9303. Display leader in table and highlight current node in OM w…
89b1c07
…eb UI

github-actionsBot removed the pending label Dec 6, 2023

dombizita approved these changes Dec 6, 2023
View reviewed changes

dombizita merged commit dd431cd into apache:masterDec 6, 2023

sodonnel mentioned this pull request Dec 11, 2023
HDDS-9816. NPE for access to MXBean during shutdown of OM #5709
Merged

smitajoshi12 deleted the HDDS-9303 branch December 14, 2023 07:32

ivandika3 mentioned this pull request Jul 19, 2024
HDDS-11196. Improve SCM WebUI Display. #6960
Merged

Uh oh!

Conversation

smitajoshi12 commented Sep 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Old Ozone UI

Uh oh!

devmadhuu commented Sep 19, 2023

Uh oh!

Uh oh!

dombizita commented Sep 19, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smitajoshi12 commented Sep 21, 2023

Uh oh!

devmadhuu commented Sep 21, 2023

Uh oh!

ArafatKhan2198 left a comment

Choose a reason for hiding this comment

Uh oh!

smitajoshi12 commented Sep 21, 2023

Uh oh!

sumitagrawl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sumitagrawl commented Oct 9, 2023

Uh oh!

dombizita left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dombizita left a comment

Choose a reason for hiding this comment

Uh oh!

sumitagrawl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adoroszlai commented Nov 23, 2023

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

smitajoshi12 commented Nov 27, 2023

Uh oh!

dombizita left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dombizita left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sumitagrawl left a comment

Choose a reason for hiding this comment

Uh oh!

dombizita commented Dec 6, 2023

Uh oh!

dombizita commented Dec 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

smitajoshi12 commented Sep 18, 2023•
edited
Loading

dombizita commented Sep 19, 2023•
edited
Loading