HDDS-9288. Intermittent failure in TestSnapshotDeletingService#testMultipleSnapshotKeyReclaim

[hemantk-12]

What changes were proposed in this pull request?

After #5986, pendingEvictionList has been removed and assertion on pendingEvictionList has been removed as well which was causing Intermittent test failure. This change is to remove flaky tag from the test.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9288

How was this patch tested?

Ran the test on local repo 10X10 times: https://github.com/hemantk-12/ozone/actions/runs/7563200213

[adoroszlai]

Thanks @hemantk-12 for working on this.

I'm not sure the patch fixes the problem. Tested in 10x10 runs (of TestSnapshotDeletingService, not only testMultipleSnapshotKeyReclaim) both without and with the patch:

• without: assertion failed in 1/100 cases (1)
• with: waitFor timed out in 2/100 cases (1, 2)

[hemantk-12]

@adoroszlai thanks for reviewing it.

I'm not sure the patch fixes the problem. Tested in 10x10 runs (of TestSnapshotDeletingService, not only testMultipleSnapshotKeyReclaim) both without and with the patch:

You are right. It doesn't fix it. I need to do more deep dive here.
Seems like an issue with Set#remove() here: https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java#L108

[swamirishi]

Thanks for the patch @hemantk-12 LGTM

[hemantk-12]

Thanks for the review @swamirishi and @adoroszlai.