HDDS-9381. Remove @Flaky annotations from now-stable test cases.

[ArafatKhan2198]

What changes were proposed in this pull request?

Remove the @Flaky annotations from the test cases that have been successfully fixed and are no longer experiencing flakiness.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9381

How was this patch tested?

I ran the Test class 300 times for each test class and ensured that there were no intermittent failures.

Class Name	CI Runs
TestSCMContainerPlacementPolicyMetrics HDDS-2961	https://github.com/ArafatKhan2198/ozone/actions/runs/6398416895https://github.com/ArafatKhan2198/ozone/actions/runs/6398418026https://github.com/ArafatKhan2198/ozone/actions/runs/6398419702
TestOzoneManagerHAMetadataOnly HDDS-6644	https://github.com/ArafatKhan2198/ozone/actions/runs/6235727447https://github.com/ArafatKhan2198/ozone/actions/runs/6235729232
TestOzoneManagerHAMetadataOnly HDDS-6642	https://github.com/ArafatKhan2198/ozone/actions/runs/6235727447https://github.com/ArafatKhan2198/ozone/actions/runs/6235729232
TestBlockOutputStreamWithFailures HDDS-1967	https://github.com/ArafatKhan2198/ozone/actions/runs/6398347226https://github.com/ArafatKhan2198/ozone/actions/runs/6398357035https://github.com/ArafatKhan2198/ozone/actions/runs/6398360165
TestCloseContainerByPipeline HDDS-3263	https://github.com/ArafatKhan2198/ozone/actions/runs/6377459304https://github.com/ArafatKhan2198/ozone/actions/runs/6377460878https://github.com/ArafatKhan2198/ozone/actions/runs/6377461812
TestRandomKeyGenerator HDDS-5993	https://github.com/ArafatKhan2198/ozone/actions/runs/6025312941https://github.com/ArafatKhan2198/ozone/actions/runs/6028746303https://github.com/ArafatKhan2198/ozone/actions/runs/6028751338
TestRecursiveAclWithFSO HDDS-8092	https://github.com/ArafatKhan2198/ozone/actions/runs/6402939616https://github.com/ArafatKhan2198/ozone/actions/runs/6402940691https://github.com/ArafatKhan2198/ozone/actions/runs/6402942430
TestOzoneFileSystem HDDS-6645	https://github.com/ArafatKhan2198/ozone/actions/runs/6403238608https://github.com/ArafatKhan2198/ozone/actions/runs/6403241618https://github.com/ArafatKhan2198/ozone/actions/runs/6403245347
TestFailureHandlingByClient HDDS-7878, HDDS-7877, HDDS-3298	https://github.com/ArafatKhan2198/ozone/actions/runs/6406992420https://github.com/ArafatKhan2198/ozone/actions/runs/6406994448https://github.com/ArafatKhan2198/ozone/actions/runs/6406995766https://github.com/ArafatKhan2198/ozone/actions/runs/6398395587https://github.com/ArafatKhan2198/ozone/actions/runs/6398397760https://github.com/ArafatKhan2198/ozone/actions/runs/6398399722
TestMiniOzoneCluster HDDS-6112	https://github.com/ArafatKhan2198/ozone/actions/runs/6415665976https://github.com/ArafatKhan2198/ozone/actions/runs/6415667287https://github.com/ArafatKhan2198/ozone/actions/runs/6415667828
TestContainerStateMachineFailureOnRead HDDS-3294	https://github.com/ArafatKhan2198/ozone/actions/runs/6407771968https://github.com/ArafatKhan2198/ozone/actions/runs/6407770619https://github.com/ArafatKhan2198/ozone/actions/runs/6407768429

[adoroszlai]

Thanks @ArafatKhan2198 for working on this. Please link the repeated runs for each test class in this PR.

[ArafatKhan2198]

Thanks @ArafatKhan2198 for working on this. Please link the repeated runs for each test class in this PR.

Just finalising the list, will post it shortly.

[ayushtkn]

These aren't passing, or Am I checking it wrong?

TestOzoneFileSystem HDDS-6645	https://github.com/ArafatKhan2198/ozone/actions/runs/6403238608https://github.com/ArafatKhan2198/ozone/actions/runs/6403241618https://github.com/ArafatKhan2198/ozone/actions/runs/6403245347

[adoroszlai]

These aren't passing, or Am I checking it wrong?
TestOzoneFileSystem

@ayushtkn You are right, TestOzoneFileSystem has failures. Note that:

1. failure in testListStatusOnKeyNameContainDelimiter is being fixed in HDDS-8877. Intermittent failure in TestOzoneFileSystem#testListStatusOnKeyNameContainDelimiter #5093, and does not have @Flaky annotation
2. failure in testTrash was already fixed and @Flaky annotation was removed in HDDS-6645. Intermittent timeout in TestOzoneFileSystem#testTrash. #5330, but the repeated run's code preceded that change
3. @Flaky does not even work for TestOzoneFileSystem since it's a JUnit4-based test class

So basically the part of this PR related to TestOzoneFileSystem can be ignored, the same change is already on master.

[ayushtkn]

Should be cool then.
Thanx @adoroszlai for the details :-)

[ArafatKhan2198]

@adoroszlai I have updated the list for the final time, I believe we should merge it !!

[adoroszlai]

Thanks @ArafatKhan2198 for testing these and the patch, @ayushtkn for the review.