Uh oh!
There was an error while loading. Please reload this page.
HDDS-10046. Replace PrecomputedVolumeSpace with SpaceUsageSource.Fixed - #5904
Merged
Conversation
adoroszlai
commented
Jan 2, 2024
ContributorAuthor
@xichen01 please review |
adoroszlai
commented
Jan 5, 2024
ContributorAuthor
Thanks @sadanand48 for the review. |
xichen01 pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
apache#5904) (cherry picked from commit 2066868)
xichen01 pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
apache#5904) (cherry picked from commit 2066868)
xichen01 pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
apache#5904) (cherry picked from commit 2066868)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PrecomputedVolumeSpace, added in HDDS-9380, is structurally very similar to theFixedimplementation ofSpaceUsageSource. The latter is currently only used for testing. We can reduce duplication by movingFixedfrom tests to production code and replacingPrecomputedVolumeSpacewith it.https://issues.apache.org/jira/browse/HDDS-10046
How was this patch tested?
Refactoring, covered by existing tests:
https://github.com/adoroszlai/ozone/actions/runs/7385534327