Uh oh!
There was an error while loading. Please reload this page.
HDDS-10358. Allow Container Balancer tuning options to be set in CLI - #6241
Conversation
errose28
left a comment
There was a problem hiding this comment.
Thanks for working on this @sarvekshayr. Let's also add a test that when CLI options and configurations are present, the CLI options override the defined configurations (assuming that is expected behavior).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
siddhantsangwan
left a comment
There was a problem hiding this comment.
Thanks for working on this. I've left some comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
siddhantsangwan
commented
Feb 27, 2024
@SaketaChalamchala would you like to review? |
Uh oh!
There was an error while loading. Please reload this page.
sumitagrawl
left a comment
There was a problem hiding this comment.
@sarvekshayr Thanks for working over this, have few minor comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you @sarvekshayr for updating the patch, please find a few minor nits.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…ozone/TestContainerBalancerOperations.java Co-authored-by: tanvipenumudy <46785609+tanvipenumudy@users.noreply.github.com>
…ozone/TestContainerBalancerOperations.java Co-authored-by: tanvipenumudy <46785609+tanvipenumudy@users.noreply.github.com>
…ozone/TestContainerBalancerOperations.java Co-authored-by: tanvipenumudy <46785609+tanvipenumudy@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Tejaskriya
left a comment
There was a problem hiding this comment.
Please find a few comments regarding the checks changed.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Tejaskriya
left a comment
There was a problem hiding this comment.
LGTM, +1. Thanks for making the changes
siddhantsangwan
left a comment
There was a problem hiding this comment.
@sarvekshayr Thanks for updating. Other than my comment above about error handling, this change looks good now. We can kick off CI once you've updated it.
siddhantsangwan
left a comment
There was a problem hiding this comment.
Waiting for green CI.
siddhantsangwan
commented
Apr 1, 2024
Thanks @sarvekshayr and all the reviewers. Merging to master. |
…pache#6241) (cherry picked from commit 077fff4)
What changes were proposed in this pull request?
Introducing more configuration options in the Container Balancer CLI tool. Options for including and excluding nodes from balancing, "balancing.iteration.interval", "move.timeout", "move.replication.timeout" for managing timeouts and "move.networkTopology.enable" for enabling network topology aware moves.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10358
How was this patch tested?
Listing all the subcommands under containerbalancer start


Default values of the tuning options

Starting containerbalancer with the newly added tuning options in CLI.

