Uh oh!
There was an error while loading. Please reload this page.
HDDS-5865. Made read retry max attempts and interval configurable. - #6309
HDDS-5865. Made read retry max attempts and interval configurable.#6309SaketaChalamchala wants to merge 19 commits into
Conversation
ashishkumar50
left a comment
There was a problem hiding this comment.
@SaketaChalamchala, Thanks for working on this.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ashishkumar50
left a comment
There was a problem hiding this comment.
@SaketaChalamchala Thanks for updating patch, LGTM +1.
adoroszlai
commented
Mar 7, 2024
@SaketaChalamchala I recommend resetting |
| retryPolicy = | ||
| HddsClientUtils.createRetryPolicy(config.getMaxReadRetryCount(), | ||
| TimeUnit.SECONDS.toMillis(config.getReadRetryInterval())); |
There was a problem hiding this comment.
Storing this as static seems unsafe.
Code is spread in 3 places:
- this class
- class that calls
setRetryPolicy - class that uses the policy
It is hard to see if any usage may get outdated or
nullvalue.Concurrent clients may get unexpected results.
SaketaChalamchala
commented
Mar 20, 2024
Thanks for the feedback @adoroszlai . Closing this PR and opened another one #6408 with updated changes. Please review those as well.
Also, will do this from next time. Thanks |
What changes were proposed in this pull request?
Retry policy when reading keys is hardcoded. Made the read retry max attempts and retry interval configurable in client configuration
ozone.client.max.read.retriesandozone.client.max.read.retriesWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5865
How was this patch tested?
Existing UT and integration tests should run as is.