Skip to content

HDDS-10436. datanode status decommission command should have json output option - #6369

Merged
devmadhuu merged 8 commits into
apache:masterfrom
sarvekshayr:HDDS-10436
Mar 21, 2024
Merged

HDDS-10436. datanode status decommission command should have json output option#6369
devmadhuu merged 8 commits into
apache:masterfrom
sarvekshayr:HDDS-10436

Conversation

@sarvekshayr

@sarvekshayrsarvekshayr commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Added --json option for json formatted output to ozone admin datanode status decommission command.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10436

How was this patch tested?

Tested the format of the output using a docker cluster.
Screenshot 2024-03-12 at 3 32 59 PM

devmadhuu
devmadhuu reviewed Mar 13, 2024
View reviewed changes

@devmadhuudevmadhuu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment.

Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
sarvekshayrand others added 2 commits March 13, 2024 20:14
@sarvekshayr@devmadhuu
Update hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli…
3d2abbc
…/datanode/DecommissionStatusSubCommand.java
Co-authored-by: Devesh Kumar Singh <devesh_76@hotmail.com>
@sarvekshayr
Added checked exception
90291da
devmadhuu
devmadhuu reviewed Mar 14, 2024
View reviewed changes
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
devmadhuu
devmadhuu reviewed Mar 14, 2024
View reviewed changes
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
Tejaskriya
Tejaskriya requested changes Mar 14, 2024
View reviewed changes

@TejaskriyaTejaskriya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few optimisations that can be done. Please find my review comments below

Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java Outdated
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Comment thread...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
devmadhuu
devmadhuu approved these changes Mar 15, 2024
View reviewed changes

@devmadhuudevmadhuu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarvekshayr for working on this patch. LGTM +1

@devmadhuudevmadhuu mentioned this pull request Mar 18, 2024
Merged
Tejaskriya
Tejaskriya approved these changes Mar 19, 2024
View reviewed changes

@TejaskriyaTejaskriya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

sumitagrawl
sumitagrawl approved these changes Mar 21, 2024
View reviewed changes

@sumitagrawlsumitagrawl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarvekshayr LGTM

@devmadhuu
devmadhuu merged commit 72fef61 into apache:masterMar 21, 2024
smitajoshi12 pushed a commit to smitajoshi12/ozone that referenced this pull request Mar 27, 2024
@sarvekshayr@smitajoshi12
HDDS-10436. datanode status decommission command should have json out…
e877508
…put option (apache#6369)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devmadhuudevmadhuudevmadhuu approved these changes
@sumitagrawlsumitagrawlsumitagrawl approved these changes
@TejaskriyaTejaskriyaTejaskriya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sarvekshayr@devmadhuu@sumitagrawl@Tejaskriya