Uh oh!
There was an error while loading. Please reload this page.
HDDS-10564. Make Outputstream writeExecutor daemon threads. - #6418
Conversation
Change-Id: Id5a1d332f8ac93991fd52b85ad186cbc6af9630f
xichen01
commented
Mar 22, 2024
It looks like the |
adoroszlai
commented
Mar 22, 2024
Does that mean ongoing write may be dropped and data lost? |
jojochuang
commented
Mar 22, 2024
writeExecutor was added by HDDS-10383 and is new. |
output stream should call close() which will ensure data in the buffer is flushed. |
adoroszlai
commented
Mar 24, 2024
Thanks @jojochuang for the patch, @xichen01 for the review. |
(cherry picked from commit 82c02d3)
) (cherry picked from commit 82c02d3)
) (cherry picked from commit 82c02d3)
(cherry picked from commit 82c02d3)
What changes were proposed in this pull request?
HDDS-10564. Make Outputstream writeExecutor daemon threads.
Please describe your PR in detail:
HDDS-10383 added new thread pools in the output stream. They should be made daemon threads so that processes don't wait for them when exiting. (The bug is in the command line which does not close FileSystem object. Nonetheless, it would still be a good idea to make these thread pools daemon)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10564
How was this patch tested?
Deployed on a real cluster, with HBase on Ozone, repeated the same command to verify that the command no longer hangs.