Skip to content

HDDS-10923. Container Scanner should still scan unhealthy containers. - #6809

Merged
errose28 merged 3 commits into
apache:HDDS-10239-container-reconciliationfrom
aswinshakil:HDDS-10923
Jun 25, 2024
Merged

HDDS-10923. Container Scanner should still scan unhealthy containers.#6809
errose28 merged 3 commits into
apache:HDDS-10239-container-reconciliationfrom
aswinshakil:HDDS-10923

Conversation

@aswinshakil

@aswinshakilaswinshakil commented Jun 12, 2024

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Currently the container scanner skips containers which are already marked as unhealthy. Now that the we want to either repair these containers, or use parts of them to repair other containers. We need the container scanner to scan UNHEALTHY container as well.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10923

How was this patch tested?

Existing Tests.

@aswinshakilaswinshakil self-assigned this Jun 12, 2024
@errose28
errose28 self-requested a review June 17, 2024 19:46
errose28
errose28 reviewed Jun 18, 2024
View reviewed changes

@errose28errose28 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aswinshakil LGTM once we add tests that already unhealthy containers are getting re-scanned.

Comment thread...src/test/java/org/apache/hadoop/ozone/container/ozoneimpl/TestContainerScannersAbstract.java
Comment thread...iner-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java
errose28
errose28 reviewed Jun 21, 2024
View reviewed changes

@errose28errose28 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aswinshakil just a few more updates based on the test changes.

Comment thread...est/java/org/apache/hadoop/ozone/container/ozoneimpl/TestBackgroundContainerDataScanner.java Outdated
Comment thread...est/java/org/apache/hadoop/ozone/container/ozoneimpl/TestBackgroundContainerDataScanner.java Outdated
Comment thread.../test/java/org/apache/hadoop/ozone/container/ozoneimpl/TestOnDemandContainerDataScanner.java Outdated
errose28
errose28 reviewed Jun 25, 2024
View reviewed changes

@errose28errose28 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment on the test updates then this looks good from me.

Comment thread...est/java/org/apache/hadoop/ozone/container/ozoneimpl/TestBackgroundContainerDataScanner.java
errose28
errose28 approved these changes Jun 25, 2024
View reviewed changes

@errose28errose28 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aswinshakil

@errose28
errose28 merged commit 5bde01d into apache:HDDS-10239-container-reconciliationJun 25, 2024
errose28 added a commit to errose28/ozone that referenced this pull request Jun 28, 2024
@errose28
Merge branch 'HDDS-10239-container-reconciliation' into HDDS-10926-mt…
838eb59
…-delete
* HDDS-10239-container-reconciliation:
HDDS-10887. Implement a basic Merkle Tree Manager. (apache#6778)
HDDS-10923. Container Scanner should still scan unhealthy containers. (apache#6809)
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/checksum/TestContainerChecksumTreeManager.java
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kerneltimekerneltimekerneltime approved these changes
@errose28errose28errose28 approved these changes

Assignees

@aswinshakilaswinshakil

Labels

container-reconciliation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aswinshakil@kerneltime@errose28