Uh oh!
There was an error while loading. Please reload this page.
HDDS-11140. Recon Disk Usage Metadata Details are not working for du api - #6966
Conversation
…api Remove Console Log
ArafatKhan2198
commented
Jul 22, 2024
@smitajoshi12, thank you for working on this. Could you please show us the error message that appeared earlier and how it is displayed in the UI after the fix? |
smitajoshi12
commented
Jul 22, 2024
@ArafatKhan2198 @devabhishekpal |
ArafatKhan2198
commented
Jul 24, 2024
Hi @smitajoshi12, I'm having trouble understanding the changes we've implemented here. Have we modified the response? The responses before and after the patch seem completely different. Could you please clarify what the behaviour was previously and what it is now? |
There was a problem hiding this comment.
Thanks for making changes to the PR description @smitajoshi12
Makes more sense now.
Changes LGTM!
spacemonkd
left a comment
There was a problem hiding this comment.
Thanks @smitajoshi12 for the updated description.
This looks good to me, +1
ArafatKhan2198
commented
Jul 25, 2024
Thanks for the patch @smitajoshi12 thanks for the review @devabhishekpal |
…api (apache#6966) (cherry picked from commit 96e1a8c)
…api (apache#6966) (cherry picked from commit 96e1a8c)
…api (apache#6966) (cherry picked from commit 96e1a8c)
What changes were proposed in this pull request?
Metadata summary was not working properly for Entity Type Key.
Please describe your PR in detail:
Metadata summary was not working properly for Entity Type Key.
File Size and File Size Replication was not working earlier so corrected in this PR.
What is the link to the Apache JIRA
(https://issues.apache.org/jira/browse/HDDS-11140)
How was this patch tested?
Manually with Cluster Data
Before this Patch
File Size and File Size Replication was not present in Metadata Summary for Entity Type Key
api/v1/namespace/du?path=/s3v/fso-bucket/dir1/key1-fso&files=true&sortSubPaths=true
{
"path": "/s3v/fso-bucket/dir1/key1-fso",
"type": "KEY",
"countStats": {
"numVolume": 100,
"numBucket": 200,
"numDir": 400,
"numKey": 80
}
"status": "OK"
}
After this Patch
api/v1/namespace/du?path=/s3v/fso-bucket/dir1/key1-fso&files=true&sortSubPaths=true
{
"path": "/s3v/fso-bucket/dir1/key1-fso",
"type": "KEY",
"countStats": {
"numVolume": 100,
"numBucket": 200,
"numDir": 400,
"numKey": 80
}
"status": "OK"
}
Response is same for namespace api there is no change from backend. Recon UI was not handling below api
/api/v1/namespace/du?path=/s3v/fso-bucket/dir1/key1-fso&replica=true properly for Entity Type = Key so changed UI code below api will get called from UI.
For Entity Type KEY
Request :- /api/v1/namespace/du?path=/s3v/fso-bucket/dir1/key1-fso&replica=true
Response:- {
"status": "OK",
"path": "/s3v/fso-bucket/dir1/key1-fso",
"size": 17289,
"sizeWithReplica": 17289,
"subPathCount": 0,
"subPaths": [],
"sizeDirectKey": -1
}