Skip to content

HDDS-11272. Statistics some node status information - #7025

Merged
ivandika3 merged 4 commits into
apache:masterfrom
jianghuazhu:HDDS-11272
Aug 6, 2024
Merged

HDDS-11272. Statistics some node status information#7025
ivandika3 merged 4 commits into
apache:masterfrom
jianghuazhu:HDDS-11272

Conversation

@jianghuazhu

@jianghuazhujianghuazhu commented Aug 3, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

In Ozone, there is no statistical node status information, such as healthy nodes, dead nodes, decommissioning nodes, etc. The purpose of this PR is to improve these.
After adding this PR, jmx and UI will be updated.
New jmx:
image

New ui:
image

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11272

How was this patch tested?

You need to ensure that JMX displays normally.
You need to ensure that the UI displays normally.

@jianghuazhu

jianghuazhu commented Aug 3, 2024

Copy link
Copy Markdown
ContributorAuthor

ci : https://github.com/jianghuazhu/ozone/actions/runs/10227201111
This jira and HDDS-11252 both solve the same type of problem. Can you review them together, @adoroszlai@szetszwo@ivandika3.
Thanks.

ivandika3
ivandika3 reviewed Aug 5, 2024
View reviewed changes

@ivandika3ivandika3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianghuazhu Thanks for the patch. Left a few comments.

Comment threadhadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java Outdated
Comment threadhadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html
Comment threadhadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
Comment on lines +522 to +534
List<DatanodeInfo> allNodes = nodeStateMap.getAllDatanodeInfos();
if (allNodes.size() < 1) {
return allNodes;
}

List<DatanodeInfo> failedVolumeNodes = new ArrayList<>();
for (DatanodeInfo dn : allNodes) {
if (dn.getFailedVolumeCount() > 0) {
failedVolumeNodes.add(dn);
}
}

return failedVolumeNodes;

@ivandika3ivandika3Aug 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can use Java Stream API filter for conciseness.

Comment threadhadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeInfo.java
Comment threadhadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
Comment threadhadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
Comment threadhadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
ivandika3
ivandika3 reviewed Aug 6, 2024
View reviewed changes

@ivandika3ivandika3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. One nitpick.

Comment threadhadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java Outdated
@ivandika3ivandika3 added the UI label Aug 6, 2024
ivandika3
ivandika3 approved these changes Aug 6, 2024
View reviewed changes

@ivandika3ivandika3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM +1.

@ivandika3
ivandika3 merged commit 2c0e0b1 into apache:masterAug 6, 2024
@ivandika3

ivandika3 commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Thanks for the patch @jianghuazhu

errose28 added a commit to errose28/ozone that referenced this pull request Aug 7, 2024
@errose28
Merge branch 'master' into HDDS-10239-container-reconciliation
98369a8
* master: (181 commits)
HDDS-11289. Bump docker-maven-plugin to 0.45.0 (apache#7024)
HDDS-11287. Code cleanup in XceiverClientSpi (apache#7043)
HDDS-11283. Refactor KeyValueStreamDataChannel to avoid spurious IDE build issues (apache#7040)
HDDS-11257. Ozone write does not work when http proxy is set for the JVM. (apache#7036)
HDDS-11249. Bump ozone-runner to 20240729-jdk17-1 (apache#7003)
HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info (apache#6724)
HDDS-11270. [hsync] Add DN layout version (HBASE_SUPPORT/version 8) upgrade test. (apache#7021)
HDDS-11272. Statistics some node status information (apache#7025)
HDDS-11278. Move code out of Hadoop util package (apache#7028)
HDDS-11274. (addendum) Replace Hadoop annotations/configs with Ozone-specific ones
HDDS-11274. Replace Hadoop annotations/configs with Ozone-specific ones (apache#7026)
HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength (apache#7032)
HDDS-11235. Spare InfoBucket RPC call in FileSystem#mkdir() call. (apache#6990)
HDDS-11273. Bump commons-compress to 1.26.2 (apache#7023)
HDDS-11225. Increase ipc.server.read.threadpool.size (apache#7007)
HDDS-11224. Increase hdds.datanode.handler.count (apache#7011)
HDDS-11259. [hsync] DataNode should verify HBASE_SUPPORT layout version for every PutBlock. (apache#7012)
HDDS-11214. Added config to set rocksDB's max log file size and num of log files (apache#7014)
HDDS-11226. Make ExponentialBackoffPolicy maxRetries configurable (apache#6985)
HDDS-11260. [hsync] Add Ozone Manager protocol version (apache#7015)
...
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/audit/DNAction.java
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerReportHandler.java
errose28 added a commit to errose28/ozone that referenced this pull request Aug 13, 2024
@errose28
Merge branch 'HDDS-10239-container-reconciliation' into HDDS-11254-re…
6f68df6
…p-supervisor
Merge conflicts are resolved but the change does not yet build.
* HDDS-10239-container-reconciliation: (183 commits)
HDDS-10376. Add a Datanode API to supply a merkle tree for a given container. (apache#6945)
HDDS-11289. Bump docker-maven-plugin to 0.45.0 (apache#7024)
HDDS-11287. Code cleanup in XceiverClientSpi (apache#7043)
HDDS-11283. Refactor KeyValueStreamDataChannel to avoid spurious IDE build issues (apache#7040)
HDDS-11257. Ozone write does not work when http proxy is set for the JVM. (apache#7036)
HDDS-11249. Bump ozone-runner to 20240729-jdk17-1 (apache#7003)
HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info (apache#6724)
HDDS-10926. Block deletion should update container merkle tree. (apache#6875)
HDDS-11270. [hsync] Add DN layout version (HBASE_SUPPORT/version 8) upgrade test. (apache#7021)
HDDS-11272. Statistics some node status information (apache#7025)
HDDS-11278. Move code out of Hadoop util package (apache#7028)
HDDS-11274. (addendum) Replace Hadoop annotations/configs with Ozone-specific ones
HDDS-11274. Replace Hadoop annotations/configs with Ozone-specific ones (apache#7026)
HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength (apache#7032)
HDDS-11235. Spare InfoBucket RPC call in FileSystem#mkdir() call. (apache#6990)
HDDS-11273. Bump commons-compress to 1.26.2 (apache#7023)
HDDS-11225. Increase ipc.server.read.threadpool.size (apache#7007)
HDDS-11224. Increase hdds.datanode.handler.count (apache#7011)
HDDS-11259. [hsync] DataNode should verify HBASE_SUPPORT layout version for every PutBlock. (apache#7012)
HDDS-11214. Added config to set rocksDB's max log file size and num of log files (apache#7014)
...
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
errose28 added a commit to errose28/ozone that referenced this pull request Aug 16, 2024
@errose28
Merge branch 'HDDS-10239-container-reconciliation' into HDDS-11253-co…
8601118
…rrupt-files
* HDDS-10239-container-reconciliation: (183 commits)
HDDS-10376. Add a Datanode API to supply a merkle tree for a given container. (apache#6945)
HDDS-11289. Bump docker-maven-plugin to 0.45.0 (apache#7024)
HDDS-11287. Code cleanup in XceiverClientSpi (apache#7043)
HDDS-11283. Refactor KeyValueStreamDataChannel to avoid spurious IDE build issues (apache#7040)
HDDS-11257. Ozone write does not work when http proxy is set for the JVM. (apache#7036)
HDDS-11249. Bump ozone-runner to 20240729-jdk17-1 (apache#7003)
HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info (apache#6724)
HDDS-10926. Block deletion should update container merkle tree. (apache#6875)
HDDS-11270. [hsync] Add DN layout version (HBASE_SUPPORT/version 8) upgrade test. (apache#7021)
HDDS-11272. Statistics some node status information (apache#7025)
HDDS-11278. Move code out of Hadoop util package (apache#7028)
HDDS-11274. (addendum) Replace Hadoop annotations/configs with Ozone-specific ones
HDDS-11274. Replace Hadoop annotations/configs with Ozone-specific ones (apache#7026)
HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength (apache#7032)
HDDS-11235. Spare InfoBucket RPC call in FileSystem#mkdir() call. (apache#6990)
HDDS-11273. Bump commons-compress to 1.26.2 (apache#7023)
HDDS-11225. Increase ipc.server.read.threadpool.size (apache#7007)
HDDS-11224. Increase hdds.datanode.handler.count (apache#7011)
HDDS-11259. [hsync] DataNode should verify HBASE_SUPPORT layout version for every PutBlock. (apache#7012)
HDDS-11214. Added config to set rocksDB's max log file size and num of log files (apache#7014)
...
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/checksum/TestContainerChecksumTreeManager.java
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivandika3ivandika3ivandika3 approved these changes

Assignees

No one assigned

Labels

UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jianghuazhu@ivandika3