Skip to content

HDDS-11346. FS CLI gives incorrect recursive volume deletion prompt - #7102

Merged
ashishkumar50 merged 1 commit into
apache:masterfrom
smengcl:HDDS-11346-prompt
Aug 21, 2024
Merged

HDDS-11346. FS CLI gives incorrect recursive volume deletion prompt#7102
ashishkumar50 merged 1 commit into
apache:masterfrom
smengcl:HDDS-11346-prompt

Conversation

@smengcl

@smengclsmengcl commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Correct the prompt Ozone CLI gives when trying to recursively delete an Ozone volume.

HDDS-10716 fixed it partially by removing the invalid -skipTrash option but didn't fix the -id part.

See the JIRA description for more details.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11346

How was this patch tested?

  • Verified manually.

@smengclsmengcl self-assigned this Aug 20, 2024
ashishkumar50
ashishkumar50 approved these changes Aug 21, 2024
View reviewed changes

@ashishkumar50ashishkumar50 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@ashishkumar50
ashishkumar50 merged commit 91fb176 into apache:masterAug 21, 2024
errose28 added a commit to errose28/ozone that referenced this pull request Aug 21, 2024
@errose28
Merge branch 'master' into HDDS-10239-container-reconciliation
7186a77
* master: (50 commits)
HDDS-11331. Fix Datanode unable to report for a long time (apache#7090)
HDDS-11346. FS CLI gives incorrect recursive volume deletion prompt (apache#7102)
HDDS-11349. Add NullPointer handling when volume/bucket tables are not initialized (apache#7103)
HDDS-11209. Avoid insufficient EC pipelines in the container pipeline cache (apache#6974)
HDDS-11284. refactor quota repair non-blocking while upgrade (apache#7035)
HDDS-9790. Add tests for Overview page (apache#6983)
HDDS-10904. [hsync] Enable PutBlock piggybacking and incremental chunk list by default (apache#7074)
HDDS-11322. [hsync] Block ECKeyOutputStream from calling hsync and hflush (apache#7098)
HDDS-11325. Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose (apache#7099)
HDDS-11340. Avoid extra PubBlock call when a full block is closed (apache#7094)
HDDS-11155. Improve Volumes page UI (apache#7048)
HDDS-11324. Negative value preOpLatencyMs in DN audit log (apache#7093)
HDDS-11246. [Recon] Use optional chaining instead of explicit undefined check for Objects in Container and Pipeline Module. (apache#7037)
HDDS-11323. Mark TestLeaseRecovery as flaky
HDDS-11338. Bump zstd-jni to 1.5.6-4 (apache#7085)
HDDS-11337. Bump Spring Framework to 5.3.39 (apache#7084)
HDDS-11327. [hsync] Revert config default ozone.fs.hsync.enabled to false (apache#7079)
HDDS-11325. Mark testWriteMoreThanMaxFlushSize as flaky
HDDS-11336. Bump slf4j to 2.0.16 (apache#7086)
HDDS-11335. Bump exec-maven-plugin to 3.4.1 (apache#7087)
...
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
errose28 added a commit to errose28/ozone that referenced this pull request Aug 21, 2024
@errose28
Merge branch 'master' into HDDS-10239-container-reconciliation
3355701
* master: (50 commits)
HDDS-11331. Fix Datanode unable to report for a long time (apache#7090)
HDDS-11346. FS CLI gives incorrect recursive volume deletion prompt (apache#7102)
HDDS-11349. Add NullPointer handling when volume/bucket tables are not initialized (apache#7103)
HDDS-11209. Avoid insufficient EC pipelines in the container pipeline cache (apache#6974)
HDDS-11284. refactor quota repair non-blocking while upgrade (apache#7035)
HDDS-9790. Add tests for Overview page (apache#6983)
HDDS-10904. [hsync] Enable PutBlock piggybacking and incremental chunk list by default (apache#7074)
HDDS-11322. [hsync] Block ECKeyOutputStream from calling hsync and hflush (apache#7098)
HDDS-11325. Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose (apache#7099)
HDDS-11340. Avoid extra PubBlock call when a full block is closed (apache#7094)
HDDS-11155. Improve Volumes page UI (apache#7048)
HDDS-11324. Negative value preOpLatencyMs in DN audit log (apache#7093)
HDDS-11246. [Recon] Use optional chaining instead of explicit undefined check for Objects in Container and Pipeline Module. (apache#7037)
HDDS-11323. Mark TestLeaseRecovery as flaky
HDDS-11338. Bump zstd-jni to 1.5.6-4 (apache#7085)
HDDS-11337. Bump Spring Framework to 5.3.39 (apache#7084)
HDDS-11327. [hsync] Revert config default ozone.fs.hsync.enabled to false (apache#7079)
HDDS-11325. Mark testWriteMoreThanMaxFlushSize as flaky
HDDS-11336. Bump slf4j to 2.0.16 (apache#7086)
HDDS-11335. Bump exec-maven-plugin to 3.4.1 (apache#7087)
...
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
@smengcl

smengcl commented Aug 22, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks @jojochuang and @ashishkumar50 for reviewing this one.

errose28 added a commit to errose28/ozone that referenced this pull request Aug 26, 2024
@errose28
Merge branch 'HDDS-10239-container-reconciliation' into HDDS-11290-sc…
769a9aa
…an-on-error
* HDDS-10239-container-reconciliation: (428 commits)
HDDS-11081. Use thread-local instance of FileSystem in Freon tests (apache#7091)
HDDS-11333. Avoid hard-coded current version in upgrade/xcompat tests (apache#7089)
Mark TestPipelineManagerMXBean#testPipelineInfo as flaky
Mark TestAddRemoveOzoneManager#testForceBootstrap as flaky
HDDS-11352. HDDS-11353. Mark TestOzoneManagerHAWithStoppedNodes as flaky
HDDS-11354. Mark TestOzoneManagerSnapshotAcl#testLookupKeyWithNotAllowedUserForPrefixAcl as flaky
HDDS-11355. Mark TestMultiBlockWritesWithDnFailures#testMultiBlockWritesWithIntermittentDnFailures as flaky
HDDS-11227. Use server default key provider to encrypt/decrypt keys from multiple OMs. (apache#7081)
HDDS-11316. Improve Create Key and Chunk IO Dashboards (apache#7075)
HDDS-11239. Fix KeyOutputStream's exception handling when calling hsync concurrently (apache#7047)
HDDS-11254. Reconcile commands should be handled by datanode ReplicationSupervisor (apache#7076)
HDDS-11331. Fix Datanode unable to report for a long time (apache#7090)
HDDS-11346. FS CLI gives incorrect recursive volume deletion prompt (apache#7102)
HDDS-11349. Add NullPointer handling when volume/bucket tables are not initialized (apache#7103)
HDDS-11209. Avoid insufficient EC pipelines in the container pipeline cache (apache#6974)
HDDS-11284. refactor quota repair non-blocking while upgrade (apache#7035)
HDDS-9790. Add tests for Overview page (apache#6983)
HDDS-10904. [hsync] Enable PutBlock piggybacking and incremental chunk list by default (apache#7074)
HDDS-11322. [hsync] Block ECKeyOutputStream from calling hsync and hflush (apache#7098)
HDDS-11325. Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose (apache#7099)
...
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerCheck.java
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
errose28 added a commit to errose28/ozone that referenced this pull request Aug 28, 2024
@errose28
Merge branch 'HDDS-10239-container-reconciliation' into HDDS-11253-co…
426beac
…rrupt-files
* HDDS-10239-container-reconciliation: (61 commits)
HDDS-11081. Use thread-local instance of FileSystem in Freon tests (apache#7091)
HDDS-11333. Avoid hard-coded current version in upgrade/xcompat tests (apache#7089)
Mark TestPipelineManagerMXBean#testPipelineInfo as flaky
Mark TestAddRemoveOzoneManager#testForceBootstrap as flaky
HDDS-11352. HDDS-11353. Mark TestOzoneManagerHAWithStoppedNodes as flaky
HDDS-11354. Mark TestOzoneManagerSnapshotAcl#testLookupKeyWithNotAllowedUserForPrefixAcl as flaky
HDDS-11355. Mark TestMultiBlockWritesWithDnFailures#testMultiBlockWritesWithIntermittentDnFailures as flaky
HDDS-11227. Use server default key provider to encrypt/decrypt keys from multiple OMs. (apache#7081)
HDDS-11316. Improve Create Key and Chunk IO Dashboards (apache#7075)
HDDS-11239. Fix KeyOutputStream's exception handling when calling hsync concurrently (apache#7047)
HDDS-11254. Reconcile commands should be handled by datanode ReplicationSupervisor (apache#7076)
HDDS-11331. Fix Datanode unable to report for a long time (apache#7090)
HDDS-11346. FS CLI gives incorrect recursive volume deletion prompt (apache#7102)
HDDS-11349. Add NullPointer handling when volume/bucket tables are not initialized (apache#7103)
HDDS-11209. Avoid insufficient EC pipelines in the container pipeline cache (apache#6974)
HDDS-11284. refactor quota repair non-blocking while upgrade (apache#7035)
HDDS-9790. Add tests for Overview page (apache#6983)
HDDS-10904. [hsync] Enable PutBlock piggybacking and incremental chunk list by default (apache#7074)
HDDS-11322. [hsync] Block ECKeyOutputStream from calling hsync and hflush (apache#7098)
HDDS-11325. Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose (apache#7099)
...
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java
ivandika3 pushed a commit to ivandika3/ozone that referenced this pull request Oct 12, 2025
@smengcl@ivandika3
HDDS-11346. FS CLI gives incorrect recursive volume deletion prompt (a…
b8b2144
…pache#7102)
(cherry picked from commit 91fb176)
ivandika3 pushed a commit to ivandika3/ozone that referenced this pull request Oct 13, 2025
@smengcl@ivandika3
HDDS-11346. FS CLI gives incorrect recursive volume deletion prompt (a…
26b9831
…pache#7102)
(cherry picked from commit 91fb176)
ivandika3 pushed a commit to ivandika3/ozone that referenced this pull request Oct 13, 2025
@smengcl@ivandika3
HDDS-11346. FS CLI gives incorrect recursive volume deletion prompt (a…
281e783
…pache#7102)
(cherry picked from commit 91fb176)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jojochuangjojochuangjojochuang approved these changes
@ashishkumar50ashishkumar50ashishkumar50 approved these changes

Assignees

@smengclsmengcl

Labels

client

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smengcl@jojochuang@ashishkumar50