Uh oh!
There was an error while loading. Please reload this page.
HDDS-11345. Add metrics specific tests for reconciliation tasks. - #7732
Conversation
errose28
left a comment
There was a problem hiding this comment.
Thanks for adding the test @aswinshakil. Can we move this so the tests for reconciliation tasks are in their own test method within TestReplicationSupervisor? We can throw one into the mix in testMultipleReplication since it is already there, but that method is already testing too many things at once and it is hard to follow the individual things being checked.
errose28
left a comment
There was a problem hiding this comment.
Thanks for updating this @aswinshakil
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
errose28
commented
Jan 24, 2025
We need #7699 in our branch to fix acceptance tests |
errose28
left a comment
There was a problem hiding this comment.
Thanks for the updates @aswinshakil. Let's get the reverse merge from master in to fix our CI, then we can start merging our approved PRs to the branch.
errose28
commented
Feb 7, 2025
@aswinshakil The reverse merge from master is done with green CI. Please merge this into your PR branch to retrigger CI with the new changes, which should fix the acceptance test issues. |
What changes were proposed in this pull request?
#7140 Added a framework to add metrics for any
AbstractReplicationTask. This adds all the necessary metrics required for container reconciliation task(ReconcileContainerTask). This JIRA aims to add tests for these metrics.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11345
How was this patch tested?
Added unit tests.