Skip to content

HDDS-12132. Parameterize testUpdateTransactionInfoTable for SCM - #7768

Merged
adoroszlai merged 4 commits into
apache:masterfrom
sarvekshayr:HDDS-12132
Jan 31, 2025
Merged

HDDS-12132. Parameterize testUpdateTransactionInfoTable for SCM#7768
adoroszlai merged 4 commits into
apache:masterfrom
sarvekshayr:HDDS-12132

Conversation

@sarvekshayr

@sarvekshayrsarvekshayr commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Updated TestOzoneRepairShell to also exercise new ozone repair scm update-transaction.

What is the link to the Apache JIRA

HDDS-12132

How was this patch tested?

Passed all tests in TestOzoneRepairShell.

peterxcli
peterxcli approved these changes Jan 28, 2025
View reviewed changes

@peterxclipeterxcli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the path! Overall LGLM, added some comments, please take them with a grain of salt.

Comment thread...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java Outdated
Comment thread...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java Outdated
adoroszlai
adoroszlai reviewed Jan 31, 2025
View reviewed changes

@adoroszlaiadoroszlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarvekshayr for updating the patch. Two minor code improvements suggested.

Comment threadhadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/TransactionInfoRepair.java Outdated
Comment thread...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java Outdated
Comment thread...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java Outdated
Comment thread...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java Outdated
Comment thread...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java Outdated
@adoroszlai
adoroszlai merged commit 182d106 into apache:masterJan 31, 2025
@adoroszlai

adoroszlai commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Thanks @sarvekshayr for the patch, @peterxcli for the review.

errose28 added a commit to errose28/ozone that referenced this pull request Feb 5, 2025
@errose28
Merge branch 'master' into HDDS-10239-container-reconciliation
3797c28
* master: (168 commits)
HDDS-12112. Fix interval used for Chunk Read/Write Dashboard (apache#7724)
HDDS-12212. Fix grammar in decommissioning and observability documentation (apache#7815)
HDDS-12195. Implement skip() in OzoneFSInputStream (apache#7801)
HDDS-12200. Fix grammar in OM HA, EC and Snapshot doc (apache#7806)
HDDS-12202. OpsCreate and OpsAppend metrics not incremented (apache#7811)
HDDS-12203. Initialize block length before skip (apache#7809)
HDDS-12183. Reuse cluster across safe test classes (apache#7793)
HDDS-11714. resetDeletedBlockRetryCount with --all may fail and can cause long db lock in large cluster. (apache#7665)
HDDS-12186. (addendum) Avoid array allocation for table iterator (apache#7799)
HDDS-12186. Avoid array allocation for table iterator. (apache#7797)
HDDS-11508. Decouple delete batch limits from Ratis request size for DirectoryDeletingService. (apache#7365)
HDDS-12073. Don't show Source Bucket and Volume if null in DU metadata (apache#7760)
HDDS-12142. Save logs from build check (apache#7782)
HDDS-12163. Reduce number of individual getCapacity/getAvailable/getUsedSpace calls (apache#7790)
HDDS-12176. Trivial dependency cleanup.(apache#7787)
HDDS-12181. Bump jline to 3.29.0 (apache#7789)
HDDS-12165. Refactor VolumeInfoMetrics to use getCurrentUsage (apache#7784)
HDDS-12085. Add manual refresh button for DU page (apache#7780)
HDDS-12132. Parameterize testUpdateTransactionInfoTable for SCM (apache#7768)
HDDS-11277. Remove dependency on hadoop-hdfs in Ozone client (apache#7781)
...
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueHandler.java
hadoop-ozone/dist/src/main/smoketest/admincli/container.robot
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/ClosedContainerReplicator.java
errose28 added a commit to errose28/ozone that referenced this pull request Feb 6, 2025
@errose28
Merge branch 'master' into HDDS-10239-container-reconciliation
2cfd22a
* master: (168 commits)
HDDS-12112. Fix interval used for Chunk Read/Write Dashboard (apache#7724)
HDDS-12212. Fix grammar in decommissioning and observability documentation (apache#7815)
HDDS-12195. Implement skip() in OzoneFSInputStream (apache#7801)
HDDS-12200. Fix grammar in OM HA, EC and Snapshot doc (apache#7806)
HDDS-12202. OpsCreate and OpsAppend metrics not incremented (apache#7811)
HDDS-12203. Initialize block length before skip (apache#7809)
HDDS-12183. Reuse cluster across safe test classes (apache#7793)
HDDS-11714. resetDeletedBlockRetryCount with --all may fail and can cause long db lock in large cluster. (apache#7665)
HDDS-12186. (addendum) Avoid array allocation for table iterator (apache#7799)
HDDS-12186. Avoid array allocation for table iterator. (apache#7797)
HDDS-11508. Decouple delete batch limits from Ratis request size for DirectoryDeletingService. (apache#7365)
HDDS-12073. Don't show Source Bucket and Volume if null in DU metadata (apache#7760)
HDDS-12142. Save logs from build check (apache#7782)
HDDS-12163. Reduce number of individual getCapacity/getAvailable/getUsedSpace calls (apache#7790)
HDDS-12176. Trivial dependency cleanup.(apache#7787)
HDDS-12181. Bump jline to 3.29.0 (apache#7789)
HDDS-12165. Refactor VolumeInfoMetrics to use getCurrentUsage (apache#7784)
HDDS-12085. Add manual refresh button for DU page (apache#7780)
HDDS-12132. Parameterize testUpdateTransactionInfoTable for SCM (apache#7768)
HDDS-11277. Remove dependency on hadoop-hdfs in Ozone client (apache#7781)
...
Conflicts:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueHandler.java
hadoop-ozone/dist/src/main/smoketest/admincli/container.robot
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/ClosedContainerReplicator.java
errose28 added a commit to errose28/ozone that referenced this pull request Feb 7, 2025
@errose28
Merge branch 'HDDS-10239-container-reconciliation' into HDDS-12079-tr…
dceb3ef
…ee-improvements
* HDDS-10239-container-reconciliation: (168 commits)
HDDS-12112. Fix interval used for Chunk Read/Write Dashboard (apache#7724)
HDDS-12212. Fix grammar in decommissioning and observability documentation (apache#7815)
HDDS-12195. Implement skip() in OzoneFSInputStream (apache#7801)
HDDS-12200. Fix grammar in OM HA, EC and Snapshot doc (apache#7806)
HDDS-12202. OpsCreate and OpsAppend metrics not incremented (apache#7811)
HDDS-12203. Initialize block length before skip (apache#7809)
HDDS-12183. Reuse cluster across safe test classes (apache#7793)
HDDS-11714. resetDeletedBlockRetryCount with --all may fail and can cause long db lock in large cluster. (apache#7665)
HDDS-12186. (addendum) Avoid array allocation for table iterator (apache#7799)
HDDS-12186. Avoid array allocation for table iterator. (apache#7797)
HDDS-11508. Decouple delete batch limits from Ratis request size for DirectoryDeletingService. (apache#7365)
HDDS-12073. Don't show Source Bucket and Volume if null in DU metadata (apache#7760)
HDDS-12142. Save logs from build check (apache#7782)
HDDS-12163. Reduce number of individual getCapacity/getAvailable/getUsedSpace calls (apache#7790)
HDDS-12176. Trivial dependency cleanup.(apache#7787)
HDDS-12181. Bump jline to 3.29.0 (apache#7789)
HDDS-12165. Refactor VolumeInfoMetrics to use getCurrentUsage (apache#7784)
HDDS-12085. Add manual refresh button for DU page (apache#7780)
HDDS-12132. Parameterize testUpdateTransactionInfoTable for SCM (apache#7768)
HDDS-11277. Remove dependency on hadoop-hdfs in Ozone client (apache#7781)
...
nandakumar131 pushed a commit to nandakumar131/ozone that referenced this pull request Feb 10, 2025
@sarvekshayr@nandakumar131
HDDS-12132. Parameterize testUpdateTransactionInfoTable for SCM (apac…
0044566
…he#7768)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adoroszlaiadoroszlaiadoroszlai approved these changes
@peterxclipeterxclipeterxcli approved these changes

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarvekshayr@adoroszlai@peterxcli