Uh oh!
There was an error while loading. Please reload this page.
HDDS-12184. Enhance NSSummaryTask process() for Faster Processing. - #7795
HDDS-12184. Enhance NSSummaryTask process() for Faster Processing.#7795ArafatKhan2198 wants to merge 1 commit into
Conversation
| LOG.error("processWithOBS failed."); | ||
| // Thread pool to execute tasks concurrently | ||
| ExecutorService executorService = Executors.newFixedThreadPool(3); |
There was a problem hiding this comment.
Creating a thread pool is heavy-weight, it should be reused.
| for (Future<Boolean> result : results) { | ||
| if (!result.get()) { | ||
| LOG.error("One or more process tasks failed."); | ||
| return new ImmutablePair<>(getTaskName(), false); |
There was a problem hiding this comment.
Wait for all results before returning.
adoroszlai
commented
Apr 3, 2025
/pending |
Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author. It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time. It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs. If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel." |
What changes were proposed in this pull request?
We can parallelize the
process()method inNSSummaryTasksimilarly to how reprocess() was parallelized. Instead of runningprocessWithFSO(),processWithLegacy(), andprocessWithOBS()sequentially, we can execute them concurrently using an ExecutorService.We will :-
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12184
How was this patch tested?
Manually Tested