Uh oh!
There was an error while loading. Please reload this page.
HDDS-3411. Switch Recon SQL DB to Derby. - #839
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vivekratnavel
commented
Apr 17, 2020
@avijayanhwx Thanks for working on this! Looks like the integration test failure might be related to this change. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vivekratnavel
left a comment
There was a problem hiding this comment.
+1 Overall LGTM. A couple of minor comments inline.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vivekratnavel
commented
Apr 30, 2020
@avijayanhwx Thanks for working on this! |
What changes were proposed in this pull request?
Recon currently uses Sqlite as its defacto SQL DB with an option to configure other JDBC compatible databases. However, on some platforms like the IBM power pc, this causes problems from compile time since it does not have the sqlite native driver. This task aims to change the default SQL DB used by Recon to Derby, but retains the out of the box support (no need to supply the driver) for Sqlite as well.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3411
How was this patch tested?
Added unit tests.
Manually tested on docker with Derby and Sqlite.
Built the recon modules on IBM PPC host.