Uh oh!
There was an error while loading. Please reload this page.
HDDS-13228. Take snapshot cache lock during the last iteration of tarball transfer. - #8678
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| LOG.warn("SnapshotId: '{}' does not exist in snapshot cache.", k); | ||
| } else { | ||
| try { | ||
| v.get().getMetadataManager().getStore().flushDB(); |
There was a problem hiding this comment.
is this necessary?
https://javadoc.io/doc/org.rocksdb/rocksdbjni/6.8.1/org/rocksdb/Options.html#avoidFlushDuringShutdown()
By default RocksDB will flush all memtables on DB close if there are unpersisted data (i.e. with WAL disabled) T
There was a problem hiding this comment.
Without this, I didn't find the .sst file visible in the rocksdb directory which is why I added it because the WAL is enabled in our case.
jojochuang
left a comment
There was a problem hiding this comment.
A few cosmetic issues but overall looks fine. Made a few suggestions we can incorporate them in later PRs.
| OM_DB_NAME + checkpointDirName; | ||
| } | ||
| public static String extractSnapshotIDFromCheckpointDirName(String snapshotPath) { |
There was a problem hiding this comment.
this public static method does not have test coverage, is only used by OMDBCheckpointServletInodeBasedXfer, and does not use any internal variables or method inside OmSnapshotManager. It should be moved into OMDBCheckpointServletInodeBasedXfer as a private method.
Otherwise if it is intended to be used as is later, please add javadoc and test coverage.
| when(responseMock.getOutputStream()).thenReturn(servletOutputStream); | ||
| } | ||
| String getValueFromSnapshotDeleteTable(String key, String snapshotDB) { |
There was a problem hiding this comment.
| StringgetValueFromSnapshotDeleteTable(Stringkey, StringsnapshotDB) { | |
| privateStringgetValueFromSnapshotDeleteTable(Stringkey, StringsnapshotDB) { |
| return OMConfigKeys.OZONE_OM_DB_DIRS; | ||
| } | ||
| public static List<String> getAllColumnFamilies() { |
There was a problem hiding this comment.
| publicstaticList<String> getAllColumnFamilies() { | |
| /** | |
| * Returnsalistofallcolumnfamilynamesdefinedinthedatabase. | |
| * | |
| * @returnlistofcolumnfamilynames | |
| */ | |
| publicstaticList<String> getAllColumnFamilies() { |
Uh oh!
There was an error while loading. Please reload this page.
sadanand48
commented
Jul 10, 2025
Thanks @jojochuang for the review. |
…n of tarball transfer. (apache#8678)" This reverts commit c706c7a. Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java Change-Id: I77e2f08e4cc6b3c698387e3330985580ae117b69
…n of tarball transfer. (apache#8678)" This reverts commit c706c7a. Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
…n of tarball transfer. (#8678)" This reverts commit c706c7a. Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMDbCheckpointServletInodeBasedXfer.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
What changes were proposed in this pull request?
Take snapshot cache lock during the last iteration of tarball transfer
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13228
How was this patch tested?
Unit tests